Merge pull request #1590 from balena-io/remove-unnecessary-code

Remove unnecessary code now that typescript understands `process.exit`

automation/run.ts

@@ -31,7 +31,6 @@ import { fixPathForMsys, ROOT, runUnderMsys } from './utils';
 function exitWithError(error: Error | string): never {
 	console.error(`Error: ${error}`);
 	process.exit(1);
-	throw error; // to please the Typescript compiler
 }
 
 /**

lib/app-common.ts

@@ -58,7 +58,7 @@ function setupRaven() {
 		release: require('../package.json').version,
 	}).install(function(_logged: any, error: Error) {
 		console.error(error);
-		return process.exit(1);
+		process.exit(1);
 	});
 
 	Raven.setContext({

lib/utils/patterns.ts

@@ -454,6 +454,4 @@ export function exitWithExpectedError(message: string | Error): never {
 
 	printErrorMessage(message);
 	process.exit(1);
-	// The following throw is to make tsc happy about the `never` return type.
-	throw new Error('exit');
 }