ExternalVendorCode/balena-cli
1
0
Fork 0
mirror of https://github.com/balena-io/balena-cli.git synced 2025-04-13 06:02:57 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request from balena-io/rename-devices-beta-new

Browse Source 
Rename BETA to NEW in `devices supported -v`
This commit is contained in:
bulldozer-balena[bot] 2020-07-28 14:26:37 +00:00 committed by GitHub
commit 29854f8737
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 11 additions and 11 deletions
doc
cli.markdown
lib
actions-oclif/devices
supported.ts
utils
cloud.ts
tests/commands/device
supported.spec.ts

2
doc/cli.markdown

@ -710,7 +710,7 @@ same as '--application'
List the supported device types (like 'raspberrypi3' or 'intel-nuc').
The --verbose option adds extra columns/fields to the output, including the
"STATE" column whose values are one of 'beta', 'released' or 'discontinued'.
"STATE" column whose values are one of 'new', 'released' or 'discontinued'.
However, 'discontinued' device types are only listed if the '--discontinued'
option is used.

14
lib/actions-oclif/devices/supported.ts

@ -22,7 +22,6 @@ import Command from '../../command';
import * as cf from '../../utils/common-flags';
import { getBalenaSdk, getVisuals, stripIndent } from '../../utils/lazy';
import { CommandHelp } from '../../utils/oclif-utils';
import { isV12 } from '../../utils/version';
interface FlagsDef {
discontinued: boolean;
@ -38,7 +37,7 @@ export default class DevicesSupportedCmd extends Command {
List the supported device types (like 'raspberrypi3' or 'intel-nuc').
The --verbose option adds extra columns/fields to the output, including the
"STATE" column whose values are one of 'beta', 'released' or 'discontinued'.
"STATE" column whose values are one of 'new', 'released' or 'discontinued'.
However, 'discontinued' device types are only listed if the '--discontinued'
option is used.
@ -98,11 +97,14 @@ export default class DevicesSupportedCmd extends Command {
}
const fields = options.verbose
? ['slug', 'aliases', 'arch', 'state', 'name']
: isV12()
? ['slug', 'aliases', 'arch', 'name']
: ['slug', 'name'];
: ['slug', 'aliases', 'arch', 'name'];
deviceTypes = _.sortBy(
deviceTypes.map((d) => _.pick(d, fields) as Partial<SDK.DeviceType>),
deviceTypes.map((d) => {
const picked = _.pick<Partial<SDK.DeviceType>>(d, fields);
// 'BETA' renamed to 'NEW'
picked.state = picked.state === 'BETA' ? 'NEW' : picked.state;
return picked;
}),
fields,
);
if (options.json) {

4
lib/utils/cloud.ts

@ -130,9 +130,7 @@ export async function downloadOSImage(
console.info(`Getting device operating system for ${deviceType}`);
if (!OSVersion) {
console.warn(
'Using default OS version: the latest stable version, or the latest version for pre-release devices',
);
console.warn('OS version not specified: using latest stable version');
}
OSVersion = OSVersion

2
tests/commands/device/supported.spec.ts

@ -58,7 +58,7 @@ describe('balena devices supported', function () {
// Discontinued devices should be filtered out from results
expect(lines.some((l) => l.includes('DISCONTINUED'))).to.be.false;
// Experimental devices should be listed as beta
// Experimental devices should be listed as new
expect(lines.some((l) => l.includes('EXPERIMENTAL'))).to.be.false;
expect(lines.some((l) => l.includes('NEW'))).to.be.true;