ExternalVendorCode/balena-cli
1
0
Fork 0
mirror of https://github.com/balena-io/balena-cli.git synced 2025-04-07 19:34:13 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use rimraf for deleting os temporary files

Browse Source 
We already use `rimraf` for deleting os temporary directories, however
there are a few benefits of using it for files as well:

- Simplicity. We avoid having to check if a path is a file or directory.
- `rimraf` attempts to workaround the known Windows issues of anti
viruses not closing files. Described in more detail here: https://github.com/resin-io/resin-cli/blob/master/TROUBLESHOOTING.md#i-get-ebusy-errors-after-initializing-a-device-even-as-administrator-on-windows
This commit is contained in:
Juan Cruz Viotti 2015-09-29 15:28:39 -04:00
parent a3ebd9827f
commit 15cb0c4889
2 changed files with 3 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
build/actions/device.js
View File

@ -1,5 +1,5 @@
(function() {
var Promise, _, capitano, commandOptions, events, form, fs, patterns, resin, rimraf, tmp, visuals;
var Promise, _, capitano, commandOptions, events, form, patterns, resin, rimraf, tmp, visuals;
Promise = require('bluebird');
@ -15,8 +15,6 @@
events = require('resin-cli-events');
fs = Promise.promisifyAll(require('fs'));
rimraf = Promise.promisify(require('rimraf'));
patterns = require('../utils/patterns');
@ -145,14 +143,7 @@
download = function() {
return tmp.tmpNameAsync().then(function(temporalPath) {
return capitano.runAsync("os download --output " + temporalPath);
}).disposer(function(temporalPath) {
return fs.statAsync(temporalPath).then(function(stat) {
if (stat.isDirectory()) {
return rimraf(temporalPath);
}
return fs.unlinkAsync(temporalPath);
});
});
}).disposer(_.ary(rimraf, 1));
};
return Promise.using(download()).then(function(temporalPath) {
return capitano.runAsync("device register " + application.app_name).then(resin.models.device.get).tap(function(device) {

6
lib/actions/device.coffee
View File

@ -5,7 +5,6 @@ resin = require('resin-sdk')
visuals = require('resin-cli-visuals')
form = require('resin-cli-form')
events = require('resin-cli-events')
fs = Promise.promisifyAll(require('fs'))
rimraf = Promise.promisify(require('rimraf'))
patterns = require('../utils/patterns')
tmp = Promise.promisifyAll(require('tmp'))
@ -200,10 +199,7 @@ exports.init =
download = ->
tmp.tmpNameAsync().then (temporalPath) ->
capitano.runAsync("os download --output #{temporalPath}")
.disposer (temporalPath) ->
fs.statAsync(temporalPath).then (stat) ->
return rimraf(temporalPath) if stat.isDirectory()
return fs.unlinkAsync(temporalPath)
.disposer(_.ary(rimraf, 1))
Promise.using(download()).then (temporalPath) ->
capitano.runAsync("device register #{application.app_name}")