From e2ca239be05ac4787091eb298ce0ed1012eacbd3 Mon Sep 17 00:00:00 2001 From: Adam Ierymenko Date: Tue, 21 Jun 2016 14:38:15 -0700 Subject: [PATCH] Comment cleanup. --- osdep/ManagedRoute.cpp | 5 +++-- osdep/ManagedRoute.hpp | 3 +++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/osdep/ManagedRoute.cpp b/osdep/ManagedRoute.cpp index aee019549..549901224 100644 --- a/osdep/ManagedRoute.cpp +++ b/osdep/ManagedRoute.cpp @@ -346,9 +346,10 @@ static bool _winRoute(bool del,const NET_LUID &interfaceLuid,const NET_IFINDEX & } // anonymous namespace /* Linux NOTE: for default route override, some Linux distributions will - * require a change to the rp_filter parameter. + * require a change to the rp_filter parameter. A value of '1' will prevent + * default route override from working properly. * - * sudo sysctl net.ipv4.conf.all.rp_filter=2 + * sudo sysctl -w net.ipv4.conf.all.rp_filter=2 * * Add to /etc/sysctl.conf or /etc/sysctl.d/... to make permanent. * diff --git a/osdep/ManagedRoute.hpp b/osdep/ManagedRoute.hpp index 7000e3a42..5dde12ad2 100644 --- a/osdep/ManagedRoute.hpp +++ b/osdep/ManagedRoute.hpp @@ -50,6 +50,9 @@ public: /** * Initialize object and set route * + * Note: on Windows, use the interface NET_LUID in hexadecimal as the + * "device name." + * * @param target Route target (e.g. 0.0.0.0/0 for default) * @param via Route next L3 hop or NULL InetAddress if local * @param device Device name/ID if 'via' is null and route is local, otherwise ignored