ExternalVendorCode/ZeroTierOne
1
0
Fork 0
mirror of https://github.com/zerotier/ZeroTierOne.git synced 2025-05-09 12:02:50 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

getUpstreamPeer issue with interim federated roots

Browse Source
This commit is contained in:
Adam Ierymenko 2017-03-10 19:31:51 -08:00
parent 47166c9614
commit db87d95c1d
1 changed files with 27 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

75
node/Topology.cpp
View File

@ -159,61 +159,40 @@ void Topology::saveIdentity(const Identity &id)
SharedPtr<Peer> Topology::getUpstreamPeer(const Address *avoid,unsigned int avoidCount,bool strictAvoid) SharedPtr<Peer> Topology::getUpstreamPeer(const Address *avoid,unsigned int avoidCount,bool strictAvoid)
{ {
const uint64_t now = RR->node->now(); const uint64_t now = RR->node->now();
unsigned int bestQualityOverall = ~((unsigned int)0);
unsigned int bestQualityNotAvoid = ~((unsigned int)0);
const SharedPtr<Peer> *bestOverall = (const SharedPtr<Peer> *)0;
const SharedPtr<Peer> *bestNotAvoid = (const SharedPtr<Peer> *)0;
Mutex::Lock _l1(_peers_m); Mutex::Lock _l1(_peers_m);
Mutex::Lock _l2(_upstreams_m); Mutex::Lock _l2(_upstreams_m);
if (_amRoot) { for(std::vector<Address>::const_iterator a(_upstreamAddresses.begin());a!=_upstreamAddresses.end();++a) {
/* If I am a root, pick another root that isn't mine and that const SharedPtr<Peer> *p = _peers.get(*a);
* has a numerically greater ID. This causes packets to roam if (p) {
* around the top rather than bouncing between just two. */ bool avoiding = false;
for(unsigned int i=0;i<avoidCount;++i) {
for(unsigned long p=0;p<_upstreamAddresses.size();++p) { if (avoid[i] == (*p)->address()) {
if (_upstreamAddresses[p] == RR->identity.address()) { avoiding = true;
for(unsigned long q=1;q<_upstreamAddresses.size();++q) { break;
const SharedPtr<Peer> *const nextsn = _peers.get(_upstreamAddresses[(p + q) % _upstreamAddresses.size()]);
if ((nextsn)&&((*nextsn)->hasActiveDirectPath(now)))
return *nextsn;
}
break;
}
}
} else {
/* Otherwise pick the bestest looking upstream */
unsigned int bestQualityOverall = ~((unsigned int)0);
unsigned int bestQualityNotAvoid = ~((unsigned int)0);
const SharedPtr<Peer> *bestOverall = (const SharedPtr<Peer> *)0;
const SharedPtr<Peer> *bestNotAvoid = (const SharedPtr<Peer> *)0;
for(std::vector<Address>::const_iterator a(_upstreamAddresses.begin());a!=_upstreamAddresses.end();++a) {
const SharedPtr<Peer> *p = _peers.get(*a);
if (p) {
bool avoiding = false;
for(unsigned int i=0;i<avoidCount;++i) {
if (avoid[i] == (*p)->address()) {
avoiding = true;
break;
}
}
const unsigned int q = (*p)->relayQuality(now);
if (q <= bestQualityOverall) {
bestQualityOverall = q;
bestOverall = &(*p);
}
if ((!avoiding)&&(q <= bestQualityNotAvoid)) {
bestQualityNotAvoid = q;
bestNotAvoid = &(*p);
} }
} }
const unsigned int q = (*p)->relayQuality(now);
if (q <= bestQualityOverall) {
bestQualityOverall = q;
bestOverall = &(*p);
}
if ((!avoiding)&&(q <= bestQualityNotAvoid)) {
bestQualityNotAvoid = q;
bestNotAvoid = &(*p);
}
} }
}
if (bestNotAvoid) { if (bestNotAvoid) {
return *bestNotAvoid; return *bestNotAvoid;
} else if ((!strictAvoid)&&(bestOverall)) { } else if ((!strictAvoid)&&(bestOverall)) {
return *bestOverall; return *bestOverall;
}
} }
return SharedPtr<Peer>(); return SharedPtr<Peer>();