More controller work -- it builds!

controller/SqliteNetworkController.hpp

@@ -14,15 +14,6 @@
  *
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
- * --
- *
- * ZeroTier may be used and distributed under the terms of the GPLv3, which
- * are available at: http://www.gnu.org/licenses/gpl-3.0.html
- *
- * If you would like to embed ZeroTier into a commercial application or
- * redistribute it in a modified binary form, please contact ZeroTier Networks
- * LLC. Start here: http://www.zerotier.com/
  */
 
 #ifndef ZT_SQLITENETWORKCONTROLLER_HPP
@@ -38,9 +29,11 @@
 
 #include "../node/NetworkController.hpp"
 #include "../node/Mutex.hpp"
-#include "../osdep/Thread.hpp"
+#include "../node/Utils.hpp"
 
-#include "../ext/offbase/offbase.hpp"
+#include "../osdep/OSUtils.hpp"
+
+#include "../ext/json/json.hpp"
 
 namespace ZeroTier {
 
@@ -82,10 +75,6 @@ public:
 		std::string &responseBody,
 		std::string &responseContentType);
 
-	// threadMain() for backup thread -- do not call directly
-	void threadMain()
-		throw();
-
 private:
 	unsigned int _doCPGet(
 		const std::vector<std::string> &path,
@@ -97,11 +86,57 @@ private:
 
 	static void _circuitTestCallback(ZT_Node *node,ZT_CircuitTest *test,const ZT_CircuitTestReport *report);
 
+	inline nlohmann::json _readJson(const std::string &path)
+	{
+		std::string buf;
+		if (OSUtils::readFile(path.c_str(),buf)) {
+			try {
+				return nlohmann::json::parse(buf);
+			} catch ( ... ) {}
+		}
+		return nlohmann::json::object();
+	}
+
+	inline bool _writeJson(const std::string &path,const nlohmann::json &obj)
+	{
+		std::string buf(obj.dump(2));
+		return OSUtils::writeFile(path.c_str(),buf);
+	}
+
+	inline std::string _networkBP(const uint64_t nwid,bool create)
+	{
+		char tmp[64];
+		Utils::snprintf(tmp,sizeof(tmp),"%.16llx",nwid);
+		std::string p(_path + ZT_PATH_SEPARATOR_S + "network");
+		if (create) OSUtils::mkdir(p.c_str());
+		p.push_back(ZT_PATH_SEPARATOR);
+		p.append(tmp);
+		if (create) OSUtils::mkdir(p.c_str());
+		return p;
+	}
+	inline std::string _networkJP(const uint64_t nwid,bool create)
+	{
+		return (_networkBP(nwid,create) + ZT_PATH_SEPARATOR + "config.json");
+	}
+	inline std::string _memberBP(const uint64_t nwid,const Address &member,bool create)
+	{
+		std::string p(_networkBP(nwid,create));
+		p.push_back(ZT_PATH_SEPARATOR);
+		p.append("member");
+		if (create) OSUtils::mkdir(p.c_str());
+		p.push_back(ZT_PATH_SEPARATOR);
+		p.append(member.toString());
+		if (create) OSUtils::mkdir(p.c_str());
+		return p;
+	}
+	inline std::string _memberJP(const uint64_t nwid,const Address &member,bool create)
+	{
+		return (_memberBP(nwid,member,create) + ZT_PATH_SEPARATOR + "config.json");
+	}
+
+	// These are const after construction
 	Node *const _node;
-	std::string _instanceId;
-	offbase _db;
-	Thread _dbCommitThread;
-	volatile bool _dbCommitThreadRun;
+	std::string _path;
 
 	// Circuit tests outstanding
 	struct _CircuitTestEntry
@@ -110,11 +145,11 @@ private:
 		std::string jsonResults;
 	};
 	std::map< uint64_t,_CircuitTestEntry > _circuitTests;
+	Mutex _circuitTests_m;
 
 	// Last request time by address, for rate limitation
 	std::map< std::pair<uint64_t,uint64_t>,uint64_t > _lastRequestTime;
-
-	Mutex _lock;
+	Mutex _lastRequestTime_m;
 };
 
 } // namespace ZeroTier

ext/offbase/README.md

@@ -1,59 +0,0 @@
-A super-minimal in-filesystem persistent JSON object
-======
-
-[We](https://www.zerotier.com/) like minimalism.
-
-Offbase is an extension of the excellent [nlohmann/json](https://github.com/nlohmann/json) C++11 JSON class that adds simple object persistence to/from the filesystem. Objects are stored into a directory hierarchy in fully "expanded" form with each field/value being represented by a separate file.
-
-Features:
-
- - Very easy to use
- - Minimal!
-   - Easy to understand and maintain
-	 - Trivial to implement in other languages
-	 - No dependencies beyond standard libraries
-	 - Small code footprint in both source and binary form
-	 - Easy to port to other platforms
- - Exactly reproduces JSON object hierarchies including all JSON type information
- - Database can be explored from the shell, browsed in a web browser or file explorer, scanned with `find` and `grep`, etc.
- - Database can be backed up, restored, versioned, etc. with tools like `git`, `rsync`, `duplicity`, etc.
- - Alien files like `.git` or `.DS_Store` are harmlessly ignored if present
- - Saving only changes what's changed to reduce I/O overhead and SSD wear
-
-Limitations and shortcomings:
-
- - This creates a lot of tiny files, which is inefficient on some filesystems and might run into inode limits in extreme cases. For data sets with more than, say, a million items we recommend a filesystem like `btrfs` or `reiserfs`. Things like [redisfs](https://steve.fi/Software/redisfs/) are also worth exploring. On Linux another alternative is to put the database into `/dev/shm` (RAM disk) and then regularly back it up with `duplicity` or similar.
- - The whole JSON object is held in memory *twice* for diffing purposes.
- - Diffing traverses the whole tree and then updates the shadow copy, which makes `commit()` slow for huge data sets. This is not suitable for "big" data where "big" here is probably more than a few hundred megabytes.
- - Recursion is used, so if you have object hierarchies that are incredibly deep (hundreds or more) it might be possible to overflow your stack and crash your app.
- - This is not thread safe and must be guarded by a mutex if used in a threaded app.
-
-Caveats:
-
- - Key names are escaped for safety in the filesystem, but we still don't recommend allowing external users to set just anything into your JSON store. See the point about recursion under limitations.
-
-Future:
-
- - It would not be too hard to tie this into a filesystem change monitoring API and automatically read changes from disk if they are detected. This would allow the database to be edited "live" in the filesystem.
-   - In theory this could provide replication or clustering through distributed filesystems, file syncing, or things like [Amazon Elastic Filesystem](https://aws.amazon.com/efs/).
- - Recursion could be factored out to get rid of any object hierarchy depth constraints.
- - Mutexes could be integrated somehow to allow for finer grained locking in multithreaded apps.
- - Diffing and selective updates could be made more memory and CPU efficient using hashes, etc.
-
-## How to Use
-
-The `offbase` class just extends [nlohmann::json](https://github.com/nlohmann/json) and gives you a JSON object. Take care to make sure you don't change the type of the 'root' object represented by the 'offbase' instance from JSON 'object'. Anything under it can of course be any JSON type, including any object.
-
-Just put data into the object and then periodically call `commit()` to persist changes to disk. The `commit()` method diffs the current contents of the object with what it knows to have been previously persisted to disk and modifies the representation on disk to match. This can be done after writes or periodically in a background thread.
-
-See comments in `offbase.hpp` for full documentation including details about error handling, etc.
-
-## Persistence format
-
-The base object represented by the `offbase` instance is persisted into a directory hierarchy under its base path. Files and directories are named according to a simple convention of `keyname.typecode` where `keyname` is an escaped key name (or hex array index in the case of arrays) and `typecode` is a single character indicating whether the item is a JSON value, array, or object.
-
- - `*.V`: JSON values (actual value type is inferred during JSON parse)
- - `*.O`: JSON objects (these are subdirectories)
- - `*.A`: JSON arrays (also subdirectories containing items by hex array index)
-
-There are in theory simpler ways to represent JSON in a filesystem, such as the "flattened" JSON "pointer" format, but this has the disadvantage of not disambiguating objects vs. arrays. Offbase's persistence format is designed to perfectly reproduce the exact same JSON tree on load as was most recently committed.

ext/offbase/offbase.hpp

@@ -1,393 +0,0 @@
-/*
- * Offbase: a super-minimal in-filesystem JSON object persistence store
- */
-
-#ifndef OFFBASE_HPP__
-#define OFFBASE_HPP__
-
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-
-#include <dirent.h>
-#include <unistd.h>
-#include <sys/stat.h>
-
-#include <vector>
-#include <string>
-#include <map>
-
-#include "json/json.hpp"
-
-#define OFFBASE_PATH_SEP "/"
-
-/**
- * A super-minimal in-filesystem JSON object persistence store
- */
-class offbase : public nlohmann::json
-{
-public:
-	offbase(const char *p) :
-		nlohmann::json(nlohmann::json::object()),
-		_path(p),
-		_saved(nlohmann::json::object())
-	{
-		this->load();
-	}
-
-	~offbase()
-	{
-		this->commit();
-	}
-
-	/**
-	 * Load this instance from disk, clearing any existing contents first
-	 *
-	 * If the 'errors' vector is NULL, false is returned and reading aborts
-	 * on any error. If this parameter is non-NULL the paths of errors will
-	 * be added to the vector and reading will continue. False will only be
-	 * returned on really big errors like no path being defined.
-	 *
-	 * @param errors If specified, fill this vector with the paths to any objects that fail read
-	 * @return True on success, false on fatal error
-	 */
-	inline bool load(std::vector<std::string> *errors = (std::vector<std::string> *)0)
-	{
-		if (!_path.length())
-			return false;
-		*this = nlohmann::json::object();
-		if (!_loadObj(_path,*this,errors))
-			return false;
-		_saved = *(reinterpret_cast<nlohmann::json *>(this));
-		return true;
-	}
-
-	/**
-	 * Commit any pending changes to this object to disk
-	 *
-	 * @return True on success or false if an I/O error occurred
-	 */
-	inline bool commit(std::vector<std::string> *errors = (std::vector<std::string> *)0)
-	{
-		if (!_path.length())
-			return false;
-		if (!_commitObj(_path,*this,&_saved,errors))
-			return false;
-		_saved = *(reinterpret_cast<nlohmann::json *>(this));
-		return true;
-	}
-
-	static inline std::string escapeKey(const std::string &k)
-	{
-		std::string e;
-		const char *ptr = k.data();
-		const char *eof = ptr + k.length();
-		char tmp[8];
-		while (ptr != eof) {
-			if ( ((*ptr >= 'a')&&(*ptr <= 'z')) || ((*ptr >= 'A')&&(*ptr <= 'Z')) || ((*ptr >= '0')&&(*ptr <= '9')) || (*ptr == '.') || (*ptr == '_') || (*ptr == '-') || (*ptr == ',') )
-				e.push_back(*ptr);
-			else {
-				snprintf(tmp,sizeof(tmp),"~%.2x",(unsigned int)*ptr);
-				e.append(tmp);
-			}
-			++ptr;
-		}
-		return e;
-	}
-
-	static inline std::string unescapeKey(const std::string &k)
-	{
-		std::string u;
-		const char *ptr = k.data();
-		const char *eof = ptr + k.length();
-		char tmp[8];
-		while (ptr != eof) {
-			if (*ptr == '~') {
-				if (++ptr == eof) break;
-				tmp[0] = *ptr;
-				if (++ptr == eof) break;
-				tmp[1] = *(ptr++);
-				tmp[2] = (char)0;
-				u.push_back((char)strtol(tmp,(char **)0,16));
-			} else {
-				u.push_back(*(ptr++));
-			}
-		}
-		return u;
-	}
-
-private:
-	static inline bool _readFile(const char *path,std::string &buf)
-	{
-		char tmp[4096];
-		FILE *f = fopen(path,"rb");
-		if (f) {
-			for(;;) {
-				long n = (long)fread(tmp,1,sizeof(tmp),f);
-				if (n > 0)
-					buf.append(tmp,n);
-				else break;
-			}
-			fclose(f);
-			return true;
-		}
-		return false;
-	}
-
-	static inline bool _loadArr(const std::string &path,nlohmann::json &arr,std::vector<std::string> *errors)
-	{
-		std::map<unsigned long,nlohmann::json> atmp; // place into an ordered container first because filesystem does not guarantee this
-
-		struct dirent dbuf;
-		struct dirent *de;
-		DIR *d = opendir(path.c_str());
-		if (d) {
-			while (!readdir_d(d,&dbuf,&de)) {
-				if (!de) break;
-				const std::string name(de->d_name);
-				if (name.length() != 12) continue; // array entries are XXXXXXXXXX.T
-				if (name[name.length()-2] == '.') {
-					if (name[name.length()-1] == 'V') {
-						std::string buf;
-						if (_readFile((path + OFFBASE_PATH_SEP + name).c_str(),buf)) {
-							try {
-								atmp[strtoul(name.substr(0,10).c_str(),(char **)0,16)] = nlohmann::json::parse(buf);
-							} catch ( ... ) {
-								if (errors) {
-									errors->push_back(path + OFFBASE_PATH_SEP + name);
-								} else {
-									return false;
-								}
-							}
-						} else if (errors) {
-							errors->push_back(path + OFFBASE_PATH_SEP + name);
-						} else return false;
-					} else if (name[name.length()-1] == 'O') {
-						if (!_loadObj(path + OFFBASE_PATH_SEP + name,atmp[strtoul(name.substr(0,10).c_str(),(char **)0,16)] = nlohmann::json::object(),errors))
-							return false;
-					} else if (name[name.length()-1] == 'A') {
-						if (!_loadArr(path + OFFBASE_PATH_SEP + name,atmp[strtoul(name.substr(0,10).c_str(),(char **)0,16)] = nlohmann::json::array(),errors))
-							return false;
-					}
-				}
-			}
-			closedir(d);
-		} else if (errors) {
-			errors->push_back(path);
-		} else return false;
-
-		if (atmp.size() > 0) {
-			unsigned long lasti = 0;
-			for(std::map<unsigned long,nlohmann::json>::iterator i(atmp.begin());i!=atmp.end();++i) {
-				for(unsigned long k=lasti;k<i->first;++k) // fill any gaps with nulls
-					arr.push_back(nlohmann::json(std::nullptr_t));
-				lasti = i->first;
-				arr.push_back(i->second);
-			}
-		}
-
-		return true;
-	}
-
-	static inline bool _loadObj(const std::string &path,nlohmann::json &obj,std::vector<std::string> *errors)
-	{
-		struct dirent dbuf;
-		struct dirent *de;
-		DIR *d = opendir(path.c_str());
-		if (d) {
-			while (!readdir_d(d,&dbuf,&de)) {
-				if (!de) break;
-				if ((strcmp(de->d_name,".") == 0)||(strcmp(de->d_name,"..") == 0)) continue; // sanity check
-				const std::string name(de->d_name);
-				if (name.length() <= 2) continue;
-				if (name[name.length()-2] == '.') {
-					if (name[name.length()-1] == 'V') {
-						std::string buf;
-						if (_readFile((path + OFFBASE_PATH_SEP + name).c_str(),buf)) {
-							try {
-								obj[unescapeKey(name)] = nlohmann::json::parse(buf);
-							} catch ( ... ) {
-								if (errors) {
-									errors->push_back(path + OFFBASE_PATH_SEP + name);
-								} else {
-									return false;
-								}
-							}
-						} else if (errors) {
-							errors->push_back(path + OFFBASE_PATH_SEP + name);
-						} else return false;
-					} else if (name[name.length()-1] == 'O') {
-						if (!_loadObj(path + OFFBASE_PATH_SEP + name,obj[unescapeKey(name)] = nlohmann::json::object(),errors))
-							return false;
-					} else if (name[name.length()-1] == 'A') {
-						if (!_loadArr(path + OFFBASE_PATH_SEP + name,obj[unescapeKey(name)] = nlohmann::json::array(),errors))
-							return false;
-					}
-				}
-			}
-			closedir(d);
-		} else if (errors) {
-			errors->push_back(path);
-		} else return false;
-		return true;
-	}
-
-	static inline void _rmDashRf(const std::string &path)
-	{
-		struct dirent dbuf;
-		struct dirent *de;
-		DIR *d = opendir(path.c_str());
-		if (d) {
-			while (!readdir_r(d,&dbuf,&de)) {
-				if (!de) break;
-				if ((strcmp(de->d_name,".") == 0)||(strcmp(de->d_name,"..") == 0)) continue; // sanity check
-				const std::string full(path + OFFBASE_PATH_SEP + de->d_name);
-				if (unlink(full.c_str())) {
-					_rmDashRf(full);
-					rmdir(full.c_str());
-				}
-			}
-			closedir(d);
-		}
-		rmdir(path.c_str());
-	}
-
-	static inline bool _commitArr(const std::string &path,const nlohmann::json &arr,const nlohmann::json *previous,std::vector<std::string> *errors)
-	{
-		char tmp[32];
-
-		if (!arr.is_array())
-			return false;
-
-		mkdir(path.c_str(),0755);
-
-		for(unsigned long i=0;i<(unsigned long)arr.size();++i) {
-			const nlohmann::json &value = arr[i];
-
-			const nlohmann::json *next = (const nlohmann::json *)0;
-			if ((previous)&&(previous->is_array())&&(i < previous->size())) {
-				next = &((*previous)[i]);
-				if (*next == value)
-					continue;
-			}
-
-			if (value.is_object()) {
-				snprintf(tmp,sizeof(tmp),"%s%.10lx.O",OFFBASE_PATH_SEP,i);
-				if (!_commitObj(path + tmp,value,next,errors))
-					return false;
-				snprintf(tmp,sizeof(tmp),"%s%.10lx.V",OFFBASE_PATH_SEP,i);
-				unlink((path + tmp).c_str());
-				snprintf(tmp,sizeof(tmp),"%s%.10lx.A",OFFBASE_PATH_SEP,i);
-				_rmDashRf(path + tmp);
-			} else if (value.is_array()) {
-				snprintf(tmp,sizeof(tmp),"%s%.10lx.A",OFFBASE_PATH_SEP,i);
-				if (!_commitArr(path + tmp,value,next,errors))
-					return false;
-				snprintf(tmp,sizeof(tmp),"%s%.10lx.O",OFFBASE_PATH_SEP,i);
-				_rmDashRf(path + tmp);
-				snprintf(tmp,sizeof(tmp),"%s%.10lx.V",OFFBASE_PATH_SEP,i);
-				unlink((path + tmp).c_str());
-			} else {
-				snprintf(tmp,sizeof(tmp),"%s%.10lx.V",OFFBASE_PATH_SEP,i);
-				FILE *f = fopen((path + tmp).c_str(),"w");
-				if (f) {
-					const std::string v(value.dump());
-					if (fwrite(v.c_str(),v.length(),1,f) != 1) {
-						fclose(f);
-						return false;
-					} else {
-						fclose(f);
-					}
-				} else {
-					return false;
-				}
-				snprintf(tmp,sizeof(tmp),"%s%.10lx.A",OFFBASE_PATH_SEP,i);
-				_rmDashRf(path + tmp);
-				snprintf(tmp,sizeof(tmp),"%s%.10lx.O",OFFBASE_PATH_SEP,i);
-				_rmDashRf(path + tmp);
-			}
-		}
-
-		if ((previous)&&(previous->is_array())) {
-			for(unsigned long i=(unsigned long)arr.size();i<(unsigned long)previous->size();++i) {
-				snprintf(tmp,sizeof(tmp),"%s%.10lx.V",OFFBASE_PATH_SEP,i);
-				unlink((path + tmp).c_str());
-				snprintf(tmp,sizeof(tmp),"%s%.10lx.A",OFFBASE_PATH_SEP,i);
-				_rmDashRf(path + tmp);
-				snprintf(tmp,sizeof(tmp),"%s%.10lx.O",OFFBASE_PATH_SEP,i);
-				_rmDashRf(path + tmp);
-			}
-		}
-
-		return true;
-	}
-
-	static inline bool _commitObj(const std::string &path,const nlohmann::json &obj,const nlohmann::json *previous,std::vector<std::string> *errors)
-	{
-		if (!obj.is_object())
-			return false;
-
-		mkdir(path.c_str(),0755);
-
-		for(nlohmann::json::const_iterator i(obj.begin());i!=obj.end();++i) {
-			if (i.key().length() == 0)
-				continue;
-
-			const nlohmann::json *next = (const nlohmann::json *)0;
-			if ((previous)&&(previous->is_object())) {
-				nlohmann::json::const_iterator saved(previous->find(i.key()));
-				if (saved != previous->end()) {
-					next = &(saved.value());
-					if (i.value() == *next)
-						continue;
-				}
-			}
-
-			const std::string keyp(path + OFFBASE_PATH_SEP + escapeKey(i.key()));
-			if (i.value().is_object()) {
-				if (!_commitObj(keyp + ".O",i.value(),next,errors))
-					return false;
-				unlink((keyp + ".V").c_str());
-				_rmDashRf(keyp + ".A");
-			} else if (i.value().is_array()) {
-				if (!_commitArr(keyp + ".A",i.value(),next,errors))
-					return false;
-				unlink((keyp + ".V").c_str());
-				_rmDashRf(keyp + ".O");
-			} else {
-				FILE *f = fopen((keyp + ".V").c_str(),"w");
-				if (f) {
-					const std::string v(i.value().dump());
-					if (fwrite(v.c_str(),v.length(),1,f) != 1) {
-						fclose(f);
-						return false;
-					} else {
-						fclose(f);
-					}
-				} else {
-					return false;
-				}
-				_rmDashRf(keyp + ".A");
-				_rmDashRf(keyp + ".O");
-			}
-		}
-
-		if ((previous)&&(previous->is_object())) {
-			for(nlohmann::json::const_iterator i(previous->begin());i!=previous->end();++i) {
-				if ((i.key().length() > 0)&&(obj.find(i.key()) == obj.end())) {
-					const std::string keyp(path + OFFBASE_PATH_SEP + escapeKey(i.key()));
- 					unlink((keyp + ".V").c_str());
-					_rmDashRf(keyp + ".A");
-					_rmDashRf(keyp + ".O");
-				}
-			}
-		}
-
-		return true;
-	}
-
-	std::string _path;
-	nlohmann::json _saved;
-};
-
-#endif

make-mac.mk

@@ -65,7 +65,7 @@ else
 	STRIP=strip
 endif
 
-CXXFLAGS=$(CFLAGS) -fno-rtti
+CXXFLAGS=$(CFLAGS) -fno-rtti -mmacosx-version-min=10.7 -std=c++11 -stdlib=libc++ 
 
 all: one
 
@@ -78,7 +78,7 @@ one:	$(OBJS) service/OneService.o one.o
 	$(CODESIGN) -vvv zerotier-one
 
 cli:	FORCE
-	$(CXX) -Os -mmacosx-version-min=10.7 -std=c++11 -stdlib=libc++ -o zerotier cli/zerotier.cpp osdep/OSUtils.cpp node/InetAddress.cpp node/Utils.cpp node/Salsa20.cpp node/Identity.cpp node/SHA512.cpp node/C25519.cpp -lcurl
+	$(CXX) $(CXXFLAGS) -o zerotier cli/zerotier.cpp osdep/OSUtils.cpp node/InetAddress.cpp node/Utils.cpp node/Salsa20.cpp node/Identity.cpp node/SHA512.cpp node/C25519.cpp -lcurl
 	$(STRIP) zerotier
 
 selftest: $(OBJS) selftest.o

node/InetAddress.cpp

@@ -113,7 +113,7 @@ void InetAddress::set(const std::string &ip,unsigned int port)
 		sin6->sin6_port = Utils::hton((uint16_t)port);
 		if (inet_pton(AF_INET6,ip.c_str(),(void *)&(sin6->sin6_addr.s6_addr)) <= 0)
 			memset(this,0,sizeof(InetAddress));
-	} else {
+	} else if (ip.find('.') != std::string::npos) {
 		struct sockaddr_in *sin = reinterpret_cast<struct sockaddr_in *>(this);
 		ss_family = AF_INET;
 		sin->sin_port = Utils::hton((uint16_t)port);

osdep/OSUtils.cpp

@@ -107,6 +107,86 @@ std::vector<std::string> OSUtils::listDirectory(const char *path)
 	return r;
 }
 
+std::vector<std::string> OSUtils::listSubdirectories(const char *path)
+{
+	std::vector<std::string> r;
+
+#ifdef __WINDOWS__
+	HANDLE hFind;
+	WIN32_FIND_DATAA ffd;
+	if ((hFind = FindFirstFileA((std::string(path) + "\\*").c_str(),&ffd)) != INVALID_HANDLE_VALUE) {
+		do {
+			if ((strcmp(ffd.cFileName,"."))&&(strcmp(ffd.cFileName,".."))&&((ffd.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) != 0))
+				r.push_back(std::string(ffd.cFileName));
+		} while (FindNextFileA(hFind,&ffd));
+		FindClose(hFind);
+	}
+#else
+	struct dirent de;
+	struct dirent *dptr;
+	DIR *d = opendir(path);
+	if (!d)
+		return r;
+	dptr = (struct dirent *)0;
+	for(;;) {
+		if (readdir_r(d,&de,&dptr))
+			break;
+		if (dptr) {
+			if ((strcmp(dptr->d_name,"."))&&(strcmp(dptr->d_name,".."))&&(dptr->d_type == DT_DIR))
+				r.push_back(std::string(dptr->d_name));
+		} else break;
+	}
+	closedir(d);
+#endif
+
+	return r;
+}
+
+bool OSUtils::rmDashRf(const char *path)
+{
+#ifdef __WINDOWS__
+	HANDLE hFind;
+	WIN32_FIND_DATAA ffd;
+	if ((hFind = FindFirstFileA((std::string(path) + "\\*").c_str(),&ffd)) != INVALID_HANDLE_VALUE) {
+		do {
+			if ((strcmp(ffd.cFileName,".") != 0)&&(strcmp(ffd.cFileName,"..") != 0)) {
+				if ((ffd.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) == 0) {
+					if (DeleteFileA((std::string(path) + ZT_PATH_SEPARATOR_S + ffd.cFileName).c_str()) == FALSE)
+						return false;
+				} else {
+					if (!rmDashRf((std::string(path) + ZT_PATH_SEPARATOR_S + ffd.cFileName).c_str()))
+						return false;
+				}
+			}
+		} while (FindNextFileA(hFind,&ffd));
+		FindClose(hFind);
+	}
+	return (RemoveDirectoryA(path) != FALSE);
+#else
+	struct dirent de;
+	struct dirent *dptr;
+	DIR *d = opendir(path);
+	if (!d)
+		return true;
+	dptr = (struct dirent *)0;
+	for(;;) {
+		if (readdir_r(d,&de,&dptr))
+			break;
+		if ((dptr)&&(strcmp(dptr->d_name,".") != 0)&&(strcmp(dptr->d_name,"..") != 0)) {
+			std::string p(path);
+			p.push_back(ZT_PATH_SEPARATOR);
+			p.append(dptr->d_name);
+			if (unlink(p.c_str()) != 0) {
+				if (!rmDashRf(p.c_str()))
+					return false;
+			}
+		} else break;
+	}
+	closedir(d);
+	return (rmdir(path) == 0);
+#endif
+}
+
 void OSUtils::lockDownFile(const char *path,bool isDir)
 {
 #ifdef __UNIX_LIKE__

osdep/OSUtils.hpp

@@ -105,10 +105,26 @@ public:
 	 * This returns only files, not sub-directories.
 	 *
 	 * @param path Path to list
-	 * @return Names of files in directory
+	 * @return Names of files in directory (without path prepended)
 	 */
 	static std::vector<std::string> listDirectory(const char *path);
 
+	/**
+	 * List a directory's subdirectories
+	 *
+	 * @param path Path to list
+	 * @return Names of subdirectories (without path prepended)
+	 */
+	static std::vector<std::string> listSubdirectories(const char *path);
+
+	/**
+	 * Delete a directory and all its files and subdirectories recursively
+	 *
+	 * @param path Path to delete
+	 * @return True on success
+	 */
+	static bool rmDashRf(const char *path);
+
 	/**
 	 * Set modes on a file to something secure
 	 *