ExternalVendorCode/ZeroTierOne
1
0
Fork 0
mirror of https://github.com/zerotier/ZeroTierOne.git synced 2024-12-24 15:16:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #1799 from zerotier/cleanup/suggest-braces

Browse Source 
Fix warning: suggest braces around initialization of subobject
This commit is contained in:
Adam Ierymenko 2022-12-01 11:03:26 -05:00 committed by GitHub
commit a25da7f771
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
java/jni/com_zerotierone_sdk_Node.cpp
View File

@ -573,7 +573,26 @@ namespace {
return true; return true;
} }
struct sockaddr_storage nullAddress = {0}; //
// was:
// struct sockaddr_storage nullAddress = {0};
//
// but was getting this warning:
// warning: suggest braces around initialization of subobject
//
// when building ZeroTierOne
//
struct sockaddr_storage nullAddress;
//
// It is possible to assume knowledge about internals of sockaddr_storage and construct
// correct 0-initializer, but it is simpler to just treat sockaddr_storage as opaque and
// use memset here to fill with 0
//
// This is also done in InetAddress.hpp for InetAddress
//
memset(&nullAddress, 0, sizeof(sockaddr_storage));
jobject remoteAddressObj = NULL; jobject remoteAddressObj = NULL;
if(memcmp(remoteAddress, &nullAddress, sizeof(sockaddr_storage)) != 0) if(memcmp(remoteAddress, &nullAddress, sizeof(sockaddr_storage)) != 0)