A few fixes dicatated by valgrind.

This commit is contained in:
Adam Ierymenko 2018-02-09 06:35:01 +00:00
parent f049740ae5
commit 51aadcf901
2 changed files with 21 additions and 33 deletions

View File

@ -62,40 +62,24 @@ template<unsigned int C>
class Dictionary class Dictionary
{ {
public: public:
Dictionary() Dictionary() { memset(_d,0,sizeof(_d)); }
{ Dictionary(const char *s) { this->load(s); }
_d[0] = (char)0;
}
Dictionary(const char *s)
{
if (s) {
Utils::scopy(_d,sizeof(_d),s);
} else {
_d[0] = (char)0;
}
}
Dictionary(const char *s,unsigned int len) Dictionary(const char *s,unsigned int len)
{ {
if (s) { for(unsigned int i=0;i<C;++i) {
if (len > (C-1)) if ((s)&&(i < len)) {
len = C-1; if (!(_d[i] = *s))
ZT_FAST_MEMCPY(_d,s,len); s = (const char *)0;
_d[len] = (char)0; else ++s;
} else { } else _d[i] = (char)0;
_d[0] = (char)0;
} }
_d[C - 1] = (char)0;
} }
Dictionary(const Dictionary &d) { memcpy(_d,d._d,C); }
Dictionary(const Dictionary &d)
{
Utils::scopy(_d,sizeof(_d),d._d);
}
inline Dictionary &operator=(const Dictionary &d) inline Dictionary &operator=(const Dictionary &d)
{ {
Utils::scopy(_d,sizeof(_d),d._d); memcpy(_d,d._d,C);
return *this; return *this;
} }
@ -109,12 +93,15 @@ public:
*/ */
inline bool load(const char *s) inline bool load(const char *s)
{ {
if (s) { for(unsigned int i=0;i<C;++i) {
return Utils::scopy(_d,sizeof(_d),s); if (s) {
} else { if (!(_d[i] = *s))
_d[0] = (char)0; s = (const char *)0;
return true; else ++s;
} else _d[i] = (char)0;
} }
_d[C - 1] = (char)0;
return (!s);
} }
/** /**
@ -122,7 +109,7 @@ public:
*/ */
inline void clear() inline void clear()
{ {
_d[0] = (char)0; memset(_d,0,sizeof(_d));
} }
/** /**

View File

@ -50,6 +50,7 @@ namespace ZeroTier {
Switch::Switch(const RuntimeEnvironment *renv) : Switch::Switch(const RuntimeEnvironment *renv) :
RR(renv), RR(renv),
_lastBeaconResponse(0), _lastBeaconResponse(0),
_lastCheckedQueues(0),
_lastUniteAttempt(8) // only really used on root servers and upstreams, and it'll grow there just fine _lastUniteAttempt(8) // only really used on root servers and upstreams, and it'll grow there just fine
{ {
} }