From fbca9f82fd7962bc6c330544cedb0d5c7c288be3 Mon Sep 17 00:00:00 2001 From: Ettore Di Giacinto Date: Mon, 7 Oct 2024 11:22:55 +0200 Subject: [PATCH] fix(vllm): bump cmake - vllm requires it (#3744) * fix(vllm): bump cmake - vllm requires it Signed-off-by: Ettore Di Giacinto * chore(tests): try to increase coqui timeout Signed-off-by: Ettore Di Giacinto --------- Signed-off-by: Ettore Di Giacinto --- Dockerfile | 14 ++++++++++---- backend/python/coqui/test.py | 2 +- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/Dockerfile b/Dockerfile index 8c657469..532e3d55 100644 --- a/Dockerfile +++ b/Dockerfile @@ -9,6 +9,7 @@ FROM ${BASE_IMAGE} AS requirements-core USER root ARG GO_VERSION=1.22.6 +ARG CMAKE_VERSION=3.26.4 ARG TARGETARCH ARG TARGETVARIANT @@ -21,8 +22,7 @@ RUN apt-get update && \ build-essential \ ccache \ ca-certificates \ - cmake \ - curl \ + curl libssl-dev \ git \ unzip upx-ucl && \ apt-get clean && \ @@ -32,6 +32,9 @@ RUN apt-get update && \ RUN curl -L -s https://go.dev/dl/go${GO_VERSION}.linux-${TARGETARCH}.tar.gz | tar -C /usr/local -xz ENV PATH=$PATH:/root/go/bin:/usr/local/go/bin +# Install CMake (the version in 22.04 is too old) +RUN curl -L -s https://github.com/Kitware/CMake/releases/download/v${CMAKE_VERSION}/cmake-${CMAKE_VERSION}.tar.gz -o cmake.tar.gz && tar xvf cmake.tar.gz && cd cmake-${CMAKE_VERSION} && ./configure && make && make install + # Install grpc compilers RUN go install google.golang.org/protobuf/cmd/protoc-gen-go@v1.34.2 && \ go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@1958fcbe2ca8bd93af633f11e97d44e567e945af @@ -188,6 +191,7 @@ FROM ${GRPC_BASE_IMAGE} AS grpc # This is a bit of a hack, but it's required in order to be able to effectively cache this layer in CI ARG GRPC_MAKEFLAGS="-j4 -Otarget" ARG GRPC_VERSION=v1.65.0 +ARG CMAKE_VERSION=3.26.4 ENV MAKEFLAGS=${GRPC_MAKEFLAGS} @@ -196,12 +200,14 @@ WORKDIR /build RUN apt-get update && \ apt-get install -y --no-install-recommends \ ca-certificates \ - build-essential \ - cmake \ + build-essential curl libssl-dev \ git && \ apt-get clean && \ rm -rf /var/lib/apt/lists/* +# Install CMake (the version in 22.04 is too old) +RUN curl -L -s https://github.com/Kitware/CMake/releases/download/v${CMAKE_VERSION}/cmake-${CMAKE_VERSION}.tar.gz -o cmake.tar.gz && tar xvf cmake.tar.gz && cd cmake-${CMAKE_VERSION} && ./configure && make && make install + # We install GRPC to a different prefix here so that we can copy in only the build artifacts later # saves several hundred MB on the final docker image size vs copying in the entire GRPC source tree # and running make install in the target container diff --git a/backend/python/coqui/test.py b/backend/python/coqui/test.py index d1418fa3..e0b1a0bd 100644 --- a/backend/python/coqui/test.py +++ b/backend/python/coqui/test.py @@ -19,7 +19,7 @@ class TestBackendServicer(unittest.TestCase): This method sets up the gRPC service by starting the server """ self.service = subprocess.Popen(["python3", "backend.py", "--addr", "localhost:50051"]) - time.sleep(10) + time.sleep(30) def tearDown(self) -> None: """