Commit Graph

481 Commits

Author SHA1 Message Date
Cyrus
8639e8b708
Merge pull request #332 from nsacyber/cpp-error-cleanup
CppCheck cleanup
2021-01-28 10:12:13 -05:00
Cyrus
8d6a697a23 Removed some unnecessary comments 2021-01-28 08:08:12 -05:00
Cyrus
a04b697c9a Added an additional suppression to the cppcheck call. 2021-01-26 15:10:47 -05:00
Cyrus
f80d9af3b7 Some issues were found while doing script testings. These issues don't appear on Travis, however some of the issues were resolved in the scripts by making these changes. This is to test how travis will react. 2021-01-22 10:08:50 -05:00
Cyrus
653bfddc6d Updated some code and took out things that didin't need to be in the official build for unit tests 2021-01-21 07:40:55 -05:00
Cyrus
5589096443 Cleaned up some stuff I found during code compare in github. 2021-01-20 13:23:51 -05:00
Cyrus
acc022d784 Finalized clean up. 2021-01-20 13:05:43 -05:00
Cyrus
e9eef0e5b3 Updated the code to go through the serial numbers that are valid numbers verus generic filler. Tested against the provisioner. 2021-01-20 08:00:24 -05:00
Cyrus
4d8315f443
Merge pull request #331 from nsacyber/issue-308-unitTests
[#308] Updated unit tests
2021-01-15 08:22:52 -05:00
chubtub
88015df551 Checkstyle: unused import 2021-01-14 13:19:17 -05:00
Cyrus
859fdbef83 Added a null check for the platformCredentials in the issued certificate attribute helper so that NPEs aren't thrown. 2021-01-14 12:48:53 -05:00
Cyrus
164a43f056 These are unit tests that were not run on the merge request #327 for issue 308. The unit tests uses certificate (EC and 2 CAs) that don't match for SKI to AKI or issuer string fields. The O= field isn't required and the code in #327 was changed to use SKI first then a sorted RDN list. See #327. A note was left in the unit tests that the test certs need to be updated.` 2021-01-14 12:41:29 -05:00
Cyrus
fa12614221 Testing out new code 2021-01-14 10:34:27 -05:00
Cyrus
beb1ccbee3 Updated a supply chain validation check for delta certificates. Updated the check for duplicate base platform certificates when storing them for the same device and updated the begin validity date for the delta vs the base check. 2021-01-12 12:26:54 -05:00
Cyrus
49f8fd3ed4
Merge pull request #330 from nsacyber/firmware-summary
[#329] Firmware Tests summary
2021-01-11 13:41:52 -05:00
Cyrus
fcb496686c This includes some refactoring of the component identifier. 2021-01-11 13:24:49 -05:00
Cyrus
fa6b64d38a Removed unused statement 2021-01-08 07:20:18 -05:00
Cyrus
e0ae088401 Remove error statement 2021-01-08 07:07:16 -05:00
Cyrus
43c9f04d60 Updated some of the checks for the search text for the summary. 2021-01-07 16:00:56 -05:00
Cyrus
f361a49a74 Resovled the issue of the DBX variable not showing up under the correct category when present. The search for the DB variable also checks the DBX so it never actually hit the DBX if statement.` 2021-01-07 13:40:40 -05:00
Cyrus
058c58d208 Updated the begin validity date check for the base and delta so that it is only an error if the delta begin date is older than the platform. Equal is allowed. 2021-01-07 12:51:01 -05:00
Cyrus
ab8d30ee82 Corrected the missing boot order entry on the page and updated how the boot variables are searched for. However, DBX is still not showing up. 2021-01-07 09:48:04 -05:00
Cyrus
08c0daf9be Initial Commit 2021-01-06 15:45:50 -05:00
Cyrus
c181665ad9
Merge pull request #326 from nsacyber/issue-324
[#324]  Update filenames when downloading (RIM)
2021-01-05 11:12:25 -05:00
Cyrus
20f94b94ec
Merge pull request #327 from nsacyber/issue-308
[#308] Certificate RDN update
2021-01-05 10:07:04 -05:00
Cyrus
85254d9c44 Removed null assignment that isn't used 2021-01-05 08:14:18 -05:00
Cyrus
90a6e75f59 Removed unused import 2021-01-04 08:56:41 -05:00
Cyrus
7028810707 This latest push should have the code that'll highlight the components based on a string rather than the serial number. This also adds additional checks for the validity begin date of the delta not matching or being before the base. It also checks that they don't have the same certificate serial number. 2020-12-30 08:41:47 -05:00
Cyrus
6dd948c828 Added a null check for the endorsement credential for the tpm 1.2 2020-12-18 06:58:18 -05:00
Cyrus
a7eae2fd77 Test out an potential exception 2020-12-17 13:09:03 -05:00
Cyrus
f38fa87013 Undid some code I took out 2020-12-17 09:31:39 -05:00
Cyrus
1db52cebf9 This is a stopping point because the code can't be fully worked out because the data (certificates) aren't correct. 2020-12-17 07:24:51 -05:00
Cyrus
640966ae8c Removed debug statement 2020-12-14 11:40:04 -05:00
Cyrus
8fa5dfdd9e Removed unused imports 2020-12-14 10:57:35 -05:00
Cyrus
62c7ca2d90 This PR is to address issue #308. The ACA was pulling Issuer Certificates using the organization RDN of the subject string and getting this from the issuer string of the EC or PC. This presents a problem because it isn't a required field. The organization field cannot be null or empty. Pulling objects from a DB using null or empty would produce bad results. The main change of this issue (which has not been full tested) is pulling using the AKI for the db lookup. If this fails, instead of falling back on potentially left out fields like the O= RDN, the ACA takes the issuer/subject fields, breaks them apart and sorts them based on the key. It also changes the case. This way the lookup can be assured to match in case of some random situation in which the issuer or subject field don't match because RDN keys are just in different positions of the string. 2020-12-11 14:47:46 -05:00
Cyrus
209024c12a Cleaned up some comments and code. 2020-12-07 09:47:54 -05:00
Cyrus
a3de35ed27 The issue with the tpm 1.2 system test failing had to do with the string to integer conversion using getInteger instead of parseInt. 2020-12-07 07:44:48 -05:00
Cyrus
ec47aceedc Merge branch 'master' into aic-policy-rule 2020-12-07 07:40:09 -05:00
Cyrus
11f238f671 Testing system tests 2020-12-04 08:36:42 -05:00
iadgovuser26
408060b1e0
Update README.md
Updated for Release 2.0
2020-12-03 15:40:46 -05:00
Cyrus
e64c6cf772 Merge branch 'master' into aic-policy-rule 2020-12-03 13:34:29 -05:00
Cyrus
e32e9412d8 Merge branch 'master' into Unmatched-component-refactor 2020-12-03 13:20:12 -05:00
Cyrus
0ce8d41f23
Merge pull request #323 from nsacyber/multiple-rim-upload
Multiple RIM upload
2020-12-03 07:57:15 -05:00
Cyrus
b56fb73801 Updated the file to just use the fileName from the ReferenceManifest for the downloaded name. 2020-12-02 19:40:50 -05:00
Cyrus
a07fbbd847 In a previous pull request, the reference manifest manager was not called to update the unarchived base rim. So it appears to never have been uploaded. 2020-12-02 11:46:42 -05:00
Cyrus
7d49f63a9b Merge branch 'master' into multiple-rim-upload 2020-12-02 11:05:12 -05:00
Cyrus
a3f5386b21
Merge pull request #322 from nsacyber/platform_cert_missing_fix
Platform Certificate Upload Modification
2020-12-02 11:01:27 -05:00
Cyrus
70662bddec Updated how the bios measurement file is uploaded. Changed the code to pull the string from the properties file instead of a hard link in the code. 2020-12-01 11:13:41 -05:00
Cyrus
9534d6650f Merge branch 'master' into platform_cert_missing_fix 2020-12-01 09:47:45 -05:00
Cyrus
a32d3a5f02 Remove comments 2020-12-01 09:46:05 -05:00