issue_847: Applied formatting changes to entire CA module. Reduced errors by 100.

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/OrderedListQuerier.java

@@ -5,6 +5,7 @@ import java.util.Map;
 /**
  * Interface defining methods for getting ordered lists from a data source. Includes
  * properties for sorting, paging, and searching.
+ *
  * @param <T> the record type, T.
  */
 public interface OrderedListQuerier<T> {

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/ArchivableEntity.java

@@ -55,8 +55,7 @@ public abstract class ArchivableEntity extends AbstractEntity {
      * Signals that this entity has been archived, by setting the archivedTime to the current date
      * and time.
      *
-     * @return
+     * @return true if time was null and date was set.
-     *      true if time was null and date was set.
      * false is archived time is already set, signifying the entity has been archived.
      */
     public final boolean archive() {
@@ -73,8 +72,7 @@ public abstract class ArchivableEntity extends AbstractEntity {
      * purposes so the reason for action taken can be referenced.
      *
      * @param description - description of the action taken for resolution
-     * @return
+     * @return boolean result is dependent on the return value of the archive() method
-     *      boolean result is dependent on the return value of the archive() method
      */
     public final boolean archive(final String description) {
         if (archive()) {
@@ -104,8 +102,7 @@ public abstract class ArchivableEntity extends AbstractEntity {
      * Sets the archivedTime to null.  The archivedTime being null signifies that the entity has
      * not been archived.  If the time is already null then this call was unnecessary.
      *
-     * @return
+     * @return true if the time is changed to null.
-     *      true if the time is changed to null.
      * false if time was already set to null.
      */
     public final boolean restore() {

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/Policy.java

@@ -29,8 +29,7 @@ public abstract class  Policy extends UserDefinedEntity {
     /**
      * Creates a new <code>Policy</code> with the specified name.
      *
-     * @param name
+     * @param name name
-     *            name
      */
     public Policy(final String name) {
         super(name);
@@ -40,10 +39,8 @@ public abstract class  Policy extends UserDefinedEntity {
      * Creates a new <code>Policy</code> with the specified name and
      * description.
      *
-     * @param name
+     * @param name        name (required)
-     *          name (required)
+     * @param description description (may be null)
-     * @param description
-     *          description (may be null)
      */
     public Policy(final String name, final String description) {
         super(name, description);

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/UserDefinedEntity.java

@@ -4,9 +4,9 @@ import jakarta.persistence.Column;
 import jakarta.persistence.MappedSuperclass;
 import lombok.AllArgsConstructor;
 import lombok.Getter;
+import lombok.NonNull;
 import lombok.Setter;
 import lombok.ToString;
-import lombok.NonNull;
 
 /**
  * An abstract archivable entity that can be given a user-defined name and description.
@@ -18,11 +18,13 @@ import lombok.NonNull;
 public abstract class UserDefinedEntity extends ArchivableEntity {
 
     @Column(nullable = false, unique = true)
-    @NonNull private String name;
+    @NonNull
+    private String name;
 
     @ToString.Exclude
     @Column(nullable = false, unique = false)
-    @NonNull private String description = "";
+    @NonNull
+    private String description = "";
 
     /**
      * Default empty constructor is required for Hibernate. It is protected to
@@ -47,8 +49,7 @@ public abstract class UserDefinedEntity extends ArchivableEntity {
      * an instance of <code>UserDefinedEntity</code> and its name is the same as this
      * <code>UserDefinedEntity</code>. Otherwise this returns false.
      *
-     * @param other
+     * @param other other object to test for equals
-     *            other object to test for equals
      * @return true if other is <code>Baseline</code> and has same name
      */
     @Override
@@ -56,11 +57,10 @@ public abstract class UserDefinedEntity extends ArchivableEntity {
         if (this == other) {
             return true;
         }
-        if (!(other instanceof UserDefinedEntity)) {
+        if (!(other instanceof UserDefinedEntity entity)) {
             return false;
         }
 
-        final UserDefinedEntity entity = (UserDefinedEntity) other;
         return this.getName().equals(entity.getName());
     }
 

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/manager/IDevIDCertificateRepository.java

@@ -56,7 +56,8 @@ public interface IDevIDCertificateRepository extends JpaRepository<IDevIDCertifi
 //    List<IDevIDCertificate> findBySubjectAndArchiveFlag(String subject, boolean archiveFlag);
 //
 //    /**
-//     * Query that retrieves a sorted list of IDevId certificates using the provided subject and archive flag.
+//     * Query that retrieves a sorted list of IDevId certificates using the provided subject
+//     * and archive flag.
 //     *
 //     * @param subject     string representation of the subject
 //     * @param archiveFlag archive flag
@@ -79,5 +80,6 @@ public interface IDevIDCertificateRepository extends JpaRepository<IDevIDCertifi
 //     * @param archiveFlag        archive flag
 //     * @return an IDevId certificate
 //     */
-//    IDevIDCertificate findBySubjectKeyIdStringAndArchiveFlag(String subjectKeyIdString, boolean archiveFlag);
+//      IDevIDCertificate findBySubjectKeyIdStringAndArchiveFlag(String subjectKeyIdString,
+//      boolean archiveFlag);
 }

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/tpm/TPM2ProvisionerState.java

@@ -35,7 +35,7 @@ public class TPM2ProvisionerState {
     private byte[] identityClaim;
 
     @Column(nullable = false)
-    private Date timestamp = new Date();
+    private final Date timestamp = new Date();
 
     /**
      * Constructor.
@@ -69,24 +69,6 @@ public class TPM2ProvisionerState {
         }
     }
 
-    /**
-     * Get the nonce.
-     *
-     * @return the nonce
-     */
-    public byte[] getNonce() {
-        return Arrays.clone(nonce);
-    }
-
-    /**
-     * Get the identity claim.
-     *
-     * @return the identity claim
-     */
-    public byte[] getIdentityClaim() {
-        return Arrays.clone(identityClaim);
-    }
-
     /**
      * Convenience method for finding the {@link TPM2ProvisionerState} associated with the nonce.
      *
@@ -114,4 +96,22 @@ public class TPM2ProvisionerState {
         }
         return null;
     }
+
+    /**
+     * Get the nonce.
+     *
+     * @return the nonce
+     */
+    public byte[] getNonce() {
+        return Arrays.clone(nonce);
+    }
+
+    /**
+     * Get the identity claim.
+     *
+     * @return the identity claim
+     */
+    public byte[] getIdentityClaim() {
+        return Arrays.clone(identityClaim);
+    }
 }

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/ExaminableRecord.java

@@ -23,6 +23,29 @@ import lombok.extern.log4j.Log4j2;
 @XmlAccessorType(XmlAccessType.FIELD)
 public abstract class ExaminableRecord {
 
+    @Getter
+    @Column(nullable = false)
+    // Decided on ORDINAL instead of STRING due to concerns surrounding overall size and retrieval
+    // time of field from database. Consistent with other implementations of ExaminableRecord.
+    @Enumerated(EnumType.ORDINAL)
+    private ExamineState examineState = ExamineState.UNEXAMINED;
+
+    /**
+     * Sets the examine state for this record.
+     *
+     * @param examineState the examine state
+     */
+    public void setExamineState(final ExamineState examineState) {
+        if (examineState == ExamineState.UNEXAMINED) {
+            log.error("Can't set ExamineState on ExaminableRecord to Unexamined");
+            throw new IllegalArgumentException(
+                    "Can't set ExamineState on ExaminableRecord to Unexamined"
+            );
+        }
+
+        this.examineState = examineState;
+    }
+
     /**
      * State capturing if a record was examined during appraisal or not.
      */
@@ -42,26 +65,4 @@ public abstract class ExaminableRecord {
          */
         IGNORED
     }
-
-    @Getter
-    @Column(nullable = false)
-    // Decided on ORDINAL instead of STRING due to concerns surrounding overall size and retrieval
-    // time of field from database. Consistent with other implementations of ExaminableRecord.
-    @Enumerated(EnumType.ORDINAL)
-    private ExamineState examineState = ExamineState.UNEXAMINED;
-
-    /**
-     * Sets the examine state for this record.
-     * @param examineState the examine state
-     */
-    public void setExamineState(final ExamineState examineState) {
-        if (examineState == ExamineState.UNEXAMINED) {
-            log.error("Can't set ExamineState on ExaminableRecord to Unexamined");
-            throw new IllegalArgumentException(
-                    "Can't set ExamineState on ExaminableRecord to Unexamined"
-            );
-        }
-
-        this.examineState = examineState;
-    }
 }

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/PolicySettings.java

@@ -105,8 +105,7 @@ public class PolicySettings extends UserDefinedEntity {
     /**
      * Constructor used to initialize PolicySettings object.
      *
-     * @param name
+     * @param name A name used to uniquely identify and reference the Supply Chain policy.
-     *        A name used to uniquely identify and reference the Supply Chain policy.
      */
     public PolicySettings(final String name) {
         super(name);
@@ -115,10 +114,8 @@ public class PolicySettings extends UserDefinedEntity {
     /**
      * Constructor used to initialize PolicySettings object.
      *
-     * @param name
+     * @param name        A name used to uniquely identify and reference the supply chain policy.
-     *        A name used to uniquely identify and reference the supply chain policy.
+     * @param description Optional description of the policy that can be added by the user
-     * @param description
-     *        Optional description of the policy that can be added by the user
      */
     public PolicySettings(final String name, final String description) {
         super(name, description);

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/certificate/ConformanceCredential.java

@@ -15,9 +15,10 @@ import java.nio.file.Path;
 @NoArgsConstructor(access = AccessLevel.PROTECTED)
 @Entity
 public class ConformanceCredential extends Certificate {
-    /**
+
-     * This class enables the retrieval of ConformanceCredentials by their attributes.
+//    /**
-     */
+//     * This class enables the retrieval of ConformanceCredentials by their attributes.
+//     */
 //    public static class Selector extends CertificateSelector<ConformanceCredential> {
 //        /**
 //         * Construct a new CertificateSelector that will use the given {@link CertificateManager} to
@@ -30,12 +31,12 @@ public class ConformanceCredential extends Certificate {
 //        }
 //    }
 
-    /**
+//    /**
-     * Get a Selector for use in retrieving ConformanceCredentials.
+//     * Get a Selector for use in retrieving ConformanceCredentials.
-     *
+//     *
-     * @param certMan the CertificateManager to be used to retrieve persisted certificates
+//     * @param certMan the CertificateManager to be used to retrieve persisted certificates
-     * @return a ConformanceCredential.Selector instance to use for retrieving certificates
+//     * @return a ConformanceCredential.Selector instance to use for retrieving certificates
-     */
+//     */
 //    public static Selector select(final CertificateManager certMan) {
 //        return new Selector(certMan);
 //    }

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/certificate/DeviceAssociatedCertificate.java

@@ -18,26 +18,25 @@ import java.util.UUID;
  *
  * @see Certificate
  */
+@Setter
+@Getter
 @NoArgsConstructor(access = AccessLevel.PACKAGE)
 @MappedSuperclass
 public abstract class DeviceAssociatedCertificate extends Certificate {
 
-    // a device can have multiple certs of this type.
-    @Getter
-    @Setter
-    @JdbcTypeCode(java.sql.Types.VARCHAR)
-    @Column
-    private UUID deviceId;
-    @Getter
-    @Setter
-    @Column
-    private String deviceName;
-
     /**
      * Holds the name of the entity 'DEVICE_ID' field.
      */
     protected static final String DEVICE_ID_FIELD = "device_id";
 
+    // a device can have multiple certs of this type.
+    @JdbcTypeCode(java.sql.Types.VARCHAR)
+    @Column
+    private UUID deviceId;
+
+    @Column
+    private String deviceName;
+
     /**
      * Construct a new Certificate by parsing the file at the given path.  The given certificate
      * should represent either an X509 certificate or X509 attribute certificate.

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/certificate/attributes/CommonCriteriaMeasures.java

@@ -25,7 +25,8 @@ import org.bouncycastle.asn1.ASN1TaggedObject;
  *      targetUri [4] IMPLICIT URIReference OPTIONAL }
  * </pre>
  */
-@Getter @Setter
+@Getter
+@Setter
 public class CommonCriteriaMeasures {
 
     private static final int STRENGTH_OF_FUNCTION = 0;
@@ -33,140 +34,6 @@ public class CommonCriteriaMeasures {
     private static final int PROFILE_URI = 2;
     private static final int TARGET_OID = 3;
     private static final int TARGET_URI = 4;
-
-    /**
-     * A type to handle the evaluation status used in the Common Criteria Measurement.
-     * Ordering of enum types is intentional and their ordinal values correspond to enum
-     * values in the TCG spec.
-     *
-     * <pre>
-     * EvaluationStatus ::= ENUMERATED {
-     *      designedToMeet (0),
-     *      evaluationInProgress (1),
-     *      evaluationCompleted (2) }
-     * </pre>
-     */
-    public enum EvaluationStatus {
-        /**
-         * Evaluation designed to meet.
-         */
-        DESIGNEDTOMEET("designed To Meet"),
-        /**
-         * Evaluation in progress.
-         */
-        EVALUATIONINPROGRESS("evaluation In Progress"),
-        /**
-         * Evaluation completed.
-         */
-        EVALUATIONCOMPLETED("evaluation Completed");
-
-        @Getter
-        private final String value;
-
-        /**
-         * Basic constructor.
-         * @param value string containing the value.
-         */
-        EvaluationStatus(final String value) {
-            this.value = value;
-        }
-    }
-
-    /**
-     * A type to handle the strength of function used in the Common Criteria Measurement.
-     * Ordering of enum types is intentional and their ordinal values correspond to enum
-     * values in the TCG spec.
-     *
-     * <pre>
-     * StrengthOfFunction ::= ENUMERATED {
-     *      basic (0),
-     *      medium (1),
-     *      high (2) }
-     * </pre>
-     */
-    public enum StrengthOfFunction {
-        /**
-         * Basic function.
-         */
-        BASIC("basic"),
-        /**
-         * Medium function.
-         */
-        MEDIUM("medium"),
-        /**
-         * Hight function.
-         */
-        HIGH("high");
-
-        @Getter
-        private final String value;
-
-        /**
-         * Basic constructor.
-         * @param value string containing the value.
-         */
-        StrengthOfFunction(final String value) {
-            this.value = value;
-        }
-    }
-
-    /**
-     * A type to handle the evaluation assurance aevel used in the Common Criteria Measurement.
-     * Ordering of enum types is intentional and their ordinal values correspond to enum
-     * values in the TCG spec.
-     *
-     * <pre>
-     * EvaluationAssuranceLevel ::= ENUMERATED {
-     *      levell (1),
-     *      level2 (2),
-     *      level3 (3),
-     *      level4 (4),
-     *      level5 (5),
-     *      level6 (6),
-     *      level7 (7) }
-     * </pre>
-     */
-    public enum EvaluationAssuranceLevel {
-        /**
-         * Evaluation Assurance Level 1.
-         */
-        LEVEL1("level 1"),
-        /**
-         * Evaluation Assurance Level 2.
-         */
-        LEVEL2("level 2"),
-        /**
-         * Evaluation Assurance Level 3.
-         */
-        LEVEL3("level 3"),
-        /**
-         * Evaluation Assurance Level 4.
-         */
-        LEVEL4("level 4"),
-        /**
-         * Evaluation Assurance Level 5.
-         */
-        LEVEL5("level 5"),
-        /**
-         * Evaluation Assurance Level 6.
-         */
-        LEVEL6("level 6"),
-        /**
-         * Evaluation Assurance Level 7.
-         */
-        LEVEL7("level 7");
-
-        @Getter
-        private final String value;
-        /**
-         * Basic constructor.
-         * @param value string containing the value.
-         */
-        EvaluationAssuranceLevel(final String value) {
-            this.value = value;
-        }
-    }
-
     private ASN1IA5String version;
     private EvaluationAssuranceLevel assuranceLevel;
     private EvaluationStatus evaluationStatus;
@@ -194,6 +61,7 @@ public class CommonCriteriaMeasures {
 
     /**
      * Constructor given the SEQUENCE that contains Common Criteria Measures.
+     *
      * @param sequence containing the the common criteria measures
      * @throws IllegalArgumentException if there was an error on the parsing
      */
@@ -258,7 +126,6 @@ public class CommonCriteriaMeasures {
         }
     }
 
-
     @Override
     public String toString() {
         StringBuilder sb = new StringBuilder();
@@ -278,7 +145,7 @@ public class CommonCriteriaMeasures {
         }
         sb.append(", profileUri=");
         if (profileUri != null) {
-            sb.append(profileUri.toString());
+            sb.append(profileUri);
         }
         sb.append(", targetOid=");
         if (targetOid != null) {
@@ -286,10 +153,148 @@ public class CommonCriteriaMeasures {
         }
         sb.append(", targetUri=");
         if (targetUri != null) {
-            sb.append(targetUri.toString());
+            sb.append(targetUri);
         }
         sb.append("}");
 
         return sb.toString();
     }
+
+    /**
+     * A type to handle the evaluation status used in the Common Criteria Measurement.
+     * Ordering of enum types is intentional and their ordinal values correspond to enum
+     * values in the TCG spec.
+     *
+     * <pre>
+     * EvaluationStatus ::= ENUMERATED {
+     *      designedToMeet (0),
+     *      evaluationInProgress (1),
+     *      evaluationCompleted (2) }
+     * </pre>
+     */
+    public enum EvaluationStatus {
+        /**
+         * Evaluation designed to meet.
+         */
+        DESIGNEDTOMEET("designed To Meet"),
+        /**
+         * Evaluation in progress.
+         */
+        EVALUATIONINPROGRESS("evaluation In Progress"),
+        /**
+         * Evaluation completed.
+         */
+        EVALUATIONCOMPLETED("evaluation Completed");
+
+        @Getter
+        private final String value;
+
+        /**
+         * Basic constructor.
+         *
+         * @param value string containing the value.
+         */
+        EvaluationStatus(final String value) {
+            this.value = value;
+        }
+    }
+
+    /**
+     * A type to handle the strength of function used in the Common Criteria Measurement.
+     * Ordering of enum types is intentional and their ordinal values correspond to enum
+     * values in the TCG spec.
+     *
+     * <pre>
+     * StrengthOfFunction ::= ENUMERATED {
+     *      basic (0),
+     *      medium (1),
+     *      high (2) }
+     * </pre>
+     */
+    public enum StrengthOfFunction {
+        /**
+         * Basic function.
+         */
+        BASIC("basic"),
+        /**
+         * Medium function.
+         */
+        MEDIUM("medium"),
+        /**
+         * Hight function.
+         */
+        HIGH("high");
+
+        @Getter
+        private final String value;
+
+        /**
+         * Basic constructor.
+         *
+         * @param value string containing the value.
+         */
+        StrengthOfFunction(final String value) {
+            this.value = value;
+        }
+    }
+
+
+    /**
+     * A type to handle the evaluation assurance aevel used in the Common Criteria Measurement.
+     * Ordering of enum types is intentional and their ordinal values correspond to enum
+     * values in the TCG spec.
+     *
+     * <pre>
+     * EvaluationAssuranceLevel ::= ENUMERATED {
+     *      levell (1),
+     *      level2 (2),
+     *      level3 (3),
+     *      level4 (4),
+     *      level5 (5),
+     *      level6 (6),
+     *      level7 (7) }
+     * </pre>
+     */
+    public enum EvaluationAssuranceLevel {
+        /**
+         * Evaluation Assurance Level 1.
+         */
+        LEVEL1("level 1"),
+        /**
+         * Evaluation Assurance Level 2.
+         */
+        LEVEL2("level 2"),
+        /**
+         * Evaluation Assurance Level 3.
+         */
+        LEVEL3("level 3"),
+        /**
+         * Evaluation Assurance Level 4.
+         */
+        LEVEL4("level 4"),
+        /**
+         * Evaluation Assurance Level 5.
+         */
+        LEVEL5("level 5"),
+        /**
+         * Evaluation Assurance Level 6.
+         */
+        LEVEL6("level 6"),
+        /**
+         * Evaluation Assurance Level 7.
+         */
+        LEVEL7("level 7");
+
+        @Getter
+        private final String value;
+
+        /**
+         * Basic constructor.
+         *
+         * @param value string containing the value.
+         */
+        EvaluationAssuranceLevel(final String value) {
+            this.value = value;
+        }
+    }
 }

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/certificate/attributes/FIPSLevel.java

@@ -21,60 +21,14 @@ import org.bouncycastle.asn1.ASN1Sequence;
 public class FIPSLevel {
 
     private static final int MAX_SEQUENCE_SIZE = 3;
-    /**
+    @Getter
-     * A type to handle the security Level used in the FIPS Level.
+    @Setter
-     * Ordering of enum types is intentional and their ordinal values correspond to enum
-     * values in the TCG spec.
-     *
-     * <pre>
-     * SecurityLevel ::= ENUMERATED {
-     *      level1 (1),
-     *      level2 (2),
-     *      level3 (3),
-     *      level4 (4) }
-     * </pre>
-     */
-    public enum SecurityLevel {
-        /**
-         * Security Level 1.
-         */
-        LEVEL1("level 1"),
-        /**
-         * Security Level 2.
-         */
-        LEVEL2("level 2"),
-        /**
-         * Security Level 3.
-         */
-        LEVEL3("level 3"),
-        /**
-         * Security Level 4.
-         */
-        LEVEL4("level 4");
-
-        private final String value;
-        /**
-         * Basic constructor.
-         * @param value string containing the value.
-         */
-        SecurityLevel(final String value) {
-            this.value = value;
-        }
-
-        /**
-         * Get the string value from the StrengthOfFunction.
-         * @return the string containing the value.
-         */
-        public String getValue() {
-            return this.value;
-        }
-    }
-
-    @Getter @Setter
     private ASN1IA5String version;
-    @Getter @Setter
+    @Getter
+    @Setter
     private SecurityLevel level;
-    @Getter @Setter
+    @Getter
+    @Setter
     private ASN1Boolean plus;
 
     /**
@@ -119,4 +73,56 @@ public class FIPSLevel {
                 + ", plus=" + plus.toString()
                 + '}';
     }
+
+    /**
+     * A type to handle the security Level used in the FIPS Level.
+     * Ordering of enum types is intentional and their ordinal values correspond to enum
+     * values in the TCG spec.
+     *
+     * <pre>
+     * SecurityLevel ::= ENUMERATED {
+     *      level1 (1),
+     *      level2 (2),
+     *      level3 (3),
+     *      level4 (4) }
+     * </pre>
+     */
+    public enum SecurityLevel {
+        /**
+         * Security Level 1.
+         */
+        LEVEL1("level 1"),
+        /**
+         * Security Level 2.
+         */
+        LEVEL2("level 2"),
+        /**
+         * Security Level 3.
+         */
+        LEVEL3("level 3"),
+        /**
+         * Security Level 4.
+         */
+        LEVEL4("level 4");
+
+        private final String value;
+
+        /**
+         * Basic constructor.
+         *
+         * @param value string containing the value.
+         */
+        SecurityLevel(final String value) {
+            this.value = value;
+        }
+
+        /**
+         * Get the string value from the StrengthOfFunction.
+         *
+         * @return the string containing the value.
+         */
+        public String getValue() {
+            return this.value;
+        }
+    }
 }

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/certificate/attributes/PlatformConfiguration.java

@@ -15,10 +15,12 @@ import java.util.List;
 @AllArgsConstructor
 public abstract class PlatformConfiguration {
     private ArrayList<ComponentIdentifier> componentIdentifier = new ArrayList<>();
-    @Getter @Setter
+    @Getter
+    @Setter
     private URIReference componentIdentifierUri;
     private ArrayList<PlatformProperty> platformProperties = new ArrayList<>();
-    @Getter @Setter
+    @Getter
+    @Setter
     private URIReference platformPropertiesUri;
 
     /**
@@ -55,8 +57,16 @@ public abstract class PlatformConfiguration {
         return Collections.unmodifiableList(componentIdentifier);
     }
 
+    /**
+     * @param componentIdentifier the componentIdentifier to set
+     */
+    public void setComponentIdentifier(final List<ComponentIdentifier> componentIdentifier) {
+        this.componentIdentifier = new ArrayList<>(componentIdentifier);
+    }
+
     /**
      * Add function for the component identifier array.
+     *
      * @param componentIdentifier object to add
      * @return status of the add, if successful or not
      */
@@ -68,13 +78,6 @@ public abstract class PlatformConfiguration {
         return false;
     }
 
-    /**
-     * @param componentIdentifier the componentIdentifier to set
-     */
-    public void setComponentIdentifier(final List<ComponentIdentifier> componentIdentifier) {
-        this.componentIdentifier = new ArrayList<>(componentIdentifier);
-    }
-
     /**
      * @return the platformProperties
      */
@@ -82,8 +85,16 @@ public abstract class PlatformConfiguration {
         return Collections.unmodifiableList(platformProperties);
     }
 
+    /**
+     * @param platformProperties the platformProperties to set
+     */
+    public void setPlatformProperties(final List<PlatformProperty> platformProperties) {
+        this.platformProperties = new ArrayList<>(platformProperties);
+    }
+
     /**
      * Add function for the platform property array.
+     *
      * @param platformProperty property object to add
      * @return status of the add, if successful or not
      */
@@ -94,11 +105,4 @@ public abstract class PlatformConfiguration {
 
         return false;
     }
-
-    /**
-     * @param platformProperties the platformProperties to set
-     */
-    public void setPlatformProperties(final List<PlatformProperty> platformProperties) {
-        this.platformProperties = new ArrayList<>(platformProperties);
-    }
 }

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/certificate/attributes/PlatformConfigurationV1.java

@@ -25,6 +25,7 @@ public class PlatformConfigurationV1 extends PlatformConfiguration {
 
     /**
      * Constructor given the SEQUENCE that contains Platform Configuration.
+     *
      * @param sequence containing the Platform Configuration.
      * @throws IllegalArgumentException if there was an error on the parsing
      */
@@ -96,7 +97,7 @@ public class PlatformConfigurationV1 extends PlatformConfiguration {
         }
         sb.append(", platformPropertiesUri=");
         if (getPlatformPropertiesUri() != null) {
-            sb.append(getPlatformPropertiesUri().toString());
+            sb.append(getPlatformPropertiesUri());
         }
         sb.append("}");
 

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/certificate/attributes/PlatformProperty.java

@@ -8,7 +8,6 @@ import org.bouncycastle.asn1.ASN1UTF8String;
 import org.bouncycastle.asn1.DERUTF8String;
 
 /**
- *
  * Basic class that handles a single property for the platform configuration.
  * <pre>
  * Properties ::= SEQUENCE {
@@ -22,13 +21,11 @@ import org.bouncycastle.asn1.DERUTF8String;
 @AllArgsConstructor
 public class PlatformProperty {
 
-    private static final String NOT_SPECIFIED = "Not Specified";
-
     /**
      * Number of identifiers for version 1.
      */
     protected static final int IDENTIFIER_NUMBER = 2;
-
+    private static final String NOT_SPECIFIED = "Not Specified";
     private ASN1UTF8String propertyName;
     private ASN1UTF8String propertyValue;
 

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/certificate/attributes/TBBSecurityAssertion.java

@@ -30,60 +30,6 @@ public class TBBSecurityAssertion {
     private static final int CCINFO = 0;
     private static final int FIPSLEVEL = 1;
     private static final int RTMTYPE = 2;
-
-    /**
-     * A type to handle the evaluation status used in the Common Criteria Measurement.
-     * Ordering of enum types is intentional and their ordinal values correspond to enum
-     * values in the TCG spec.
-     *
-     * <pre>
-     * MeasurementRootType ::= ENUMERATED {
-     *    static (0),
-     *    dynamic (1),
-     *    nonHost (2),
-     *    hybrid (3),
-     *    physical (4),
-     *    virtual (5) }
-     * </pre>
-     */
-    public enum MeasurementRootType {
-        /**
-         * Static measurement root type.
-         */
-        STATIC("static"),
-        /**
-         * Dynamic  measurement root type.
-         */
-        DYNAMIC("dynamic"),
-        /**
-         * Non-Host measurement root type.
-         */
-        NONHOST("nonHost"),
-        /**
-         * Hybrid measurement root type.
-         */
-        HYBRID("hybrid"),
-        /**
-         * Physical measurement root type.
-         */
-        PHYSICAL("physical"),
-        /**
-         * Virtual measurement root type.
-         */
-        VIRTUAL("virtual");
-
-        @Getter
-        private final String value;
-
-        /**
-         * Basic constructor.
-         * @param value string containing the value.
-         */
-        MeasurementRootType(final String value) {
-            this.value = value;
-        }
-    }
-
     private ASN1Integer version;
     private CommonCriteriaMeasures ccInfo;
     private FIPSLevel fipsLevel;
@@ -105,6 +51,7 @@ public class TBBSecurityAssertion {
 
     /**
      * Constructor given the SEQUENCE that contains a TBBSecurityAssertion Object.
+     *
      * @param sequence containing the the TBB Security Assertion
      * @throws IllegalArgumentException if there was an error on the parsing
      */
@@ -260,11 +207,11 @@ public class TBBSecurityAssertion {
         //Optional values not null
         sb.append(", ccInfo=");
         if (ccInfo != null) {
-            sb.append(ccInfo.toString());
+            sb.append(ccInfo);
         }
         sb.append(", fipsLevel=");
         if (fipsLevel != null) {
-            sb.append(fipsLevel.toString());
+            sb.append(fipsLevel);
         }
         sb.append(", rtmType=");
         if (rtmType != null) {
@@ -279,4 +226,58 @@ public class TBBSecurityAssertion {
 
         return sb.toString();
     }
+
+    /**
+     * A type to handle the evaluation status used in the Common Criteria Measurement.
+     * Ordering of enum types is intentional and their ordinal values correspond to enum
+     * values in the TCG spec.
+     *
+     * <pre>
+     * MeasurementRootType ::= ENUMERATED {
+     *    static (0),
+     *    dynamic (1),
+     *    nonHost (2),
+     *    hybrid (3),
+     *    physical (4),
+     *    virtual (5) }
+     * </pre>
+     */
+    public enum MeasurementRootType {
+        /**
+         * Static measurement root type.
+         */
+        STATIC("static"),
+        /**
+         * Dynamic  measurement root type.
+         */
+        DYNAMIC("dynamic"),
+        /**
+         * Non-Host measurement root type.
+         */
+        NONHOST("nonHost"),
+        /**
+         * Hybrid measurement root type.
+         */
+        HYBRID("hybrid"),
+        /**
+         * Physical measurement root type.
+         */
+        PHYSICAL("physical"),
+        /**
+         * Virtual measurement root type.
+         */
+        VIRTUAL("virtual");
+
+        @Getter
+        private final String value;
+
+        /**
+         * Basic constructor.
+         *
+         * @param value string containing the value.
+         */
+        MeasurementRootType(final String value) {
+            this.value = value;
+        }
+    }
 }

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/certificate/attributes/TPMSecurityAssertions.java

@@ -14,19 +14,61 @@ import java.math.BigInteger;
 /**
  * A class to represent the TPM Security Assertions in an Endorsement Credential as
  * defined by the TCG spec for TPM 1.2.
- *
+ * <p>
  * https://www.trustedcomputinggroup.org/wp-content/uploads/IWG-Credential_Profiles_V1_R0.pdf
- *
+ * <p>
  * Future iterations of this code may want to reference
  * www.trustedcomputinggroup.org/wp-content/uploads/Credential_Profile_EK_V2.0_R14_published.pdf
  * for specifications for TPM 2.0 (pg. 19).
  */
 @AllArgsConstructor
 @NoArgsConstructor(access = AccessLevel.PROTECTED)
-@Getter @Setter
+@Getter
+@Setter
 @Embeddable
 public class TPMSecurityAssertions implements Serializable {
 
+    @Column
+    private BigInteger tpmSecAssertsVersion; //default v1
+    @Column
+    private boolean fieldUpgradeable; //default false
+    @Column(nullable = true)
+    private EkGenerationType ekGenType; //optional
+    @Column(nullable = true)
+    private EkGenerationLocation ekGenerationLocation; //optional
+    @Column(nullable = true)
+    private EkGenerationLocation ekCertificateGenerationLocation; //optional
+
+    /**
+     * Standard constructor that sets required fields. Use accessor methods
+     * to set optional fields.
+     *
+     * @param version          the version of the security assertions
+     * @param fieldUpgradeable whether or not the security assertions are
+     *                         field upgradeable.
+     */
+    public TPMSecurityAssertions(final BigInteger version, final boolean fieldUpgradeable) {
+        this.tpmSecAssertsVersion = version;
+        this.fieldUpgradeable = fieldUpgradeable;
+    }
+
+    @Override
+    public String toString() {
+        return "TPMSecurityAssertions{"
+                + "version=" + tpmSecAssertsVersion
+                + ", fieldUpgradeable=" + fieldUpgradeable
+                + ", ekGenType=" + ekGenType
+                + ", ekGenLoc=" + ekGenerationLocation
+                + ", ekCertGenLoc=" + ekCertificateGenerationLocation
+                + '}';
+    }
+
+    // Future work (may need to create other classes):
+    //private CommonCriteriaMeasures commCritMeasures; //optional
+    //private FIPSLevel fipsLevel; //optional
+    //private boolean iso9000Certified; //default false
+    //private IA5String iso9000Uri; //optional
+
     /**
      * A type to handle the different endorsement key generation types used in the TPM
      * Assertions field of an endorsement credential. Ordering of enum types is intentional
@@ -51,7 +93,7 @@ public class TPMSecurityAssertions implements Serializable {
          * Generated externally and then inserted under a controlled environment during
          * manufacturing. Can be revoked. Enum value of 3.
          */
-        INJECTED_REVOCABLE;
+        INJECTED_REVOCABLE
     }
 
     /**
@@ -73,50 +115,6 @@ public class TPMSecurityAssertions implements Serializable {
         /**
          * Generated by the endorsement key certificate signer. Enum value of 2.
          */
-        EK_CERT_SIGNER;
+        EK_CERT_SIGNER
-    }
-
-    @Column
-    private BigInteger tpmSecAssertsVersion; //default v1
-
-    @Column
-    private boolean fieldUpgradeable; //default false
-
-    @Column(nullable = true)
-    private EkGenerationType ekGenType; //optional
-
-    @Column(nullable = true)
-    private EkGenerationLocation ekGenerationLocation; //optional
-
-    @Column(nullable = true)
-    private EkGenerationLocation ekCertificateGenerationLocation; //optional
-
-    // Future work (may need to create other classes):
-    //private CommonCriteriaMeasures commCritMeasures; //optional
-    //private FIPSLevel fipsLevel; //optional
-    //private boolean iso9000Certified; //default false
-    //private IA5String iso9000Uri; //optional
-
-    /**
-     * Standard constructor that sets required fields. Use accessor methods
-     * to set optional fields.
-     * @param version the version of the security assertions
-     * @param fieldUpgradeable whether or not the security assertions are
-     *                         field upgradeable.
-     */
-    public TPMSecurityAssertions(final BigInteger version, final boolean fieldUpgradeable) {
-        this.tpmSecAssertsVersion = version;
-        this.fieldUpgradeable = fieldUpgradeable;
-    }
-
-    @Override
-    public String toString() {
-        return "TPMSecurityAssertions{"
-                + "version=" + tpmSecAssertsVersion
-                + ", fieldUpgradeable=" + fieldUpgradeable
-                + ", ekGenType=" + ekGenType
-                + ", ekGenLoc=" + ekGenerationLocation
-                + ", ekCertGenLoc=" + ekCertificateGenerationLocation
-                + '}';
     }
 }

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/certificate/attributes/TPMSpecification.java

@@ -13,9 +13,9 @@ import java.math.BigInteger;
 /**
  * A class to represent the TPM Specification in an Endorsement Credential as
  * defined by the TCG spec for TPM 1.2.
- *
+ * <p>
  * https://www.trustedcomputinggroup.org/wp-content/uploads/IWG-Credential_Profiles_V1_R0.pdf
- *
+ * <p>
  * Future iterations of this code may want to reference
  * www.trustedcomputinggroup.org/wp-content/uploads/Credential_Profile_EK_V2.0_R14_published.pdf
  * for specifications for TPM 2.0.
@@ -37,6 +37,7 @@ public class TPMSpecification implements Serializable {
 
     /**
      * Standard constructor.
+     *
      * @param family   the specification family.
      * @param level    the specification level.
      * @param revision the specification revision.

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/certificate/attributes/URIReference.java

@@ -10,27 +10,26 @@ import org.bouncycastle.asn1.ASN1Sequence;
 import org.bouncycastle.asn1.x509.AlgorithmIdentifier;
 
 /**
- *
  * Basic class that handle a URIReference object.
  * <pre>
  * URIReference ::= SEQUENCE {
  *      uniformResourceIdentifier IA5String (SIZE (1..URIMAX)),
  *      hashAlgorithm AlgorithmIdentifier OPTIONAL,
  *      hashValue BIT STRING OPTIONAL
- }
+ * }
  * </pre>
  */
-@Getter @Setter
+@Getter
+@Setter
 @AllArgsConstructor
 public class URIReference {
+    private static final int PLATFORM_PROPERTIES_URI_MAX = 3;
+    private static final int PLATFORM_PROPERTIES_URI_MIN = 1;
     private ASN1IA5String uniformResourceIdentifier;
     private AlgorithmIdentifier hashAlgorithm;
     @JsonIgnore
     private ASN1BitString hashValue;
 
-    private static final int PLATFORM_PROPERTIES_URI_MAX = 3;
-    private static final int PLATFORM_PROPERTIES_URI_MIN = 1;
-
     /**
      * Default constructor.
      */

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/certificate/attributes/V2/CertificateIdentifier.java

@@ -51,6 +51,7 @@ public class CertificateIdentifier {
 
     /**
      * Primary constructor for the parsing of the sequence.
+     *
      * @param sequence containing the name and value of the Certificate Identifier
      */
     public CertificateIdentifier(final ASN1Sequence sequence) {
@@ -103,6 +104,7 @@ public class CertificateIdentifier {
 
     /**
      * String for the internal data stored.
+     *
      * @return String representation of the data.
      */
     @Override
@@ -114,11 +116,11 @@ public class CertificateIdentifier {
         sb.append(", hashSigValue").append(hashSigValue);
         sb.append(", issuerDN=");
         if (issuerDN != null) {
-            sb.append(issuerDN.toString());
+            sb.append(issuerDN);
         }
         sb.append(", certificateSerialNumber=");
         if (certificateSerialNumber != null) {
-            sb.append(certificateSerialNumber.toString());
+            sb.append(certificateSerialNumber);
         }
 
         sb.append("}");

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/certificate/attributes/V2/PlatformConfigurationV2.java

@@ -29,6 +29,7 @@ public class PlatformConfigurationV2 extends PlatformConfiguration {
 
     /**
      * Constructor given the SEQUENCE that contains Platform Configuration.
+     *
      * @param sequence containing the the Platform Configuration.
      * @throws IllegalArgumentException if there was an error on the parsing
      */
@@ -99,7 +100,7 @@ public class PlatformConfigurationV2 extends PlatformConfiguration {
         }
         sb.append(", componentIdentifierUri=");
         if (getComponentIdentifierUri() != null) {
-            sb.append(getComponentIdentifierUri().toString());
+            sb.append(getComponentIdentifierUri());
         }
         sb.append(", platformProperties=");
         if (getPlatformProperties().size() > 0) {
@@ -110,7 +111,7 @@ public class PlatformConfigurationV2 extends PlatformConfiguration {
         }
         sb.append(", platformPropertiesUri=");
         if (getPlatformPropertiesUri() != null) {
-            sb.append(getPlatformPropertiesUri().toString());
+            sb.append(getPlatformPropertiesUri());
         }
         sb.append("}");
 

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/certificate/attributes/V2/PlatformPropertyV2.java

@@ -8,7 +8,6 @@ import org.bouncycastle.asn1.ASN1Sequence;
 import org.bouncycastle.asn1.ASN1UTF8String;
 
 /**
- *
  * Basic class that handles a single property for the platform configuration.
  * <pre>
  * Properties ::= SEQUENCE {
@@ -91,7 +90,7 @@ public class PlatformPropertyV2 extends PlatformProperty {
         sb.append("PropertyName=").append(getPropertyName().getString());
         sb.append(", propertyValue=").append(getPropertyValue().getString());
         if (attributeStatus != null) {
-            sb.append(", attributeStatus=").append(attributeStatus.toString());
+            sb.append(", attributeStatus=").append(attributeStatus);
         }
         sb.append("}");
 

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/info/ComponentInfo.java

@@ -34,6 +34,7 @@ public class ComponentInfo extends ArchivableEntity {
 
     @Column(nullable = false)
     private String deviceName;
+
     @XmlElement
     @Column(nullable = false)
     private String componentManufacturer;
@@ -56,6 +57,7 @@ public class ComponentInfo extends ArchivableEntity {
 
     /**
      * Base constructor for children.
+     *
      * @param componentManufacturer Component Manufacturer (must not be null)
      * @param componentModel        Component Model (must not be null)
      * @param componentSerial       Component Serial Number (can be null)
@@ -68,8 +70,10 @@ public class ComponentInfo extends ArchivableEntity {
         this(DeviceInfoEnums.NOT_SPECIFIED, componentManufacturer, componentModel,
                 componentSerial, componentRevision);
     }
+
     /**
      * Constructor.
+     *
      * @param deviceName            the host machine associated with this component. (must not be null)
      * @param componentManufacturer Component Manufacturer (must not be null)
      * @param componentModel        Component Model (must not be null)
@@ -108,6 +112,7 @@ public class ComponentInfo extends ArchivableEntity {
 
     /**
      * Constructor.
+     *
      * @param deviceName            the host machine associated with this component.
      * @param componentManufacturer Component Manufacturer (must not be null)
      * @param componentModel        Component Model (must not be null)
@@ -149,13 +154,18 @@ public class ComponentInfo extends ArchivableEntity {
 
     /**
      * Equals for the component info that just uses this classes attributes.
+     *
      * @param object the object to compare
      * @return the boolean result
      */
     @Override
     public boolean equals(Object object) {
-        if (this == object) return true;
+        if (this == object) {
-        if (object == null || getClass() != object.getClass()) return false;
+            return true;
+        }
+        if (object == null || getClass() != object.getClass()) {
+            return false;
+        }
 
         ComponentInfo that = (ComponentInfo) object;
         return Objects.equals(deviceName, that.deviceName)
@@ -169,6 +179,7 @@ public class ComponentInfo extends ArchivableEntity {
 
     /**
      * Returns a hash code that is associated with common fields for components.
+     *
      * @return int value of the elements
      */
     public int hashCommonElements() {
@@ -178,6 +189,7 @@ public class ComponentInfo extends ArchivableEntity {
 
     /**
      * Hash method for the attributes of this class.
+     *
      * @return int value that represents this class
      */
     @Override

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/info/NetworkInfo.java

@@ -10,46 +10,41 @@ import lombok.extern.log4j.Log4j2;
 
 import java.io.Serializable;
 import java.net.InetAddress;
-import java.util.Arrays;
-import java.util.Objects;
 
 /**
  * This class is used to represent the network info of a device.
  */
 @Log4j2
 @Embeddable
+@EqualsAndHashCode
 public class NetworkInfo implements Serializable {
 
     private static final int NUM_MAC_ADDRESS_BYTES = 6;
 
     @XmlElement
     @Getter
-    @Column(length = DeviceInfoEnums.LONG_STRING_LENGTH, nullable = true)
+    @Column(length = DeviceInfoEnums.LONG_STRING_LENGTH)
     private String hostname;
 
     @XmlElement
     @Getter
 //    @XmlJavaTypeAdapter(value = InetAddressXmlAdapter.class)
-    @Column(length = DeviceInfoEnums.SHORT_STRING_LENGTH, nullable = true)
+    @Column(length = DeviceInfoEnums.SHORT_STRING_LENGTH)
 //    @JsonSubTypes.Type(type = "hirs.data.persist.type.InetAddressType")
     private InetAddress ipAddress;
 
     @XmlElement
-    @Column(length = NUM_MAC_ADDRESS_BYTES, nullable = true)
+    @Column(length = NUM_MAC_ADDRESS_BYTES)
-    @SuppressWarnings("checkstyle:magicnumber")
     private byte[] macAddress;
 
     /**
      * Constructor used to create a NetworkInfo object.
      *
-     * @param hostname
+     * @param hostname   String representing the hostname information for the device,
-     *            String representing the hostname information for the device,
      *                   can be null if hostname unknown
-     * @param ipAddress
+     * @param ipAddress  InetAddress object representing the IP address for the device,
-     *            InetAddress object representing the IP address for the device,
      *                   can be null if IP address unknown
-     * @param macAddress
+     * @param macAddress byte array representing the MAC address for the device, can be
-     *            byte array representing the MAC address for the device, can be
      *                   null if MAC address is unknown
      */
     public NetworkInfo(final String hostname, final InetAddress ipAddress,
@@ -82,16 +77,6 @@ public class NetworkInfo implements Serializable {
         }
     }
 
-    private void setHostname(final String hostname) {
-        log.debug("setting hostname to: {}", hostname);
-        this.hostname = hostname;
-    }
-
-    private void setIpAddress(final InetAddress ipAddress) {
-        log.debug("setting IP address to: {}", ipAddress);
-        this.ipAddress = ipAddress;
-    }
-
     private void setMacAddress(final byte[] macAddress) {
         StringBuilder sb;
         if (macAddress == null) {
@@ -114,22 +99,13 @@ public class NetworkInfo implements Serializable {
         this.macAddress = macAddress;
     }
 
-    @Override
+    private void setHostname(final String hostname) {
-    public boolean equals(Object o) {
+        log.debug("setting hostname to: {}", hostname);
-        if (this == o) return true;
+        this.hostname = hostname;
-        if (!(o instanceof NetworkInfo)) {
-            return false;
-        }
-        NetworkInfo that = (NetworkInfo) o;
-        return Objects.equals(hostname, that.hostname)
-                && Objects.equals(ipAddress, that.ipAddress)
-                && Arrays.equals(macAddress, that.macAddress);
     }
 
-    @Override
+    private void setIpAddress(final InetAddress ipAddress) {
-    public int hashCode() {
+        log.debug("setting IP address to: {}", ipAddress);
-        int result = Objects.hash(hostname, ipAddress);
+        this.ipAddress = ipAddress;
-        result = 31 * result + Arrays.hashCode(macAddress);
-        return result;
     }
 }

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/info/OSInfo.java

@@ -47,16 +47,11 @@ public class OSInfo implements Serializable {
      * Fedora), and distribution release (7.0.1406). Distribution only makes
      * sense for Linux, so distribution and distributionRelease may be null.
      *
-     * @param osName
+     * @param osName              String OS name (Linux | Mac OS X | Windows 7)
-     *            String OS name (Linux | Mac OS X | Windows 7)
+     * @param osVersion           String OS version (i.e. 3.10.0-123.el7.x86_64)
-     * @param osVersion
+     * @param osArch              String OS architecture (x86_64)
-     *            String OS version (i.e. 3.10.0-123.el7.x86_64)
+     * @param distribution        String distribution (CentOS | Fedora)
-     * @param osArch
+     * @param distributionRelease String distribution release (7.0.1406)
-     *            String OS architecture (x86_64)
-     * @param distribution
-     *            String distribution (CentOS | Fedora)
-     * @param distributionRelease
-     *            String distribution release (7.0.1406)
      */
     public OSInfo(final String osName, final String osVersion,
                   final String osArch, final String distribution,

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/info/RIMInfo.java

@@ -38,6 +38,7 @@ public class RIMInfo implements Serializable {
 
     /**
      * Constructor for the initial values of the class.
+     *
      * @param rimManufacturer string of the rimManufacturer
      * @param model           string of the model
      * @param fileHash        string of the file hash

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/info/TPMInfo.java

@@ -68,25 +68,16 @@ public class TPMInfo implements Serializable {
     /**
      * Constructor used to create a TPMInfo object.
      *
-     * @param tpmMake
+     * @param tpmMake             String representing the make information for the TPM,
-     *            String representing the make information for the TPM,
      *                            NullPointerException thrown if null
-     * @param tpmVersionMajor
+     * @param tpmVersionMajor     short representing the major version number for the TPM
-     *            short representing the major version number for the TPM
+     * @param tpmVersionMinor     short representing the minor version number for the TPM
-     * @param tpmVersionMinor
+     * @param tpmVersionRevMajor  short representing the major revision number for the TPM
-     *            short representing the minor version number for the TPM
+     * @param tpmVersionRevMinor  short representing the minor revision number for the TPM
-     * @param tpmVersionRevMajor
+     * @param identityCertificate byte array with the value of the identity certificate
-     *            short representing the major revision number for the TPM
+     * @param pcrValues           short representing the major revision number for the TPM
-     * @param tpmVersionRevMinor
+     * @param tpmQuoteHash        short representing the minor revision number for the TPM
-     *            short representing the minor revision number for the TPM
+     * @param tpmQuoteSignature   byte array with the value of the identity certificate
-     * @param identityCertificate
-     *            byte array with the value of the identity certificate
-     * @param pcrValues
-     *            short representing the major revision number for the TPM
-     * @param tpmQuoteHash
-     *            short representing the minor revision number for the TPM
-     * @param tpmQuoteSignature
-     *            byte array with the value of the identity certificate
      */
     @SuppressWarnings("parameternumber")
     public TPMInfo(final String tpmMake, final short tpmVersionMajor,
@@ -109,23 +100,15 @@ public class TPMInfo implements Serializable {
      * Constructor used to create a TPMInfo object without an identity
      * certificate.
      *
-     * @param tpmMake
+     * @param tpmMake            String representing the make information for the TPM,
-     *            String representing the make information for the TPM,
      *                           NullPointerException thrown if null
-     * @param tpmVersionMajor
+     * @param tpmVersionMajor    short representing the major version number for the TPM
-     *            short representing the major version number for the TPM
+     * @param tpmVersionMinor    short representing the minor version number for the TPM
-     * @param tpmVersionMinor
+     * @param tpmVersionRevMajor short representing the major revision number for the TPM
-     *            short representing the minor version number for the TPM
+     * @param tpmVersionRevMinor short representing the minor revision number for the TPM
-     * @param tpmVersionRevMajor
+     * @param pcrValues          short representing the major revision number for the TPM
-     *            short representing the major revision number for the TPM
+     * @param tpmQuoteHash       short representing the minor revision number for the TPM
-     * @param tpmVersionRevMinor
+     * @param tpmQuoteSignature  byte array with the value of the identity certificate
-     *            short representing the minor revision number for the TPM
-     * @param pcrValues
-     *            short representing the major revision number for the TPM
-     * @param tpmQuoteHash
-     *            short representing the minor revision number for the TPM
-     * @param tpmQuoteSignature
-     *            byte array with the value of the identity certificate
      */
     @SuppressWarnings("parameternumber")
     public TPMInfo(final String tpmMake, final short tpmVersionMajor,
@@ -146,17 +129,12 @@ public class TPMInfo implements Serializable {
      * Constructor used to create a TPMInfo object without an identity
      * certificate.
      *
-     * @param tpmMake
+     * @param tpmMake            String representing the make information for the TPM,
-     *            String representing the make information for the TPM,
      *                           NullPointerException thrown if null
-     * @param tpmVersionMajor
+     * @param tpmVersionMajor    short representing the major version number for the TPM
-     *            short representing the major version number for the TPM
+     * @param tpmVersionMinor    short representing the minor version number for the TPM
-     * @param tpmVersionMinor
+     * @param tpmVersionRevMajor short representing the major revision number for the TPM
-     *            short representing the minor version number for the TPM
+     * @param tpmVersionRevMinor short representing the minor revision number for the TPM
-     * @param tpmVersionRevMajor
-     *            short representing the major revision number for the TPM
-     * @param tpmVersionRevMinor
-     *            short representing the minor revision number for the TPM
      */
     public TPMInfo(final String tpmMake, final short tpmVersionMajor,
                    final short tpmVersionMinor, final short tpmVersionRevMajor,
@@ -170,19 +148,13 @@ public class TPMInfo implements Serializable {
      * Constructor used to create a TPMInfo object without an identity
      * certificate.
      *
-     * @param tpmMake
+     * @param tpmMake             String representing the make information for the TPM,
-     *            String representing the make information for the TPM,
      *                            NullPointerException thrown if null
-     * @param tpmVersionMajor
+     * @param tpmVersionMajor     short representing the major version number for the TPM
-     *            short representing the major version number for the TPM
+     * @param tpmVersionMinor     short representing the minor version number for the TPM
-     * @param tpmVersionMinor
+     * @param tpmVersionRevMajor  short representing the major revision number for the TPM
-     *            short representing the minor version number for the TPM
+     * @param tpmVersionRevMinor  short representing the minor revision number for the TPM
-     * @param tpmVersionRevMajor
+     * @param identityCertificate byte array with the value of the identity certificate
-     *            short representing the major revision number for the TPM
-     * @param tpmVersionRevMinor
-     *            short representing the minor revision number for the TPM
-     * @param identityCertificate
-     *            byte array with the value of the identity certificate
      */
     public TPMInfo(final String tpmMake, final short tpmVersionMajor,
                    final short tpmVersionMinor, final short tpmVersionRevMajor,
@@ -217,30 +189,67 @@ public class TPMInfo implements Serializable {
         return identityCertificate;
     }
 
+    private void setIdentityCertificate(
+            final X509Certificate identityCertificate) {
+        if (identityCertificate == null) {
+            log.error("identity certificate cannot be null");
+            throw new NullPointerException("identityCertificate");
+        }
+        log.debug("setting identity certificate");
+        this.identityCertificate = identityCertificate;
+    }
+
     /**
      * Getter for the tpmQuote passed up by the client.
+     *
      * @return a byte blob of quote
      */
     public final byte[] getTpmQuoteHash() {
         return tpmQuoteHash.clone();
     }
 
+    private void setTpmQuoteHash(final byte[] tpmQuoteHash) {
+        if (tpmQuoteHash == null) {
+            this.tpmQuoteHash = new byte[0];
+        } else {
+            this.tpmQuoteHash = tpmQuoteHash.clone();
+        }
+    }
+
     /**
      * Getter for the quote signature.
+     *
      * @return a byte blob.
      */
     public final byte[] getTpmQuoteSignature() {
         return tpmQuoteSignature.clone();
     }
 
+    private void setTpmQuoteSignature(final byte[] tpmQuoteSignature) {
+        if (tpmQuoteSignature == null) {
+            this.tpmQuoteSignature = new byte[0];
+        } else {
+            this.tpmQuoteSignature = tpmQuoteSignature.clone();
+        }
+    }
+
     /**
      * Getter for the pcr values.
+     *
      * @return a byte blob for the pcrValues.
      */
     public final byte[] getPcrValues() {
         return pcrValues.clone();
     }
 
+    private void setPcrValues(final byte[] pcrValues) {
+        if (pcrValues == null) {
+            this.pcrValues = new byte[0];
+        } else {
+            this.pcrValues = pcrValues.clone();
+        }
+    }
+
     private void setTPMMake(final String tpmMake) {
         log.debug("setting TPM make info: {}", tpmMake);
         this.tpmMake = StringValidator.check(tpmMake, "tpmMake")
@@ -292,38 +301,4 @@ public class TPMInfo implements Serializable {
                 tpmVersionRevMinor);
         this.tpmVersionRevMinor = tpmVersionRevMinor;
     }
-
-    private void setIdentityCertificate(
-            final X509Certificate identityCertificate) {
-        if (identityCertificate == null) {
-            log.error("identity certificate cannot be null");
-            throw new NullPointerException("identityCertificate");
-        }
-        log.debug("setting identity certificate");
-        this.identityCertificate = identityCertificate;
-    }
-
-    private void setPcrValues(final byte[] pcrValues) {
-        if (pcrValues == null) {
-            this.pcrValues = new byte[0];
-        } else {
-            this.pcrValues = pcrValues.clone();
-        }
-    }
-
-    private void setTpmQuoteHash(final byte[] tpmQuoteHash) {
-        if (tpmQuoteHash == null) {
-            this.tpmQuoteHash = new byte[0];
-        } else {
-            this.tpmQuoteHash = tpmQuoteHash.clone();
-        }
-    }
-
-    private void setTpmQuoteSignature(final byte[] tpmQuoteSignature) {
-        if (tpmQuoteSignature == null) {
-            this.tpmQuoteSignature = new byte[0];
-        } else {
-            this.tpmQuoteSignature = tpmQuoteSignature.clone();
-        }
-    }
 }

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/info/component/package-info.java

@@ -0,0 +1 @@
+package hirs.attestationca.persist.entity.userdefined.info.component;

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/info/package-info.java

@@ -0,0 +1 @@
+package hirs.attestationca.persist.entity.userdefined.info;

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/record/TPMMeasurementRecord.java

@@ -63,8 +63,7 @@ public final class TPMMeasurementRecord extends ExaminableRecord {
      * Constructor initializes values associated with TPMMeasurementRecord.
      *
      * @param pcrId is the TPM PCR index. pcrId must be between 0 and 23.
-     * @param hash
+     * @param hash  represents the measurement digest found at the particular PCR
-     *            represents the measurement digest found at the particular PCR
      *              index.
      * @throws IllegalArgumentException if pcrId is not valid
      */
@@ -105,11 +104,19 @@ public final class TPMMeasurementRecord extends ExaminableRecord {
         this(pcrId, new Digest(hash));
     }
 
+    /**
+     * Default constructor necessary for Hibernate.
+     */
+    private TPMMeasurementRecord() {
+        super();
+        this.pcrId = -1;
+        this.hash = null;
+    }
+
     /**
      * Helper method to determine if a PCR ID number is valid.
      *
-     * @param pcrId
+     * @param pcrId int to check
-     *            int to check
      */
     public static void checkForValidPcrId(final int pcrId) {
         if (pcrId < MIN_PCR_ID || pcrId > MAX_PCR_ID) {
@@ -118,13 +125,4 @@ public final class TPMMeasurementRecord extends ExaminableRecord {
             throw new IllegalArgumentException(msg);
         }
     }
-
-    /**
-     * Default constructor necessary for Hibernate.
-     */
-    protected TPMMeasurementRecord() {
-        super();
-        this.pcrId = -1;
-        this.hash = null;
-    }
 }

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/report/DeviceInfoReport.java

@@ -67,16 +67,11 @@ public class DeviceInfoReport extends AbstractEntity implements Serializable {
      * information cannot be changed after the <code>DeviceInfoReport</code> is
      * created.
      *
-     * @param networkInfo
+     * @param networkInfo  NetworkInfo object, cannot be null
-     *            NetworkInfo object, cannot be null
+     * @param osInfo       OSInfo object, cannot be null
-     * @param osInfo
+     * @param firmwareInfo FirmwareInfo object, cannot be null
-     *            OSInfo object, cannot be null
+     * @param hardwareInfo HardwareInfo object, cannot be null
-     * @param firmwareInfo
+     * @param tpmInfo      TPMInfo object, may be null if a TPM is not available on the
-     *            FirmwareInfo object, cannot be null
-     * @param hardwareInfo
-     *            HardwareInfo object, cannot be null
-     * @param tpmInfo
-     *            TPMInfo object, may be null if a TPM is not available on the
      *                     device
      */
     public DeviceInfoReport(final NetworkInfo networkInfo, final OSInfo osInfo,
@@ -90,19 +85,13 @@ public class DeviceInfoReport extends AbstractEntity implements Serializable {
      * information cannot be changed after the <code>DeviceInfoReport</code> is
      * created.
      *
-     * @param networkInfo
+     * @param networkInfo              NetworkInfo object, cannot be null
-     *            NetworkInfo object, cannot be null
+     * @param osInfo                   OSInfo object, cannot be null
-     * @param osInfo
+     * @param firmwareInfo             FirmwareInfo object, cannot be null
-     *            OSInfo object, cannot be null
+     * @param hardwareInfo             HardwareInfo object, cannot be null
-     * @param firmwareInfo
+     * @param tpmInfo                  TPMInfo object, may be null if a TPM is not available on the
-     *            FirmwareInfo object, cannot be null
-     * @param hardwareInfo
-     *            HardwareInfo object, cannot be null
-     * @param tpmInfo
-     *            TPMInfo object, may be null if a TPM is not available on the
      *                                 device
-     * @param clientApplicationVersion
+     * @param clientApplicationVersion string representing the version of the client that submitted this report,
-     *            string representing the version of the client that submitted this report,
      *                                 cannot be null
      */
     public DeviceInfoReport(final NetworkInfo networkInfo, final OSInfo osInfo,
@@ -135,6 +124,14 @@ public class DeviceInfoReport extends AbstractEntity implements Serializable {
                 networkInfo.getIpAddress(), networkInfo.getMacAddress());
     }
 
+    private void setNetworkInfo(final NetworkInfo networkInfo) {
+        if (networkInfo == null) {
+            log.error("NetworkInfo cannot be null");
+            throw new NullPointerException("network info");
+        }
+        this.networkInfo = networkInfo;
+    }
+
     /**
      * Retrieves the OSInfo for this <code>DeviceInfoReport</code>.
      *
@@ -154,6 +151,14 @@ public class DeviceInfoReport extends AbstractEntity implements Serializable {
         return osInfo;
     }
 
+    private void setOSInfo(final OSInfo osInfo) {
+        if (osInfo == null) {
+            log.error("OSInfo cannot be null");
+            throw new NullPointerException("os info");
+        }
+        this.osInfo = osInfo;
+    }
+
     /**
      * Retrieves the FirmwareInfo for this <code>DeviceInfoReport</code>.
      *
@@ -172,6 +177,14 @@ public class DeviceInfoReport extends AbstractEntity implements Serializable {
         return firmwareInfo;
     }
 
+    private void setFirmwareInfo(final FirmwareInfo firmwareInfo) {
+        if (firmwareInfo == null) {
+            log.error("FirmwareInfo cannot be null");
+            throw new NullPointerException("firmware info");
+        }
+        this.firmwareInfo = firmwareInfo;
+    }
+
     /**
      * Retrieves the OSInfo for this <code>DeviceInfoReport</code>.
      *
@@ -196,30 +209,6 @@ public class DeviceInfoReport extends AbstractEntity implements Serializable {
         return hardwareInfo;
     }
 
-    private void setNetworkInfo(final NetworkInfo networkInfo) {
-        if (networkInfo == null) {
-            log.error("NetworkInfo cannot be null");
-            throw new NullPointerException("network info");
-        }
-        this.networkInfo = networkInfo;
-    }
-
-    private void setOSInfo(final OSInfo osInfo) {
-        if (osInfo == null) {
-            log.error("OSInfo cannot be null");
-            throw new NullPointerException("os info");
-        }
-        this.osInfo = osInfo;
-    }
-
-    private void setFirmwareInfo(final FirmwareInfo firmwareInfo) {
-        if (firmwareInfo == null) {
-            log.error("FirmwareInfo cannot be null");
-            throw new NullPointerException("firmware info");
-        }
-        this.firmwareInfo = firmwareInfo;
-    }
-
     private void setHardwareInfo(final HardwareInfo hardwareInfo) {
         if (hardwareInfo == null) {
             log.error("HardwareInfo cannot be null");
@@ -234,11 +223,12 @@ public class DeviceInfoReport extends AbstractEntity implements Serializable {
 
     @Override
     public boolean equals(Object o) {
-        if (this == o) return true;
+        if (this == o) {
-        if (!(o instanceof DeviceInfoReport)) {
+            return true;
+        }
+        if (!(o instanceof DeviceInfoReport that)) {
             return false;
         }
-        DeviceInfoReport that = (DeviceInfoReport) o;
         return Objects.equals(networkInfo, that.networkInfo)
                 && Objects.equals(osInfo, that.osInfo)
                 && Objects.equals(firmwareInfo, that.firmwareInfo)

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/result/CertificateValidationResult.java

@@ -6,11 +6,27 @@ import lombok.Setter;
 /**
  * An <code>CertificateValidationResult</code> represents the result of a certificate validation
  * operation.
- *
  */
 @Getter
 @Setter
 public class CertificateValidationResult {
+    private CertificateValidationStatus validationStatus;
+    private String validationResultMessage;
+
+    /**
+     * Sets the certificate validation status and result message.
+     *
+     * @param status        enum representing the certificate validation status
+     * @param resultMessage String representing certificate validation message
+     */
+    public final void setCertValidationStatusAndResultMessage(
+            final CertificateValidationStatus status,
+            final String resultMessage) {
+        this.validationStatus = status;
+        this.validationResultMessage = resultMessage;
+    }
+
+
     /**
      * Enum used to represent certificate validation status.
      */
@@ -31,21 +47,4 @@ public class CertificateValidationResult {
          */
         ERROR
     }
-
-    private CertificateValidationStatus validationStatus;
-    private String validationResultMessage;
-
-
-    /**
-     * Sets the certificate validation status and result message.
-     *
-     * @param status        enum representing the certificate validation status
-     * @param resultMessage String representing certificate validation message
-     */
-    public final void setCertValidationStatusAndResultMessage(
-            final CertificateValidationStatus status,
-            final String resultMessage) {
-        this.validationStatus = status;
-        this.validationResultMessage = resultMessage;
-    }
 }

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/rim/BaseReferenceManifest.java

@@ -127,9 +127,11 @@ public class BaseReferenceManifest extends ReferenceManifest {
                     SwidTagConstants.SWIDTAG_NAMESPACE, SwidTagConstants.META).item(0);
             setTagId(softwareIdentity.getAttribute(SwidTagConstants.TAGID));
             this.swidName = softwareIdentity.getAttribute(SwidTagConstants.NAME);
-            this.swidCorpus = Boolean.parseBoolean(softwareIdentity.getAttribute(SwidTagConstants.CORPUS)) ? 1 : 0;
+            this.swidCorpus =
+                    Boolean.parseBoolean(softwareIdentity.getAttribute(SwidTagConstants.CORPUS)) ? 1 : 0;
             this.setSwidPatch(Boolean.parseBoolean(softwareIdentity.getAttribute(SwidTagConstants.PATCH)));
-            this.setSwidSupplemental(Boolean.parseBoolean(softwareIdentity.getAttribute(SwidTagConstants.SUPPLEMENTAL)));
+            this.setSwidSupplemental(
+                    Boolean.parseBoolean(softwareIdentity.getAttribute(SwidTagConstants.SUPPLEMENTAL)));
             this.setSwidVersion(softwareIdentity.getAttribute(SwidTagConstants.VERSION));
             this.setSwidTagVersion(softwareIdentity.getAttribute(SwidTagConstants.TAGVERSION));
 
@@ -154,8 +156,10 @@ public class BaseReferenceManifest extends ReferenceManifest {
             this.rimLinkHash = softwareMeta.getAttribute(SwidTagConstants._RIM_LINK_HASH_STR);
             this.bindingSpec = softwareMeta.getAttribute(SwidTagConstants._BINDING_SPEC_STR);
             this.bindingSpecVersion = softwareMeta.getAttribute(SwidTagConstants._BINDING_SPEC_VERSION_STR);
-            this.setPlatformManufacturerId(softwareMeta.getAttribute(SwidTagConstants._PLATFORM_MANUFACTURER_ID_STR));
+            this.setPlatformManufacturerId(
-            this.setPlatformManufacturer(softwareMeta.getAttribute(SwidTagConstants._PLATFORM_MANUFACTURER_STR));
+                    softwareMeta.getAttribute(SwidTagConstants._PLATFORM_MANUFACTURER_ID_STR));
+            this.setPlatformManufacturer(
+                    softwareMeta.getAttribute(SwidTagConstants._PLATFORM_MANUFACTURER_STR));
             this.setPlatformModel(softwareMeta.getAttribute(SwidTagConstants._PLATFORM_MODEL_STR));
             this.platformVersion = softwareMeta.getAttribute(SwidTagConstants._PLATFORM_VERSION_STR);
             this.payloadType = softwareMeta.getAttribute(SwidTagConstants._PAYLOAD_TYPE_STR);
@@ -202,7 +206,6 @@ public class BaseReferenceManifest extends ReferenceManifest {
      * This method validates the .swidtag file at the given filepath against the
      * schema. A successful validation results in the output of the tag's name
      * and tagId attributes, otherwise a generic error message is printed.
-     *
      */
     private Element getDirectoryTag(final byte[] rimBytes) {
         if (rimBytes == null || rimBytes.length == 0) {
@@ -254,7 +257,6 @@ public class BaseReferenceManifest extends ReferenceManifest {
      * This method iterates over the list of File elements under the directory.
      *
      * @param rimBytes the bytes to find the files
-     *
      */
     public List<SwidResource> getFileResources(final byte[] rimBytes) {
         Element directoryTag = getDirectoryTag(rimBytes);
@@ -353,9 +355,15 @@ public class BaseReferenceManifest extends ReferenceManifest {
 
     @Override
     public boolean equals(Object o) {
-        if (this == o) return true;
+        if (this == o) {
-        if (o == null || getClass() != o.getClass()) return false;
+            return true;
-        if (!super.equals(o)) return false;
+        }
+        if (o == null || getClass() != o.getClass()) {
+            return false;
+        }
+        if (!super.equals(o)) {
+            return false;
+        }
         BaseReferenceManifest that = (BaseReferenceManifest) o;
         return swidCorpus == that.swidCorpus && Objects.equals(swidName, that.swidName)
                 && Objects.equals(colloquialVersion, that.colloquialVersion)

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/rim/EventLogMeasurements.java

@@ -1,7 +1,6 @@
 package hirs.attestationca.persist.entity.userdefined.rim;
 
 import com.fasterxml.jackson.annotation.JsonIgnore;
-import hirs.attestationca.persist.entity.userdefined.ReferenceManifest;
 import hirs.attestationca.persist.enums.AppraisalStatus;
 import hirs.utils.tpm.eventlog.TCGEventLog;
 import hirs.utils.tpm.eventlog.TpmPcrEvent;
@@ -31,10 +30,12 @@ public class EventLogMeasurements extends SupportReferenceManifest {
 
     @Column
     @JsonIgnore
-    @Getter @Setter
+    @Getter
+    @Setter
     private int pcrHash = 0;
     @Enumerated(EnumType.STRING)
-    @Getter @Setter
+    @Getter
+    @Setter
     private AppraisalStatus.Status overallValidationResult = AppraisalStatus.Status.FAIL;
 
     /**
@@ -74,6 +75,7 @@ public class EventLogMeasurements extends SupportReferenceManifest {
     /**
      * Getter method for the expected PCR values contained within the support
      * RIM.
+     *
      * @return a string array of the pcr values.
      */
     public String[] getExpectedPCRList() {

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/rim/ReferenceDigestValue.java

@@ -8,7 +8,6 @@ import jakarta.persistence.Entity;
 import jakarta.persistence.Table;
 import lombok.AllArgsConstructor;
 import lombok.Builder;
-
 import lombok.EqualsAndHashCode;
 import lombok.Getter;
 import lombok.Setter;
@@ -88,6 +87,7 @@ public class ReferenceDigestValue extends AbstractEntity {
 
     /**
      * Default Constructor with parameters for all associated data.
+     *
      * @param baseRimId      the UUID of the associated record
      * @param supportRimId   the UUID of the associated record
      * @param manufacturer   associated creator for this information
@@ -124,6 +124,7 @@ public class ReferenceDigestValue extends AbstractEntity {
 
     /**
      * the object that contains the raw bytes for this RDV.
+     *
      * @return the raw bytes
      */
     public byte[] getContentBlob() {
@@ -132,6 +133,7 @@ public class ReferenceDigestValue extends AbstractEntity {
 
     /**
      * Helper method to update the attributes of this object.
+     *
      * @param support   the associated RIM.
      * @param baseRimId the main id to update
      */
@@ -151,6 +153,7 @@ public class ReferenceDigestValue extends AbstractEntity {
 
     /**
      * Returns a string of the classes fields.
+     *
      * @return a string
      */
     public String toString() {

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/userdefined/rim/SupportReferenceManifest.java

@@ -71,6 +71,7 @@ public class SupportReferenceManifest extends ReferenceManifest {
     /**
      * Getter method for the expected PCR values contained within the support
      * RIM.
+     *
      * @return a string array of the pcr values.
      */
     public String[] getExpectedPCRList() {
@@ -113,6 +114,7 @@ public class SupportReferenceManifest extends ReferenceManifest {
     /**
      * This is a method to indicate whether or not this support
      * rim is a base log file.
+     *
      * @return flag for base.
      */
     public boolean isBaseSupport() {
@@ -121,9 +123,15 @@ public class SupportReferenceManifest extends ReferenceManifest {
 
     @Override
     public boolean equals(Object o) {
-        if (this == o) return true;
+        if (this == o) {
-        if (o == null || getClass() != o.getClass()) return false;
+            return true;
-        if (!super.equals(o)) return false;
+        }
+        if (o == null || getClass() != o.getClass()) {
+            return false;
+        }
+        if (!super.equals(o)) {
+            return false;
+        }
         SupportReferenceManifest that = (SupportReferenceManifest) o;
         return pcrHash == that.pcrHash && updated == that.updated;
     }

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/enums/AppraisalStatus.java

@@ -9,6 +9,35 @@ import lombok.Setter;
 @Getter
 @Setter
 public class AppraisalStatus {
+    private Status appStatus;
+    private String message;
+    private String additionalInfo;
+
+    /**
+     * Default constructor. Set appraisal status and description.
+     *
+     * @param appStatus status of appraisal
+     * @param message   description of result
+     */
+    public AppraisalStatus(final Status appStatus, final String message) {
+        this(appStatus, message, "");
+    }
+
+    /**
+     * Default constructor. Set appraisal status and description.
+     *
+     * @param appStatus      status of appraisal
+     * @param message        description of result
+     * @param additionalInfo any additional information needed to
+     *                       be passed on
+     */
+    public AppraisalStatus(final Status appStatus, final String message,
+                           final String additionalInfo) {
+        this.appStatus = appStatus;
+        this.message = message;
+        this.additionalInfo = additionalInfo;
+    }
+
     /**
      * Enum used to represent appraisal status.
      */
@@ -33,31 +62,4 @@ public class AppraisalStatus {
          */
         UNKNOWN
     }
-
-    private Status appStatus;
-    private String message;
-    private String additionalInfo;
-
-    /**
-     * Default constructor. Set appraisal status and description.
-     * @param appStatus status of appraisal
-     * @param message description of result
-     */
-    public AppraisalStatus(final Status appStatus, final String message) {
-        this(appStatus, message, "");
-    }
-
-    /**
-     * Default constructor. Set appraisal status and description.
-     * @param appStatus status of appraisal
-     * @param message description of result
-     * @param additionalInfo any additional information needed to
-     *                       be passed on
-     */
-    public AppraisalStatus(final Status appStatus, final String message,
-                           final String additionalInfo) {
-        this.appStatus = appStatus;
-        this.message = message;
-        this.additionalInfo = additionalInfo;
-    }
 }

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/enums/HealthStatus.java

@@ -22,18 +22,24 @@ public enum HealthStatus {
      */
     UNKNOWN("unknown");
 
-    private String healthStatus;
+    private final String healthStatus;
 
     /**
      * Creates a new <code>HealthStatus</code> object given a String.
      *
-     * @param healthStatus
+     * @param healthStatus "trusted", "untrusted", or "unknown"
-     *            "trusted", "untrusted", or "unknown"
      */
     HealthStatus(final String healthStatus) {
         this.healthStatus = healthStatus;
     }
 
+    public static boolean isValidStatus(final String healthStatus) {
+        return Arrays.stream(HealthStatus.values())
+                .map(HealthStatus::name)
+                .collect(Collectors.toSet())
+                .contains(healthStatus);
+    }
+
     /**
      * Returns the health status.
      *
@@ -47,11 +53,4 @@ public enum HealthStatus {
     public String toString() {
         return getStatus();
     }
-
-    public static boolean isValidStatus(final String healthStatus) {
-        return Arrays.stream(HealthStatus.values())
-                .map(HealthStatus::name)
-                .collect(Collectors.toSet())
-                .contains(healthStatus);
-    }
 }

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/provision/AbstractProcessor.java

@@ -54,6 +54,7 @@ public class AbstractProcessor {
 
     /**
      * Default constructor that sets main class fields.
+     *
      * @param privateKey private key used for communication authentication
      * @param validDays  property value to set for issued certificates
      */
@@ -76,7 +77,8 @@ public class AbstractProcessor {
     protected X509Certificate generateCredential(final PublicKey publicKey,
                                                  final EndorsementCredential endorsementCredential,
                                                  final List<PlatformCredential> platformCredentials,
-                                       final String deviceName, final X509Certificate acaCertificate) {
+                                                 final String deviceName,
+                                                 final X509Certificate acaCertificate) {
         try {
             // have the certificate expire in the configured number of days
             Calendar expiry = Calendar.getInstance();
@@ -193,6 +195,7 @@ public class AbstractProcessor {
 
     /**
      * Gets the Endorsement Credential from the DB given the EK public key.
+     *
      * @param ekPublicKey           the EK public key
      * @param certificateRepository db store manager for certificates
      * @return the Endorsement credential, if found, otherwise null
@@ -260,23 +263,22 @@ public class AbstractProcessor {
                 policySettings = scp.findByName("Default");
 
                 Sort sortCriteria = Sort.by(Sort.Direction.DESC, "endValidity");
-                issuedAc = certificateRepository.findByDeviceIdAndIsLDevID(device.getId(), isLDevID, sortCriteria);
+                issuedAc = certificateRepository.findByDeviceIdAndIsLDevID(device.getId(), isLDevID,
+                        sortCriteria);
 
                 generateCertificate = isLDevID ? policySettings.isIssueDevIdCertificate()
                         : policySettings.isIssueAttestationCertificate();
 
-                if (issuedAc != null && issuedAc.size() > 0 && (isLDevID ? policySettings.isDevIdExpirationFlag()
+                if (issuedAc != null && issuedAc.size() > 0 &&
+                        (isLDevID ? policySettings.isDevIdExpirationFlag()
                                 : policySettings.isGenerateOnExpiration())) {
                     if (issuedAc.get(0).getEndValidity().after(currentDate)) {
                         // so the issued AC is not expired
                         // however are we within the threshold
                         days = ProvisionUtils.daysBetween(currentDate, issuedAc.get(0).getEndValidity());
-                        if (days < Integer.parseInt(isLDevID ? policySettings.getDevIdReissueThreshold()
+                        generateCertificate =
-                                : policySettings.getReissueThreshold())) {
+                                days < Integer.parseInt(isLDevID ? policySettings.getDevIdReissueThreshold()
-                            generateCertificate = true;
+                                        : policySettings.getReissueThreshold());
-                        } else {
-                            generateCertificate = false;
-                        }
                     }
                 }
             }

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/provision/CertificateRequestProcessor.java

@@ -30,14 +30,15 @@ import java.util.List;
 @Log4j2
 public class CertificateRequestProcessor extends AbstractProcessor {
 
-    private SupplyChainValidationService supplyChainValidationService;
+    private final SupplyChainValidationService supplyChainValidationService;
-    private CertificateRepository certificateRepository;
+    private final CertificateRepository certificateRepository;
-    private DeviceRepository deviceRepository;
+    private final DeviceRepository deviceRepository;
-    private X509Certificate acaCertificate;
+    private final X509Certificate acaCertificate;
-    private TPM2ProvisionerStateRepository tpm2ProvisionerStateRepository;
+    private final TPM2ProvisionerStateRepository tpm2ProvisionerStateRepository;
 
     /**
      * Constructor.
+     *
      * @param supplyChainValidationService   object that is used to run provisioning
      * @param certificateRepository          db connector for all certificates.
      * @param deviceRepository               database connector for Devices.
@@ -170,9 +171,11 @@ public class CertificateRequestProcessor extends AbstractProcessor {
                     ByteString ldevidCertificateBytes = ByteString
                             .copyFrom(derEncodedLdevidCertificate);
 
-                    boolean generateAtt = saveAttestationCertificate(certificateRepository, derEncodedAttestationCertificate,
+                    boolean generateAtt = saveAttestationCertificate(certificateRepository,
+                            derEncodedAttestationCertificate,
                             endorsementCredential, platformCredentials, device, false);
-                    boolean generateLDevID = saveAttestationCertificate(certificateRepository, derEncodedLdevidCertificate,
+                    boolean generateLDevID =
+                            saveAttestationCertificate(certificateRepository, derEncodedLdevidCertificate,
                                     endorsementCredential, platformCredentials, device, true);
 
                     ProvisionerTpm2.CertificateResponse.Builder builder = ProvisionerTpm2.CertificateResponse.
@@ -186,8 +189,7 @@ public class CertificateRequestProcessor extends AbstractProcessor {
                     ProvisionerTpm2.CertificateResponse response = builder.build();
 
                     return response.toByteArray();
-                }
+                } else {
-                else {
                     byte[] derEncodedAttestationCertificate = ProvisionUtils.getDerEncodedCertificate(
                             attestationCertificate);
 
@@ -200,7 +202,8 @@ public class CertificateRequestProcessor extends AbstractProcessor {
                     ProvisionerTpm2.CertificateResponse.Builder builder = ProvisionerTpm2.CertificateResponse.
                             newBuilder().setStatus(ProvisionerTpm2.ResponseStatus.PASS);
 
-                    boolean generateAtt = saveAttestationCertificate(certificateRepository, derEncodedAttestationCertificate,
+                    boolean generateAtt = saveAttestationCertificate(certificateRepository,
+                            derEncodedAttestationCertificate,
                             endorsementCredential, platformCredentials, device, false);
                     if (generateAtt) {
                         builder = builder.setCertificate(certificateBytes);
@@ -221,7 +224,7 @@ public class CertificateRequestProcessor extends AbstractProcessor {
             }
         } else {
             log.error("Could not process credential request. Invalid nonce provided: "
-                    + request.getNonce().toString());
+                    + request.getNonce());
             throw new CertificateProcessingException("Invalid nonce given in request by client.");
         }
     }

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/provision/helper/CredentialManagementHelper.java

@@ -22,6 +22,7 @@ public final class CredentialManagementHelper {
     /**
      * Parses and stores the EK in the cert manager. If the cert is already present and archived,
      * it is unarchived.
+     *
      * @param certificateRepository the certificate manager used for storage
      * @param endorsementBytes      the raw EK bytes used for parsing
      * @param deviceName            the host name
@@ -63,7 +64,7 @@ public final class CredentialManagementHelper {
         if (existingCredential == null) {
             log.info("No Endorsement Credential found with hash: " + certificateHash);
             endorsementCredential.setDeviceName(deviceName);
-            return (EndorsementCredential) certificateRepository.save(endorsementCredential);
+            return certificateRepository.save(endorsementCredential);
         } else if (existingCredential.isArchived()) {
             // if the EK is stored in the DB and it's archived, unarchive.
             log.info("Unarchiving credential");
@@ -77,6 +78,7 @@ public final class CredentialManagementHelper {
     /**
      * Parses and stores the PC in the cert manager. If the cert is already present and archived,
      * it is unarchived.
+     *
      * @param certificateRepository the certificate manager used for storage
      * @param platformBytes         the raw PC bytes used for parsing
      * @param deviceName            the host name of the associated machine
@@ -129,7 +131,7 @@ public final class CredentialManagementHelper {
                     }
                 }
                 platformCredential.setDeviceName(deviceName);
-                return (PlatformCredential) certificateRepository.save(platformCredential);
+                return certificateRepository.save(platformCredential);
             } else if (existingCredential.isArchived()) {
                 // if the PC is stored in the DB and it's archived, unarchive.
                 log.info("Unarchiving credential");

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/provision/helper/IssuedCertificateAttributeHelper.java

@@ -12,6 +12,7 @@ import org.bouncycastle.asn1.x500.AttributeTypeAndValue;
 import org.bouncycastle.asn1.x500.RDN;
 import org.bouncycastle.asn1.x500.X500Name;
 import org.bouncycastle.asn1.x500.X500NameBuilder;
+import org.bouncycastle.asn1.x509.AttributeCertificateInfo;
 import org.bouncycastle.asn1.x509.AuthorityKeyIdentifier;
 import org.bouncycastle.asn1.x509.ExtendedKeyUsage;
 import org.bouncycastle.asn1.x509.Extension;
@@ -21,7 +22,6 @@ import org.bouncycastle.asn1.x509.GeneralNames;
 import org.bouncycastle.asn1.x509.GeneralNamesBuilder;
 import org.bouncycastle.asn1.x509.KeyPurposeId;
 import org.bouncycastle.asn1.x509.TBSCertificate;
-import org.bouncycastle.asn1.x509.AttributeCertificateInfo;
 
 import java.io.IOException;
 import java.security.cert.CertificateEncodingException;
@@ -35,17 +35,16 @@ import java.util.Collection;
 @Log4j2
 public final class IssuedCertificateAttributeHelper {
 
+    /**
+     * The extended key usage extension.
+     */
+    public static final Extension EXTENDED_KEY_USAGE_EXTENSION;
     private static final String TPM_ID_LABEL_OID = "2.23.133.2.15";
-
     /**
      * Object Identifier TCPA at TPM ID Label.
      */
     public static final ASN1ObjectIdentifier TCPA_AT_TPM_ID_LABEL =
             new ASN1ObjectIdentifier(TPM_ID_LABEL_OID);
-    /**
-     * The extended key usage extension.
-     */
-    public static final Extension EXTENDED_KEY_USAGE_EXTENSION;
     private static final ASN1ObjectIdentifier TCG_KP_AIK_CERTIFICATE_ATTRIBUTE =
             new ASN1ObjectIdentifier("2.23.133.8.3");
 
@@ -69,6 +68,7 @@ public final class IssuedCertificateAttributeHelper {
     /**
      * This method builds the AKI extension that will be stored in the generated
      * Attestation Issued Certificate.
+     *
      * @param endorsementCredential EK object to pull AKI from.
      * @return the AKI extension.
      * @throws IOException on bad get instance for AKI.
@@ -93,6 +93,7 @@ public final class IssuedCertificateAttributeHelper {
 
     /**
      * Builds the subject alternative name based on the supplied certificates.
+     *
      * @param endorsementCredential the endorsement credential
      * @param platformCredentials   the platform credentials
      * @param hostName              the host name
@@ -178,14 +179,11 @@ public final class IssuedCertificateAttributeHelper {
                 populateRdnAttributesInNameBuilder(nameBuilder, rdns);
             } else {
                 log.error("No RDNs in endorsement credential attributes");
-                return;
             }
         } catch (CertificateEncodingException e) {
             log.error("Certificate encoding exception", e);
-            return;
         } catch (IOException e) {
             log.error("Error creating x509 cert from endorsement credential", e);
-            return;
         }
 
     }

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/provision/helper/ProvisionUtils.java

@@ -3,7 +3,6 @@ package hirs.attestationca.persist.provision.helper;
 import com.google.protobuf.ByteString;
 import com.google.protobuf.InvalidProtocolBufferException;
 import hirs.attestationca.configuration.provisionerTpm2.ProvisionerTpm2;
-import hirs.attestationca.persist.entity.userdefined.info.TPMInfo;
 import hirs.attestationca.persist.exceptions.CertificateProcessingException;
 import hirs.attestationca.persist.exceptions.IdentityProcessingException;
 import hirs.attestationca.persist.exceptions.UnexpectedServerException;
@@ -14,7 +13,6 @@ import hirs.structs.elements.tpm.IdentityRequest;
 import hirs.structs.elements.tpm.SymmetricKey;
 import hirs.structs.elements.tpm.SymmetricKeyParams;
 import hirs.utils.HexUtils;
-import hirs.utils.enums.DeviceInfoEnums;
 import lombok.extern.log4j.Log4j2;
 import org.apache.commons.codec.binary.Hex;
 import org.apache.commons.lang3.ArrayUtils;
@@ -54,16 +52,16 @@ public final class ProvisionUtils {
      * The default size for IV blocks.
      */
     public final static int DEFAULT_IV_SIZE = 16;
-    /**
-     * Defines the well known exponent.
-     * https://en.wikipedia.org/wiki/65537_(number)#Applications
-     */
-    private final static BigInteger EXPONENT = new BigInteger("010001", DEFAULT_IV_SIZE);
     public static final int HMAC_SIZE_LENGTH_BYTES = 2;
     public static final int HMAC_KEY_LENGTH_BYTES = 32;
     public static final int SEED_LENGTH = 32;
     public static final int MAX_SECRET_LENGTH = 32;
     public static final int AES_KEY_LENGTH_BYTES = 16;
+    /**
+     * Defines the well known exponent.
+     * https://en.wikipedia.org/wiki/65537_(number)#Applications
+     */
+    private final static BigInteger EXPONENT = new BigInteger("010001", DEFAULT_IV_SIZE);
     private static final int TPM2_CREDENTIAL_BLOB_SIZE = 392;
     private static final int RSA_MODULUS_LENGTH = 256;
     // Constants used to parse out the ak name from the ak public data. Used in generateAkName
@@ -77,8 +75,8 @@ public final class ProvisionUtils {
      *
      * @param identityClaim byte array that should be converted to a Protobuf IdentityClaim
      *                      object
-     * @throws {@link IdentityProcessingException} if byte array could not be parsed
      * @return the Protobuf generated Identity Claim object
+     * @throws {@link IdentityProcessingException} if byte array could not be parsed
      */
     public static ProvisionerTpm2.IdentityClaim parseIdentityClaim(final byte[] identityClaim) {
         try {
@@ -93,8 +91,8 @@ public final class ProvisionUtils {
      * Helper method to extract a DER encoded ASN.1 certificate from an X509 certificate.
      *
      * @param certificate the X509 certificate to be converted to DER encoding
-     * @throws {@link UnexpectedServerException} if error occurs during encoding retrieval
      * @return the byte array representing the DER encoded certificate
+     * @throws {@link UnexpectedServerException} if error occurs during encoding retrieval
      */
     public static byte[] getDerEncodedCertificate(final X509Certificate certificate) {
         try {
@@ -109,6 +107,7 @@ public final class ProvisionUtils {
 
     /**
      * Parse public key from public data segment generated by TPM 2.0.
+     *
      * @param publicArea the public area segment to parse
      * @return the RSA public key of the supplied public data
      */
@@ -128,8 +127,7 @@ public final class ProvisionUtils {
     /**
      * Constructs a public key where the modulus is in raw form.
      *
-     * @param modulus
+     * @param modulus in byte array form
-     *            in byte array form
      * @return public key using specific modulus and the well known exponent
      */
     public static PublicKey assemblePublicKey(final byte[] modulus) {
@@ -139,8 +137,7 @@ public final class ProvisionUtils {
     /**
      * Constructs a public key where the modulus is Hex encoded.
      *
-     * @param modulus
+     * @param modulus hex encoded modulus
-     *            hex encoded modulus
      * @return public key using specific modulus and the well known exponent
      */
     public static PublicKey assemblePublicKey(final String modulus) {
@@ -261,7 +258,7 @@ public final class ProvisionUtils {
      * key to generate an HMAC to cover the encrypted secret and the ak name. The output is an
      * encrypted blob that acts as the first part of a challenge-response authentication mechanism
      * to validate an identity claim.
-     *
+     * <p>
      * Equivalent to calling tpm2_makecredential using tpm2_tools.
      *
      * @param ek     endorsement key in the identity claim
@@ -284,7 +281,8 @@ public final class ProvisionUtils {
             // encrypt seed with pubEk
             Cipher asymCipher = Cipher.getInstance("RSA/ECB/OAEPWithSHA-256AndMGF1Padding");
             OAEPParameterSpec oaepSpec = new OAEPParameterSpec("SHA-256", "MGF1",
-                    MGF1ParameterSpec.SHA256, new PSource.PSpecified("IDENTITY\0".getBytes(StandardCharsets.UTF_8)));
+                    MGF1ParameterSpec.SHA256,
+                    new PSource.PSpecified("IDENTITY\0".getBytes(StandardCharsets.UTF_8)));
             asymCipher.init(Cipher.PUBLIC_KEY, ek, oaepSpec);
             asymCipher.update(seed);
             byte[] encSeed = asymCipher.doFinal();
@@ -503,6 +501,7 @@ public final class ProvisionUtils {
 
     /**
      * Determines the AK name from the AK Modulus.
+     *
      * @param akModulus modulus of an attestation key
      * @return the ak name byte array
      * @throws java.security.NoSuchAlgorithmException Underlying SHA256 method used a bad algorithm
@@ -543,7 +542,7 @@ public final class ProvisionUtils {
         byte[] counter = b.array();
         // get the label
         String labelWithEnding = label;
-        if (label.charAt(label.length() - 1) != "\0".charAt(0)) {
+        if (label.charAt(label.length() - 1) != '\u0000') {
             labelWithEnding = label + "\0";
         }
         byte[] labelBytes = labelWithEnding.getBytes(StandardCharsets.UTF_8);
@@ -580,6 +579,7 @@ public final class ProvisionUtils {
     /**
      * This method takes the provided TPM Quote and splits it between the PCR
      * quote and the signature hash.
+     *
      * @param tpmQuote contains hash values for the quote and the signature
      */
     public static String parseTPMQuoteHash(final String tpmQuote) {
@@ -598,6 +598,7 @@ public final class ProvisionUtils {
     /**
      * This method takes the provided TPM Quote and splits it between the PCR
      * quote and the signature hash.
+     *
      * @param tpmQuote contains hash values for the quote and the signature
      */
     public static String parseTPMQuoteSignature(final String tpmQuote) {
@@ -612,6 +613,7 @@ public final class ProvisionUtils {
 
     /**
      * Computes the sha256 hash of the given blob.
+     *
      * @param blob byte array to take the hash of
      * @return sha256 hash of blob
      * @throws NoSuchAlgorithmException improper algorithm selected
@@ -625,8 +627,7 @@ public final class ProvisionUtils {
     /**
      * Generates a array of random bytes.
      *
-     * @param numberOfBytes
+     * @param numberOfBytes to be generated
-     *            to be generated
      * @return byte array filled with the specified number of bytes.
      */
     public static byte[] generateRandomBytes(final int numberOfBytes) {

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/service/ValidationService.java

@@ -18,7 +18,6 @@ import hirs.attestationca.persist.entity.userdefined.certificate.PlatformCredent
 import hirs.attestationca.persist.entity.userdefined.info.ComponentInfo;
 import hirs.attestationca.persist.entity.userdefined.report.DeviceInfoReport;
 import hirs.attestationca.persist.enums.AppraisalStatus;
-import hirs.attestationca.persist.validation.CertificateAttributeScvValidator;
 import hirs.attestationca.persist.validation.CredentialValidator;
 import hirs.attestationca.persist.validation.FirmwareScvValidator;
 import hirs.utils.BouncyCastleUtils;
@@ -318,7 +317,8 @@ public class ValidationService {
                 certAuthsWithMatchingIssuer = caCredentialRepository.findBySubject(credential.getIssuer());
             } else {
                 //Get certificates by subject organization
-                certAuthsWithMatchingIssuer = caCredentialRepository.findBySubjectSorted(credential.getIssuerSorted());
+                certAuthsWithMatchingIssuer =
+                        caCredentialRepository.findBySubjectSorted(credential.getIssuerSorted());
             }
         } else {
             certAuthsWithMatchingIssuer.add(skiCA);

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/service/selector/CertificateSelector.java

@@ -24,7 +24,7 @@ import java.util.UUID;
  * This class is used to select one or many certificates in conjunction
  * with a {@link }.  To make use of this object,
  * use (some CertificateImpl).select(CertificateManager).
- *
+ * <p>
  * This class loosely follows the builder pattern.  It is instantiated with
  * the type of certificate that should be retrieved.  It is possible to
  * further specify which certificate(s) should be retrieved by using an
@@ -32,10 +32,10 @@ import java.util.UUID;
  * restrict the result set.  At any time, the results may be retrieved
  * by using one of the get* methods according to the form the
  * results should be in.
- *
+ * <p>
  * If no matching certificates were found for the query, the returned
  * value may empty or null, depending on the return type.
- *
+ * <p>
  * For example, to retrieve all platform certificates:
  *
  * <pre>
@@ -45,7 +45,7 @@ import java.util.UUID;
  *      .getCertificates();
  * }
  * </pre>
- *
+ * <p>
  * To retrieve all CA certificates in a KeyStore:
  *
  * <pre>
@@ -55,7 +55,7 @@ import java.util.UUID;
  *      .getKeyStore();
  * }
  * </pre>
- *
+ * <p>
  * To retrieve all CA certificates matching a certain issuer in X509 format:
  *
  * <pre>
@@ -105,6 +105,7 @@ public abstract class CertificateSelector<T extends Certificate> {
         this.fieldValueSelections = new HashMap<>();
         this.excludeArchivedCertificates = excludeArchivedCertificates;
     }
+
     /**
      * Specify the entity id that certificates must have to be considered
      * as matching.
@@ -249,6 +250,7 @@ public abstract class CertificateSelector<T extends Certificate> {
 
     /**
      * Specify the authority key identifier to find certificate(s).
+     *
      * @param authorityKeyIdentifier the string of the AKI associated with the certificate.
      * @return this instance
      */
@@ -307,8 +309,7 @@ public abstract class CertificateSelector<T extends Certificate> {
             );
         }
 
-        if (value instanceof byte[]) {
+        if (value instanceof byte[] valueBytes) {
-            byte[] valueBytes = (byte[]) value;
 
             Preconditions.checkArgument(
                     ArrayUtils.isNotEmpty(valueBytes),
@@ -359,7 +360,8 @@ public abstract class CertificateSelector<T extends Certificate> {
 
         int i = 0;
         for (Map.Entry<String, Object> fieldValueEntry : fieldValueSelections.entrySet()) {
-            predicates[i++] = criteriaBuilder.equal(root.get(fieldValueEntry.getKey()), fieldValueEntry.getValue());
+            predicates[i++] =
+                    criteriaBuilder.equal(root.get(fieldValueEntry.getKey()), fieldValueEntry.getValue());
         }
 
         if (this.excludeArchivedCertificates) {
@@ -378,6 +380,7 @@ public abstract class CertificateSelector<T extends Certificate> {
 
     /**
      * Configures the selector to query for archived and unarchived certificates.
+     *
      * @return the selector
      */
     public CertificateSelector<T> includeArchived() {

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/service/selector/ReferenceManifestSelector.java

@@ -12,9 +12,7 @@ import org.apache.commons.lang3.StringUtils;
 
 import java.util.Arrays;
 import java.util.HashMap;
-import java.util.List;
 import java.util.Map;
-import java.util.Set;
 import java.util.UUID;
 
 /**
@@ -88,6 +86,7 @@ public abstract class ReferenceManifestSelector<T extends ReferenceManifest> {
 
     /**
      * Specify the file name of the object to grab.
+     *
      * @param fileName the name of the file associated with the rim
      * @return instance of the manifest in relation to the filename.
      */
@@ -98,6 +97,7 @@ public abstract class ReferenceManifestSelector<T extends ReferenceManifest> {
 
     /**
      * Specify the RIM Type to match.
+     *
      * @param rimType the type of rim
      * @return this instance
      */
@@ -127,8 +127,7 @@ public abstract class ReferenceManifestSelector<T extends ReferenceManifest> {
             );
         }
 
-        if (value instanceof byte[]) {
+        if (value instanceof byte[] valueBytes) {
-            byte[] valueBytes = (byte[]) value;
 
             Preconditions.checkArgument(
                     ArrayUtils.isNotEmpty(valueBytes),
@@ -155,7 +154,8 @@ public abstract class ReferenceManifestSelector<T extends ReferenceManifest> {
 
         int i = 0;
         for (Map.Entry<String, Object> fieldValueEntry : fieldValueSelections.entrySet()) {
-            predicates[i++] = criteriaBuilder.equal(root.get(fieldValueEntry.getKey()), fieldValueEntry.getValue());
+            predicates[i++] =
+                    criteriaBuilder.equal(root.get(fieldValueEntry.getKey()), fieldValueEntry.getValue());
         }
 
         if (this.excludeArchivedRims) {

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/tpm/PcrComposite.java

@@ -39,7 +39,6 @@ import java.util.List;
  *     </hash>
  *   </PcrValue>
  * </pre>
- *
  */
 @Log4j2
 @XmlAccessorType(XmlAccessType.FIELD)
@@ -69,11 +68,9 @@ public class PcrComposite {
     /**
      * Constructor used to create a PcrComposite object.
      *
-     * @param pcrSelection
+     * @param pcrSelection {@link PcrSelection } object, identifies which TPM PCRs are
-     *            {@link PcrSelection } object, identifies which TPM PCRs are
      *                     quoted
-     * @param pcrValueList
+     * @param pcrValueList List of TPMMeasurementRecords representing the PCR values
-     *            List of TPMMeasurementRecords representing the PCR values
      */
     public PcrComposite(final PcrSelection pcrSelection,
                         final List<TPMMeasurementRecord> pcrValueList) {
@@ -90,13 +87,11 @@ public class PcrComposite {
     }
 
 
-
     /**
      * Gets the value of the valueSize property, the length in bytes of the
      * array of PcrValue complex types.
      *
      * @return int value representing the valueSize
-     *
      */
     @XmlElement(name = "ValueSize", required = true)
     public final int getValueSize() {

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/tpm/PcrInfoShort.java

@@ -77,16 +77,12 @@ public class PcrInfoShort {
     /**
      * Constructor used to create a PcrInfoShort object.
      *
-     * @param pcrSelection
+     * @param pcrSelection      PcrSelection defines which TPM PCRs are used in the TPM Quote.
-     *            PcrSelection defines which TPM PCRs are used in the TPM Quote.
+     * @param localityAtRelease short value includes locality information to provide the
-     * @param localityAtRelease
-     *            short value includes locality information to provide the
      *                          requestor a more complete view of the current platform
      *                          configuration
-     * @param compositeHash
+     * @param compositeHash     A hash of PcrComposite
-     *            A hash of PcrComposite
+     * @param pcrComposite      A structure containing the actual values of the PCRs quoted.
-     * @param pcrComposite
-     *            A structure containing the actual values of the PCRs quoted.
      */
     public PcrInfoShort(final PcrSelection pcrSelection,
                         final short localityAtRelease, final byte[] compositeHash,
@@ -126,8 +122,7 @@ public class PcrInfoShort {
      * collected PCR values match the digest in the quote.
      *
      * @return byte array containing the digest
-     * @throws NoSuchAlgorithmException
+     * @throws NoSuchAlgorithmException if MessageDigest doesn't recognize "SHA-1" or "SHA-256"
-     *             if MessageDigest doesn't recognize "SHA-1" or "SHA-256"
      */
     public final byte[] getCalculatedDigest() throws NoSuchAlgorithmException {
         if (this.isTpm1()) {

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/tpm/PcrSelection.java

@@ -6,7 +6,6 @@ import jakarta.xml.bind.annotation.XmlAccessorType;
 import jakarta.xml.bind.annotation.XmlAttribute;
 import jakarta.xml.bind.annotation.XmlSchemaType;
 import jakarta.xml.bind.annotation.XmlType;
-import lombok.extern.java.Log;
 import lombok.extern.log4j.Log4j2;
 
 import java.nio.ByteBuffer;
@@ -27,12 +26,11 @@ import java.util.Arrays;
 @Embeddable
 public class PcrSelection {
 
-    private static final int MAX_SIZE_PCR_ARRAY = 3;
     /**
      * All PCRs are on.
      */
     public static final int ALL_PCRS_ON = 0xffffff;
-
+    private static final int MAX_SIZE_PCR_ARRAY = 3;
     @XmlAttribute(name = "PcrSelect", required = true)
     private final byte[] pcrSelect;
 
@@ -50,9 +48,7 @@ public class PcrSelection {
      * Each byte represents 8 PCRs. Byte 0 indicates PCRs 0-7, byte 1 8-15 and
      * so on. For each byte, the individual bits represent a corresponding PCR.
      *
-     * @param pcrSelect
+     * @param pcrSelect byte array indicating which PCRS are selected
-     *            byte array indicating which PCRS are selected
-     *
      */
     public PcrSelection(final byte[] pcrSelect) {
         if (pcrSelect == null) {
@@ -74,8 +70,7 @@ public class PcrSelection {
      * selection value. For example, to select the first 3 PCRs, one would use
      * the long value 7 (b0000 0000 0000 0111).
      *
-     * @param pcrSelectLong
+     * @param pcrSelectLong long value representing the bits to be selected
-     *            long value representing the bits to be selected
      */
     public PcrSelection(final long pcrSelectLong) {
         if (pcrSelectLong > ALL_PCRS_ON) {

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/type/InetAddressType.java

@@ -72,19 +72,13 @@ public final class InetAddressType implements UserType {
      * Converts the IP address that is stored as a <code>String</code> and
      * converts it to an <code>InetAddress</code>.
      *
-     * @param rs
+     * @param rs      result set
-     *            result set
+     * @param index   column names
-     * @param index
+     * @param session session
-     *            column names
+     * @param owner   owner
-     * @param session
-     *            session
-     * @param owner
-     *            owner
      * @return InetAddress of String
-     * @throws HibernateException
+     * @throws HibernateException if unable to convert the String to an InetAddress
-     *             if unable to convert the String to an InetAddress
+     * @throws SQLException       if unable to retrieve the String from the result set
-     * @throws SQLException
-     *             if unable to retrieve the String from the result set
      */
     @Override
     public Object nullSafeGet(final ResultSet rs, final int index,

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/type/X509CertificateType.java

@@ -73,19 +73,13 @@ public final class X509CertificateType implements UserType {
      * Converts the X509Certificate that is stored as a <code>String</code> and
      * converts it to an <code>X509Certificate</code>.
      *
-     * @param rs
+     * @param rs      result set
-     *            result set
+     * @param names   column names
-     * @param names
+     * @param session session
-     *            column names
+     * @param owner   owner
-     * @param session
-     *            session
-     * @param owner
-     *            owner
      * @return X509Certificate of String
-     * @throws HibernateException
+     * @throws HibernateException if unable to convert the String to an X509Certificate
-     *             if unable to convert the String to an X509Certificate
+     * @throws SQLException       if unable to retrieve the String from the result set
-     * @throws SQLException
-     *             if unable to retrieve the String from the result set
      */
     @Override
     public Object nullSafeGet(final ResultSet rs, final int names,
@@ -131,7 +125,7 @@ public final class X509CertificateType implements UserType {
             } catch (Exception e) {
                 final String msg =
                         String.format("unable to convert certificate: %s",
-                                value.toString());
+                                value);
                 throw new HibernateException(msg, e);
             }
         }

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/util/AcaPciIds.java

@@ -3,7 +3,6 @@ package hirs.attestationca.persist.util;
 import hirs.attestationca.persist.entity.userdefined.certificate.ComponentResult;
 import hirs.attestationca.persist.entity.userdefined.certificate.attributes.ComponentIdentifier;
 import hirs.attestationca.persist.entity.userdefined.certificate.attributes.V2.ComponentIdentifierV2;
-
 import lombok.extern.log4j.Log4j2;
 import org.bouncycastle.asn1.DERUTF8String;
 
@@ -35,6 +34,7 @@ public final class AcaPciIds {
     /**
      * Iterate through all components and translate PCI hardware IDs as necessary.  It will only
      * translate ComponentIdentifierV2+ objects as it relies on Component Class information.
+     *
      * @param components List of ComponentIdentifiers.
      * @return the translated list of ComponentIdentifiers.
      */
@@ -58,6 +58,7 @@ public final class AcaPciIds {
     /**
      * Iterate through all components and translate PCI hardware IDs as necessary.  It will only
      * translate ComponentResults objects as it relies on Component Class information.
+     *
      * @param componentResults List of ComponentResults.
      * @return the translated list of ComponentResults.
      */
@@ -75,6 +76,7 @@ public final class AcaPciIds {
     /**
      * Translate Vendor and Device IDs, if found, in ComponentIdentifierV2 objects.
      * It will only translate ID values, any other value will pass through.
+     *
      * @param component ComponentIdentifierV2 object.
      * @return the translated ComponentIdentifierV2 object.
      */
@@ -113,6 +115,7 @@ public final class AcaPciIds {
     /**
      * Translate Vendor and Device IDs, if found, in ComponentResult objects.
      * It will only translate ID values, any other value will pass through.
+     *
      * @param componentResult ComponentResult object.
      * @return the translated ComponentResult object.
      */

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/util/CredentialHelper.java

@@ -1,8 +1,6 @@
 package hirs.attestationca.persist.util;
 
 import hirs.attestationca.persist.entity.userdefined.certificate.CertificateVariables;
-import lombok.AccessLevel;
-import lombok.NoArgsConstructor;
 import lombok.extern.log4j.Log4j2;
 import org.bouncycastle.util.encoders.Base64;
 
@@ -17,6 +15,7 @@ public final class CredentialHelper {
 
     /**
      * Small method to check if the certificate is a PEM.
+     *
      * @param possiblePEM header information
      * @return true if it is.
      */
@@ -27,6 +26,7 @@ public final class CredentialHelper {
 
     /**
      * Small method to check if there are multi pem files
+     *
      * @param possiblePEM header information
      * @return true if it is.
      */
@@ -45,6 +45,7 @@ public final class CredentialHelper {
 
     /**
      * Method to remove header footer information from PEM
+     *
      * @param pemFile string representation of the file
      * @return a cleaned up raw byte object
      */
@@ -59,6 +60,7 @@ public final class CredentialHelper {
 
     /**
      * The method is used to remove unwanted spaces and other artifacts from the certificate.
+     *
      * @param certificateBytes raw byte form
      * @return a cleaned up byte form
      */
@@ -112,6 +114,7 @@ public final class CredentialHelper {
 
     /**
      * Return the string associated with the boolean slot.
+     *
      * @param bit associated with the location in the array.
      * @return string value of the bit set.
      */
@@ -157,6 +160,7 @@ public final class CredentialHelper {
      * This method is to take the DNs from certificates and sort them in an order
      * that will be used to lookup issuer certificates.  This will not be stored in
      * the certificate, just the DB for lookup.
+     *
      * @param distinguishedName the original DN string.
      * @return a modified string of sorted DNs
      */

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/validation/CredentialValidator.java

@@ -163,6 +163,7 @@ public class CredentialValidator extends SupplyChainCredentialValidator {
 
     /**
      * Checks if the platform credential's attributes are valid.
+     *
      * @param platformCredential           The platform credential to verify.
      * @param deviceInfoReport             The device info report containing
      *                                     serial number of the platform to be validated.
@@ -223,6 +224,7 @@ public class CredentialValidator extends SupplyChainCredentialValidator {
 
     /**
      * Checks if the delta credential's attributes are valid.
+     *
      * @param deviceInfoReport             The device info report containing
      *                                     serial number of the platform to be validated.
      * @param basePlatformCredential       the base credential from the same identity request

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/validation/PcrValidator.java

@@ -63,13 +63,38 @@ public class PcrValidator {
      */
     public PcrValidator(final String[] pcrValues) {
         baselinePcrs = new String[TPMMeasurementRecord.MAX_PCR_ID + 1];
-        for (int i = 0; i <= TPMMeasurementRecord.MAX_PCR_ID; i++) {
+        System.arraycopy(pcrValues, 0, baselinePcrs, 0, TPMMeasurementRecord.MAX_PCR_ID + 1);
-            baselinePcrs[i] = pcrValues[i];
     }
+
+    public static String[] buildStoredPcrs(final String pcrContent, final int algorithmLength) {
+        // we have a full set of PCR values
+        String[] pcrSet = pcrContent.split("\\n");
+        String[] storedPcrs = new String[TPMMeasurementRecord.MAX_PCR_ID + 1];
+
+        // we need to scroll through the entire list until we find
+        // a matching hash length
+        int offset = 1;
+
+        for (int i = 0; i < pcrSet.length; i++) {
+            if (pcrSet[i].contains("sha")) {
+                // entered a new set, check size
+                if (pcrSet[i + offset].split(":")[1].trim().length()
+                        == algorithmLength) {
+                    // found the matching set
+                    for (int j = 0; j <= TPMMeasurementRecord.MAX_PCR_ID; j++) {
+                        storedPcrs[j] = pcrSet[++i].split(":")[1].trim();
+                    }
+                    break;
+                }
+            }
+        }
+
+        return storedPcrs;
     }
 
     /**
      * Getter for the array of baseline PCRs.
+     *
      * @return instance of the PCRs.
      */
     public String[] getBaselinePcrs() {
@@ -78,6 +103,7 @@ public class PcrValidator {
 
     /**
      * Setter for the array of baseline PCRs.
+     *
      * @param baselinePcrs instance of the PCRs.
      */
     public void setBaselinePcrs(final String[] baselinePcrs) {
@@ -128,6 +154,7 @@ public class PcrValidator {
     /**
      * Checks that the expected FM events occurring. There are policy options that
      * will ignore certin PCRs, Event Types and Event Variables present.
+     *
      * @param tcgMeasurementLog Measurement log from the client
      * @param eventValueMap     The events stored as baseline to compare
      * @param policySettings    db entity that holds all of policy
@@ -230,30 +257,4 @@ public class PcrValidator {
 
         return validated;
     }
-
-    public static String[] buildStoredPcrs(final String pcrContent, final int algorithmLength) {
-        // we have a full set of PCR values
-        String[] pcrSet = pcrContent.split("\\n");
-        String[] storedPcrs = new String[TPMMeasurementRecord.MAX_PCR_ID + 1];
-
-        // we need to scroll through the entire list until we find
-        // a matching hash length
-        int offset = 1;
-
-        for (int i = 0; i < pcrSet.length; i++) {
-            if (pcrSet[i].contains("sha")) {
-                // entered a new set, check size
-                if (pcrSet[i + offset].split(":")[1].trim().length()
-                        == algorithmLength) {
-                    // found the matching set
-                    for (int j = 0; j <= TPMMeasurementRecord.MAX_PCR_ID; j++) {
-                        storedPcrs[j] = pcrSet[++i].split(":")[1].trim();
-                    }
-                    break;
-                }
-            }
-        }
-
-        return storedPcrs;
-    }
 }

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/validation/SupplyChainCredentialValidator.java

@@ -78,13 +78,10 @@ public class SupplyChainCredentialValidator  {
      * continue to try to find the signing cert of the intermediate cert. It will continue searching
      * until it follows the chain up to a root (self-signed) cert.
      *
-     * @param cert
+     * @param cert       certificate to validate
-     *            certificate to validate
+     * @param trustStore trust store holding trusted root certificates and intermediate certificates
-     * @param trustStore
-     *            trust store holding trusted root certificates and intermediate certificates
      * @return the certificate chain if validation is successful
-     * @throws SupplyChainValidatorException
+     * @throws SupplyChainValidatorException if the verification is not successful
-     *             if the verification is not successful
      */
     public static String verifyCertificate(final X509AttributeCertificateHolder cert,
                                            final KeyStore trustStore) throws SupplyChainValidatorException {
@@ -122,13 +119,10 @@ public class SupplyChainCredentialValidator  {
      * continue to try to find the signing cert of the intermediate cert. It will continue searching
      * until it follows the chain up to a root (self-signed) cert.
      *
-     * @param cert
+     * @param cert       certificate to validate
-     *            certificate to validate
+     * @param trustStore trust store holding trusted root certificates and intermediate certificates
-     * @param trustStore
-     *            trust store holding trusted root certificates and intermediate certificates
      * @return the certificate chain if validation is successful
-     * @throws SupplyChainValidatorException
+     * @throws SupplyChainValidatorException if the verification is not successful
-     *             if the verification is not successful
      */
     public static boolean verifyCertificate(final X509Certificate cert,
                                             final KeyStore trustStore) throws SupplyChainValidatorException {
@@ -164,10 +158,8 @@ public class SupplyChainCredentialValidator  {
      * to find the signing cert of the intermediate cert. It will continue searching until it
      * follows the chain up to a root (self-signed) cert.
      *
-     * @param cert
+     * @param cert            certificate to validate
-     *            certificate to validate
+     * @param additionalCerts Set of certs to validate against
-     * @param additionalCerts
-     *            Set of certs to validate against
      * @return String status of the cert chain validation -
      * blank if successful, error message otherwise
      * @throws SupplyChainValidatorException tried to validate using null certificates
@@ -227,10 +219,8 @@ public class SupplyChainCredentialValidator  {
      * to find the signing cert of the intermediate cert. It will continue searching until it
      * follows the chain up to a root (self-signed) cert.
      *
-     * @param cert
+     * @param cert            certificate to validate
-     *            certificate to validate
+     * @param additionalCerts Set of certs to validate against
-     * @param additionalCerts
-     *            Set of certs to validate against
      * @return String status of the cert chain validation -
      * blank if successful, error message otherwise
      * @throws SupplyChainValidatorException tried to validate using null certificates
@@ -277,6 +267,7 @@ public class SupplyChainCredentialValidator  {
 
     /**
      * Parses the output from PACCOR's allcomponents.sh script into ComponentInfo objects.
+     *
      * @param hostName     the host machine associated with the component
      * @param paccorOutput the output from PACCOR's allcomoponents.sh
      * @return a list of ComponentInfo objects built from paccorOutput
@@ -333,10 +324,8 @@ public class SupplyChainCredentialValidator  {
      * Checks if the issuer info of an attribute cert matches the supposed signing cert's
      * distinguished name.
      *
-     * @param cert
+     * @param cert        the attribute certificate with the signature to validate
-     *            the attribute certificate with the signature to validate
+     * @param signingCert the certificate with the public key to validate
-     * @param signingCert
-     *            the certificate with the public key to validate
      * @return boolean indicating if the names
      * @throws SupplyChainValidatorException tried to validate using null certificates
      */
@@ -359,10 +348,8 @@ public class SupplyChainCredentialValidator  {
      * Checks if the issuer info of a public-key cert matches the supposed signing cert's
      * distinguished name.
      *
-     * @param cert
+     * @param cert        the public-key certificate with the signature to validate
-     *            the public-key certificate with the signature to validate
+     * @param signingCert the certificate with the public key to validate
-     * @param signingCert
-     *            the certificate with the public key to validate
      * @return boolean indicating if the names
      * @throws SupplyChainValidatorException tried to validate using null certificates
      */
@@ -387,10 +374,8 @@ public class SupplyChainCredentialValidator  {
      * Checks if the signature of an attribute cert is validated against the signing cert's public
      * key.
      *
-     * @param cert
+     * @param cert        the public-key certificate with the signature to validate
-     *            the public-key certificate with the signature to validate
+     * @param signingCert the certificate with the public key to validate
-     * @param signingCert
-     *            the certificate with the public key to validate
      * @return boolean indicating if the validation passed
      * @throws SupplyChainValidatorException tried to validate using null certificates
      */
@@ -423,10 +408,8 @@ public class SupplyChainCredentialValidator  {
      * Checks if the signature of a public-key cert is validated against the signing cert's public
      * key.
      *
-     * @param cert
+     * @param cert        the attribute certificate with the signature to validate
-     *            the attribute certificate with the signature to validate
+     * @param signingCert the certificate with the public key to validate
-     * @param signingCert
-     *            the certificate with the public key to validate
      * @return boolean indicating if the validation passed
      * @throws SupplyChainValidatorException tried to validate using null certificates
      */
@@ -442,10 +425,8 @@ public class SupplyChainCredentialValidator  {
     /**
      * Checks if an X509 Attribute Certificate is valid directly against a public key.
      *
-     * @param cert
+     * @param cert       the attribute certificate with the signature to validate
-     *            the attribute certificate with the signature to validate
+     * @param signingKey the key to use to check the attribute cert
-     * @param signingKey
-     *            the key to use to check the attribute cert
      * @return boolean indicating if the validation passed
      * @throws SupplyChainValidatorException tried to validate using null certificates
      */
@@ -472,8 +453,7 @@ public class SupplyChainCredentialValidator  {
      * Checks whether given X.509 public-key certificate is self-signed. If the cert can be
      * verified using its own public key, that means it was self-signed.
      *
-     * @param cert
+     * @param cert X.509 Certificate
-     *            X.509 Certificate
      * @return boolean indicating if the cert was self-signed
      */
     private static boolean isSelfSigned(final X509Certificate cert)

HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/validation/SupplyChainValidatorException.java

@@ -11,10 +11,8 @@ public class SupplyChainValidatorException extends Exception {
      * Creates a new <code>SupplyChainValidatorException</code> that has the message
      * <code>message</code> and <code>Throwable</code> cause <code>cause</code>.
      *
-     * @param message
+     * @param message exception message
-     *            exception message
+     * @param cause   root cause
-     * @param cause
-     *            root cause
      */
     public SupplyChainValidatorException(final String message, final Throwable cause) {
         super(message, cause);
@@ -24,8 +22,7 @@ public class SupplyChainValidatorException extends Exception {
      * Creates a new <code>SupplyChainValidatorException</code> that has the <code>String</code>
      * message <code>message</code>.
      *
-     * @param message
+     * @param message exception message
-     *            exception message
      */
     public SupplyChainValidatorException(final String message) {
         super(message);
@@ -35,8 +32,7 @@ public class SupplyChainValidatorException extends Exception {
      * Creates a new <code>SupplyChainValidatorException</code> that has the <code>Throwable</code>
      * cause <code>cause</code>.
      *
-     * @param cause
+     * @param cause root cause
-     *            root cause
      */
     public SupplyChainValidatorException(final Throwable cause) {
         super(cause);

HIRS_AttestationCA/src/main/resources/identity_transform.xslt

@@ -1,5 +1,5 @@
 <?xml version="1.0"?>
-<xsl:stylesheet version="1.0" xmlns:xsl="http://www.w3.org/1999/XSL/Transform">
+<xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform" version="1.0">
     <xsl:output indent="no"/>
     <xsl:strip-space elements="*"/>
     <xsl:template match="@*|node()">

HIRS_AttestationCA/src/test/java/hirs/attestationca/persist/AttestationCertificateAuthorityTest.java

@@ -72,62 +72,10 @@ import static org.mockito.Mockito.when;
 @TestInstance(TestInstance.Lifecycle.PER_CLASS)              // needed to use non-static BeforeAll
 public class AttestationCertificateAuthorityTest {
 
-    /**
-     * This internal class handles setup for testing the function
-     * generateCredential() from class AbstractProcessor. Because the
-     * function is Protected and in a different package than the test,
-     * it cannot be accessed directly.
-     */
-    @Nested
-    public class AccessAbstractProcessor extends AbstractProcessor {
-
-        /**
-         * Constructor.
-         *
-         * @param privateKey the private key of the ACA
-         * @param validDays int for the time in which a certificate is valid.
-         */
-        public AccessAbstractProcessor(final PrivateKey privateKey,
-                                       final int validDays) {
-            super(privateKey, validDays);
-        }
-
-        /**
-         * Public wrapper for the protected function generateCredential(), to access for testing.
-         *
-         * @param publicKey cannot be null
-         * @param endorsementCredential the endorsement credential
-         * @param platformCredentials the set of platform credentials
-         * @param deviceName The host name used in the subject alternative name
-         * @param acaCertificate the aca certificate
-         * @return the generated X509 certificate
-         */
-        public X509Certificate accessGenerateCredential(final PublicKey publicKey,
-                                            final EndorsementCredential endorsementCredential,
-                                            final List<PlatformCredential> platformCredentials,
-                                            final String deviceName,
-                                            final X509Certificate acaCertificate) {
-
-            return generateCredential(publicKey,
-                                    endorsementCredential,
-                                    platformCredentials,
-                                    deviceName,
-                                    acaCertificate);
-        }
-    }
-
-    // object in test
-    private AttestationCertificateAuthority aca;
-    private AccessAbstractProcessor abstractProcessor;
-
-    // test key pair
-    private KeyPair keyPair;
-
     // length of IV used in PKI
     private static final int ENCRYPTION_IV_LEN = 16;
     // length of secret key used in PKI
     private static final int SECRETKEY_LEN = 128;
-
     private static final String EK_PUBLIC_PATH = "/tpm2/ek.pub";
     private static final String AK_PUBLIC_PATH = "/tpm2/ak.pub";
     private static final String AK_NAME_PATH = "/tpm2/ak.name";
@@ -167,7 +115,11 @@ public class AttestationCertificateAuthorityTest {
     private static final String AK_NAME_HEX = "00 0b 6e 8f 79 1c 7e 16  96 1b 11 71 65 9c e0 cd"
             + "ae 0d 4d aa c5 41 be 58  89 74 67 55 96 c2 5e 38"
             + "e2 94";
-
+    // object in test
+    private AttestationCertificateAuthority aca;
+    private AccessAbstractProcessor abstractProcessor;
+    // test key pair
+    private KeyPair keyPair;
 
     /**
      * Registers bouncy castle as a security provider. Normally the JEE container will handle this,
@@ -540,6 +492,7 @@ public class AttestationCertificateAuthorityTest {
 
     /**
      * Tests parsing the EK from the TPM2 output file.
+     *
      * @throws URISyntaxException incorrect resource path
      * @throws IOException        unable to read from file
      */
@@ -567,6 +520,7 @@ public class AttestationCertificateAuthorityTest {
 
     /**
      * Tests parsing the AK public key from the TPM2 output file.
+     *
      * @throws URISyntaxException incorrect resource path
      * @throws IOException        unable to read from file
      */
@@ -594,6 +548,7 @@ public class AttestationCertificateAuthorityTest {
 
     /**
      * Tests parsing the AK name from the TPM2 output file.
+     *
      * @throws URISyntaxException       incorrect resource path
      * @throws IOException              unable to read from file
      * @throws NoSuchAlgorithmException inavlid algorithm
@@ -624,6 +579,7 @@ public class AttestationCertificateAuthorityTest {
      * and ekPubPath are correct. Your output file will be
      * HIRS_AttestationCA/src/test/resources/tpm2/test/make.blob and the nonce used will be
      * output as HIRS_AttestationCA/src/test/resources/tpm2/test/secret.blob
+     *
      * @throws URISyntaxException invalid file path
      * @throws IOException        unable to read file
      */
@@ -754,4 +710,48 @@ public class AttestationCertificateAuthorityTest {
         // return the cipher text
         return cipher.doFinal(blob);
     }
+
+    /**
+     * This internal class handles setup for testing the function
+     * generateCredential() from class AbstractProcessor. Because the
+     * function is Protected and in a different package than the test,
+     * it cannot be accessed directly.
+     */
+    @Nested
+    public class AccessAbstractProcessor extends AbstractProcessor {
+
+        /**
+         * Constructor.
+         *
+         * @param privateKey the private key of the ACA
+         * @param validDays  int for the time in which a certificate is valid.
+         */
+        public AccessAbstractProcessor(final PrivateKey privateKey,
+                                       final int validDays) {
+            super(privateKey, validDays);
+        }
+
+        /**
+         * Public wrapper for the protected function generateCredential(), to access for testing.
+         *
+         * @param publicKey             cannot be null
+         * @param endorsementCredential the endorsement credential
+         * @param platformCredentials   the set of platform credentials
+         * @param deviceName            The host name used in the subject alternative name
+         * @param acaCertificate        the aca certificate
+         * @return the generated X509 certificate
+         */
+        public X509Certificate accessGenerateCredential(final PublicKey publicKey,
+                                                        final EndorsementCredential endorsementCredential,
+                                                        final List<PlatformCredential> platformCredentials,
+                                                        final String deviceName,
+                                                        final X509Certificate acaCertificate) {
+
+            return generateCredential(publicKey,
+                    endorsementCredential,
+                    platformCredentials,
+                    deviceName,
+                    acaCertificate);
+        }
+    }
 }

HIRS_AttestationCA/src/test/java/hirs/attestationca/persist/entity/tpm/TPM2ProvisionerStateTest.java

@@ -1,20 +1,20 @@
 package hirs.attestationca.persist.entity.tpm;
 
 import hirs.attestationca.persist.entity.manager.TPM2ProvisionerStateRepository;
-
-import static org.junit.jupiter.api.Assertions.assertNull;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertArrayEquals;
-import static org.junit.jupiter.api.Assertions.assertThrows;
 import org.junit.jupiter.api.Test;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
 
 import java.io.ByteArrayInputStream;
 import java.io.DataInputStream;
 import java.io.IOException;
 import java.util.Random;
 
+import static org.junit.jupiter.api.Assertions.assertArrayEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
 /**
  * Contains unit tests for {@link TPM2ProvisionerState}.
  */
@@ -91,6 +91,7 @@ public class TPM2ProvisionerStateTest {
      *TPM2ProvisionerStateRepository, byte[])} works.
      * {@link TPM2ProvisionerState#getTPM2ProvisionerState(
      *TPM2ProvisionerStateRepository, byte[])}, null is returned.
+     *
      * @throws IOException this will never happen
      */
     @Test
@@ -117,6 +118,7 @@ public class TPM2ProvisionerStateTest {
      * Test that if a null is passed as a nonce to
      * {@link TPM2ProvisionerState#getTPM2ProvisionerState(
      *TPM2ProvisionerStateRepository, byte[])}, null is returned.
+     *
      * @throws IOException this will never happen
      */
     @Test
@@ -140,6 +142,7 @@ public class TPM2ProvisionerStateTest {
      * Test that if a nonce that is less than 8 bytes is passed to
      * {@link TPM2ProvisionerState#getTPM2ProvisionerState(
      *TPM2ProvisionerStateRepository, byte[])}, null is returned.
+     *
      * @throws IOException this will never happen
      */
     @Test

HIRS_AttestationCA/src/test/java/hirs/attestationca/persist/entity/userdefined/AbstractUserdefinedEntityTest.java

@@ -33,7 +33,6 @@ import java.util.Objects;
 
 /**
  * Class with definitions and functions common to multiple Userdefined Entity object tests.
- *
  */
 public class AbstractUserdefinedEntityTest {
 
@@ -58,54 +57,45 @@ public class AbstractUserdefinedEntityTest {
      */
     public static final String FAKE_ROOT_CA_SUBJECT_KEY_IDENTIFIER_HEX =
             "58ec313a1699f94c1c8c4e2c6412402b258f0177";
-
-    /**
-     * Location of a test identity certificate.
-     */
-    private static final String TEST_IDENTITY_CERT = "/tpm/sample_identity_cert.cer";
-
     /**
      * Location of a test platform attribute cert.
      */
     public static final String TEST_PLATFORM_CERT_1 =
             "/validation/platform_credentials/Intel_pc1.cer";
-
     /**
      * Location of another, slightly different platform attribute cert.
      */
     public static final String TEST_PLATFORM_CERT_2 =
             "/validation/platform_credentials/Intel_pc2.cer";
-
     /**
      * Location of another, slightly different platform attribute cert.
      */
     public static final String TEST_PLATFORM_CERT_3 =
             "/validation/platform_credentials/Intel_pc3.cer";
-
     /**
      * Platform cert with comma separated baseboard and chassis serial number.
      */
     public static final String TEST_PLATFORM_CERT_4 =
             "/validation/platform_credentials/Intel_pc4.pem";
-
     /**
      * Another platform cert with comma separated baseboard and chassis serial number.
      */
     public static final String TEST_PLATFORM_CERT_5 =
             "/validation/platform_credentials/Intel_pc5.pem";
-
     /**
      * Location of another, slightly different platform attribute cert.
      */
     public static final String TEST_PLATFORM_CERT_6 =
             "/validation/platform_credentials/TPM_INTC_Platform_Cert_RSA.txt";
-
-    private static final Logger LOGGER = LogManager.getLogger(DeviceInfoReportTest.class);
-
     /**
      * Dummy message for supply chain validation test.
      */
     public static final String VALIDATION_MESSAGE = "Some message.";
+    /**
+     * Location of a test identity certificate.
+     */
+    private static final String TEST_IDENTITY_CERT = "/tpm/sample_identity_cert.cer";
+    private static final Logger LOGGER = LogManager.getLogger(DeviceInfoReportTest.class);
 
     /**
      * Construct a test certificate from the given parameters.

HIRS_AttestationCA/src/test/java/hirs/attestationca/persist/entity/userdefined/CertificateTest.java

@@ -21,11 +21,12 @@ import java.security.cert.X509Certificate;
 import java.util.Arrays;
 import java.util.Objects;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertArrayEquals;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 /**
  * This class tests functionality of the {@link Certificate} class.
@@ -88,6 +89,37 @@ public class CertificateTest extends AbstractUserdefinedEntityTest {
     private static final String EK_CERT_WITH_PADDED_BYTES =
             "/certificates/ek_cert_with_padded_bytes.cer";
 
+    /**
+     * Construct a CertificateAuthorityCredential from the given parameters.
+     *
+     * @param filename the location of the certificate to be used
+     * @return the newly-constructed Certificate
+     * @throws IOException if there is a problem constructing the test certificate
+     */
+    public static Certificate getTestCertificate(
+            final String filename) throws IOException {
+        return getTestCertificate(CertificateAuthorityCredential.class, filename);
+    }
+
+    private static X509Certificate readX509Certificate(final String resourceName)
+            throws IOException {
+
+        CertificateFactory cf;
+        try {
+            cf = CertificateFactory.getInstance("X.509");
+        } catch (CertificateException e) {
+            throw new IOException("Cannot get X509 CertificateFactory instance", e);
+        }
+
+        try (FileInputStream certInputStream = new FileInputStream(Paths.get(
+                Objects.requireNonNull(CertificateTest.class.getResource(
+                        resourceName)).toURI()).toFile()
+        )) {
+            return (X509Certificate) cf.generateCertificate(certInputStream);
+        } catch (CertificateException | URISyntaxException e) {
+            throw new IOException("Cannot read certificate", e);
+        }
+    }
 
     /**
      * Tests that a certificate can be constructed from a byte array.
@@ -293,7 +325,7 @@ public class CertificateTest extends AbstractUserdefinedEntityTest {
                 attrCertHolder.getIssuer().getNames()[0].toString(),
                 platformCert.getIssuer()
         );
-        assertEquals(null, platformCert.getSubject());
+        assertNull(platformCert.getSubject());
         assertArrayEquals(null, platformCert.getEncodedPublicKey());
         assertArrayEquals(attrCertHolder.getSignature(), platformCert.getSignature());
         assertEquals(attrCertHolder.getNotBefore(), platformCert.getBeginValidity());
@@ -492,36 +524,4 @@ public class CertificateTest extends AbstractUserdefinedEntityTest {
                 ).hashCode()
         );
     }
-
-    /**
-     * Construct a CertificateAuthorityCredential from the given parameters.
-     *
-     * @param filename the location of the certificate to be used
-     * @return the newly-constructed Certificate
-     * @throws IOException if there is a problem constructing the test certificate
-     */
-    public static Certificate getTestCertificate(
-            final String filename) throws IOException {
-        return getTestCertificate(CertificateAuthorityCredential.class, filename);
-    }
-
-    private static X509Certificate readX509Certificate(final String resourceName)
-            throws IOException {
-
-        CertificateFactory cf;
-        try {
-            cf = CertificateFactory.getInstance("X.509");
-        } catch (CertificateException e) {
-            throw new IOException("Cannot get X509 CertificateFactory instance", e);
-        }
-
-        try (FileInputStream certInputStream = new FileInputStream(Paths.get(
-                Objects.requireNonNull(CertificateTest.class.getResource(
-                        resourceName)).toURI()).toFile()
-        )) {
-            return (X509Certificate) cf.generateCertificate(certInputStream);
-        } catch (CertificateException | URISyntaxException e) {
-            throw new IOException("Cannot read certificate", e);
-        }
-    }
 }

HIRS_AttestationCA/src/test/java/hirs/attestationca/persist/entity/userdefined/DeviceTest.java

@@ -11,7 +11,6 @@ import static org.junit.jupiter.api.Assertions.assertNull;
 
 /**
  * This is the test class for the <code>Device</code> class.
- *
  */
 public final class DeviceTest extends AbstractUserdefinedEntityTest {
 

HIRS_AttestationCA/src/test/java/hirs/attestationca/persist/entity/userdefined/PolicySettingsTest.java

@@ -1,10 +1,11 @@
 package hirs.attestationca.persist.entity.userdefined;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertTrue;
-import static org.junit.jupiter.api.Assertions.assertFalse;
 import org.junit.jupiter.api.Test;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
 /**
  * Unit test class for PolicySettings.
  */

HIRS_AttestationCA/src/test/java/hirs/attestationca/persist/entity/userdefined/SupplyChainValidationSummaryTest.java

@@ -26,16 +26,28 @@ public class SupplyChainValidationSummaryTest extends AbstractUserdefinedEntityT
 
     /**
      * Test device.
-     *
      */
     private Device device;
 
     /**
      * List of test certificates.
-     *
      */
     private List<ArchivableEntity> certificates;
 
+    /**
+     * Utility method for getting a <code>Device</code> that can be used for
+     * testing.
+     *
+     * @param name name for the <code>Device</code>
+     * @return device
+     */
+    public static Device getTestDevice(final String name) {
+        final DeviceInfoReport deviceInfo = getTestDeviceInfoReport();
+        return new Device(name, deviceInfo, HealthStatus.UNKNOWN,
+                AppraisalStatus.Status.UNKNOWN, null,
+                false, null, null);
+    }
+
     /**
      * Create a set of certificates and a device for use by these tests.
      *
@@ -152,28 +164,12 @@ public class SupplyChainValidationSummaryTest extends AbstractUserdefinedEntityT
         assertNotNull(twoBadValidations.getCreateTime());
     }
 
-    /**
-     * Utility method for getting a <code>Device</code> that can be used for
-     * testing.
-     *
-     * @param name name for the <code>Device</code>
-     *
-     * @return device
-     */
-    public static Device getTestDevice(final String name) {
-        final DeviceInfoReport deviceInfo = getTestDeviceInfoReport();
-        return new Device(name, deviceInfo, HealthStatus.UNKNOWN,
-                AppraisalStatus.Status.UNKNOWN, null,
-                false, null, null);
-    }
-
     /**
      * Utility method for getting a <code>SupplyChainValidationSummary</code> that can be used for
      * testing.
      *
      * @param numberOfValidations number of validations for the <code>SupplyChainValidationSummary</code>
      * @param numFail             number of failed validations
-     *
      * @return device
      */
     private SupplyChainValidationSummary getTestSummary(
@@ -199,10 +195,7 @@ public class SupplyChainValidationSummaryTest extends AbstractUserdefinedEntityT
 
         Collection<SupplyChainValidation> validations = new HashSet<>();
         for (int i = 0; i < numberOfValidations; i++) {
-            boolean successful = true;
+            boolean successful = i < (numberOfValidations - numFail);
-            if (i >= (numberOfValidations - numFail)) {
-                successful = false;
-            }
 
             AppraisalStatus.Status result = AppraisalStatus.Status.FAIL;
             if (successful) {

HIRS_AttestationCA/src/test/java/hirs/attestationca/persist/entity/userdefined/SupplyChainValidationTest.java

@@ -14,6 +14,22 @@ import static org.junit.jupiter.api.Assertions.assertThrows;
  */
 class SupplyChainValidationTest extends AbstractUserdefinedEntityTest {
 
+    /**
+     * Construct a SupplyChainValidation for use in tests.  It will have a validation
+     * type of ENDORSEMENT_CREDENTIAL, will represent a successful validation, and will use
+     * multiple test certificates.
+     *
+     * @return the test SupplyChainValidation
+     * @throws IOException if there si
+     */
+    public static SupplyChainValidation getTestSupplyChainValidation() throws IOException {
+        return getTestSupplyChainValidation(
+                SupplyChainValidation.ValidationType.ENDORSEMENT_CREDENTIAL,
+                AppraisalStatus.Status.PASS,
+                getAllTestCertificates()
+        );
+    }
+
     /**
      * Test that this class' getter methods work properly.
      *
@@ -79,20 +95,4 @@ class SupplyChainValidationTest extends AbstractUserdefinedEntityTest {
                 VALIDATION_MESSAGE
         );
     }
-
-    /**
-     * Construct a SupplyChainValidation for use in tests.  It will have a validation
-     * type of ENDORSEMENT_CREDENTIAL, will represent a successful validation, and will use
-     * multiple test certificates.
-     *
-     * @return the test SupplyChainValidation
-     * @throws IOException if there si
-     */
-    public static SupplyChainValidation getTestSupplyChainValidation() throws IOException {
-        return getTestSupplyChainValidation(
-                SupplyChainValidation.ValidationType.ENDORSEMENT_CREDENTIAL,
-                AppraisalStatus.Status.PASS,
-                getAllTestCertificates()
-        );
-    }
 }

HIRS_AttestationCA/src/test/java/hirs/attestationca/persist/entity/userdefined/certificate/CertificateAuthorityCredentialTest.java

@@ -2,8 +2,6 @@ package hirs.attestationca.persist.entity.userdefined.certificate;
 
 import hirs.attestationca.persist.entity.userdefined.AbstractUserdefinedEntityTest;
 import org.apache.commons.codec.binary.Hex;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
 import org.junit.jupiter.api.Test;
 
 import java.io.IOException;
@@ -12,6 +10,9 @@ import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.security.cert.CertificateException;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+
 /**
  * Tests that CertificateAuthorityCredential properly parses its fields.
  */

HIRS_AttestationCA/src/test/java/hirs/attestationca/persist/entity/userdefined/certificate/EndorsementCredentialTest.java

@@ -1,10 +1,7 @@
 package hirs.attestationca.persist.entity.userdefined.certificate;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import hirs.attestationca.persist.entity.userdefined.certificate.attributes.TPMSecurityAssertions;
-import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import hirs.attestationca.persist.entity.userdefined.certificate.attributes.TPMSpecification;
-import static org.junit.jupiter.api.Assertions.assertTrue;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-
 import org.junit.jupiter.api.Test;
 
 import java.io.IOException;
@@ -12,8 +9,11 @@ import java.math.BigInteger;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;
-import hirs.attestationca.persist.entity.userdefined.certificate.attributes.TPMSecurityAssertions;
+
-import hirs.attestationca.persist.entity.userdefined.certificate.attributes.TPMSpecification;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 /**
  * Tests for the EndorsementCredential class.
@@ -32,6 +32,7 @@ public class EndorsementCredentialTest {
 
     /**
      * Tests the successful parsing of an EC using a test cert from STM.
+     *
      * @throws IOException test failed due to invalid certificate parsing
      */
     @Test
@@ -65,6 +66,7 @@ public class EndorsementCredentialTest {
 
     /**
      * Tests the successful parsing of an EC using a test cert from NUC 1.
+     *
      * @throws IOException test failed due to invalid certificate parsing
      */
     @Test
@@ -99,6 +101,7 @@ public class EndorsementCredentialTest {
     /**
      * Tests the successful parsing of an EC using a test cert from NUC 1,
      * using the static builder method.
+     *
      * @throws IOException test failed due to invalid certificate parsing
      */
     @Test
@@ -134,6 +137,7 @@ public class EndorsementCredentialTest {
 
     /**
      * Tests the successful parsing of an EC using a test cert from NUC 2.
+     *
      * @throws IOException test failed due to invalid certificate parsing
      */
     @Test
@@ -167,6 +171,7 @@ public class EndorsementCredentialTest {
 
     /**
      * Tests that different EC certificates aren't the same, even if their attributes are the same.
+     *
      * @throws IOException test failed due to invalid certificate parsing
      */
     @Test

HIRS_AttestationCA/src/test/java/hirs/attestationca/persist/entity/userdefined/certificate/PlatformCredentialTest.java

@@ -12,7 +12,6 @@ import org.apache.commons.codec.binary.Hex;
 import org.bouncycastle.util.encoders.Base64;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.fail;
 
 import java.io.IOException;
 import java.net.URISyntaxException;
@@ -23,6 +22,8 @@ import java.util.Calendar;
 import java.util.List;
 import java.util.TimeZone;
 
+import static org.junit.jupiter.api.Assertions.fail;
+
 /**
  * Tests that a PlatformCredential parses its fields correctly.
  */
@@ -206,7 +207,7 @@ public class PlatformCredentialTest extends AbstractUserdefinedEntityTest {
         Assertions.assertEquals(credential.getCredentialType(), "TCPA Trusted Platform Endorsement");
 
         // the platform certificate in this test does not contain the following information
-        Assertions.assertEquals(credential.getPlatformSerial(), null);
+        Assertions.assertNull(credential.getPlatformSerial());
         Assertions.assertEquals(credential.getMajorVersion(), 1);
         Assertions.assertEquals(credential.getMinorVersion(), 2);
         Assertions.assertEquals(credential.getRevisionLevel(), 1);
@@ -255,7 +256,7 @@ public class PlatformCredentialTest extends AbstractUserdefinedEntityTest {
         Assertions.assertEquals(credential.getCredentialType(), "TCPA Trusted Platform Endorsement");
 
         // the platform certificate in this test does not contain the following information
-        Assertions.assertEquals(credential.getPlatformSerial(), null);
+        Assertions.assertNull(credential.getPlatformSerial());
         Assertions.assertEquals(credential.getMajorVersion(), 1);
         Assertions.assertEquals(credential.getMinorVersion(), 2);
         Assertions.assertEquals(credential.getRevisionLevel(), 1);
@@ -398,37 +399,30 @@ public class PlatformCredentialTest extends AbstractUserdefinedEntityTest {
         ComponentIdentifier component;
 
         //Check component #2
-        component = (ComponentIdentifier) allComponents.get(1);
+        component = allComponents.get(1);
-        Assertions.assertTrue(component.getComponentManufacturer()
+        Assertions.assertEquals("Intel Corporation", component.getComponentManufacturer()
-                .getString()
+                .getString());
-                .equals("Intel Corporation"));
+        Assertions.assertEquals("NUC7i5DNB", component.getComponentModel()
-        Assertions.assertTrue(component.getComponentModel()
+                .getString());
-                .getString()
+        Assertions.assertEquals("BTDN732000QM", component.getComponentSerial()
-                .equals("NUC7i5DNB"));
+                .getString());
-        Assertions.assertTrue(component.getComponentSerial()
-                .getString()
-                .equals("BTDN732000QM"));
 
         //Check component #3
-        component = (ComponentIdentifier) allComponents.get(2);
+        component = allComponents.get(2);
-        Assertions.assertTrue(component.getComponentManufacturer()
+        Assertions.assertEquals("Intel(R) Corporation", component.getComponentManufacturer()
-                .getString()
+                .getString());
-                .equals("Intel(R) Corporation"));
+        Assertions.assertEquals("Core i5", component.getComponentModel().getString());
-        Assertions.assertTrue(component.getComponentModel().getString().equals("Core i5"));
         Assertions.assertTrue(component.getFieldReplaceable().isTrue());
 
         //Check component #5
-        component = (ComponentIdentifier) allComponents.get(4);
+        component = allComponents.get(4);
-        Assertions.assertTrue(component.getComponentModel()
+        Assertions.assertEquals("Ethernet Connection I219-LM", component.getComponentModel()
-                .getString()
+                .getString());
-                .equals("Ethernet Connection I219-LM"));
+        Assertions.assertEquals("8c:0f:6f:72:c6:c5", component.getComponentAddress().get(0)
-        Assertions.assertTrue(component.getComponentAddress().get(0)
                 .getAddressValue()
-                .getString()
+                .getString());
-                .equals("8c:0f:6f:72:c6:c5"));
+        Assertions.assertEquals("ethernet mac", component.getComponentAddress().get(0)
-        Assertions.assertTrue(component.getComponentAddress().get(0)
+                .getAddressTypeValue());
-                .getAddressTypeValue()
-                .equals("ethernet mac"));
 
         //Check Platform Properties
         List<PlatformProperty> platformProperties = platformConfig.getPlatformProperties();
@@ -441,22 +435,22 @@ public class PlatformCredentialTest extends AbstractUserdefinedEntityTest {
         PlatformProperty property;
 
         //Check property #1
-        property = (PlatformProperty) platformProperties.get(0);
+        property = platformProperties.get(0);
-        Assertions.assertTrue(property.getPropertyName().getString().equals("vPro"));
+        Assertions.assertEquals("vPro", property.getPropertyName().getString());
-        Assertions.assertTrue(property.getPropertyValue().getString().equals("true"));
+        Assertions.assertEquals("true", property.getPropertyValue().getString());
 
         //Check property #2
-        property = (PlatformProperty) platformProperties.get(1);
+        property = platformProperties.get(1);
-        Assertions.assertTrue(property.getPropertyName().getString().equals("AMT"));
+        Assertions.assertEquals("AMT", property.getPropertyName().getString());
-        Assertions.assertTrue(property.getPropertyValue().getString().equals("true"));
+        Assertions.assertEquals("true", property.getPropertyValue().getString());
 
         //Check Platform Properties URI
         URIReference platformPropertyUri = platformConfig.getPlatformPropertiesUri();
 
         Assertions.assertNotNull(platformPropertyUri);
-        Assertions.assertTrue(platformPropertyUri.getUniformResourceIdentifier()
+        Assertions.assertEquals("https://www.intel.com/platformproperties.xml",
-                .getString()
+                platformPropertyUri.getUniformResourceIdentifier()
-                .equals("https://www.intel.com/platformproperties.xml"));
+                        .getString());
         Assertions.assertNull(platformPropertyUri.getHashAlgorithm());
         Assertions.assertNull(platformPropertyUri.getHashValue());
     }
@@ -489,14 +483,14 @@ public class PlatformCredentialTest extends AbstractUserdefinedEntityTest {
         PlatformProperty property;
 
         //Check property #1
-        property = (PlatformProperty) platformProperties.get(0);
+        property = platformProperties.get(0);
-        Assertions.assertTrue(property.getPropertyName().getString().equals("vPro"));
+        Assertions.assertEquals("vPro", property.getPropertyName().getString());
-        Assertions.assertTrue(property.getPropertyValue().getString().equals("true"));
+        Assertions.assertEquals("true", property.getPropertyValue().getString());
 
         //Check property #2
-        property = (PlatformProperty) platformProperties.get(1);
+        property = platformProperties.get(1);
-        Assertions.assertTrue(property.getPropertyName().getString().equals("AMT"));
+        Assertions.assertEquals("AMT", property.getPropertyName().getString());
-        Assertions.assertTrue(property.getPropertyValue().getString().equals("true"));
+        Assertions.assertEquals("true", property.getPropertyValue().getString());
     }
 
     /**
@@ -524,25 +518,20 @@ public class PlatformCredentialTest extends AbstractUserdefinedEntityTest {
         ComponentIdentifier component;
 
         //Check component #2
-        component = (ComponentIdentifier) allComponents.get(1);
+        component = allComponents.get(1);
-        Assertions.assertTrue(component.getComponentManufacturer()
+        Assertions.assertEquals("Intel(R) Corporation", component.getComponentManufacturer()
-                .getString()
+                .getString());
-                .equals("Intel(R) Corporation"));
+        Assertions.assertEquals("Intel(R) Core(TM) i5-7300U CPU @ 2.60GHz", component.getComponentModel()
-        Assertions.assertTrue(component.getComponentModel()
+                .getString());
-                .getString()
-                .equals("Intel(R) Core(TM) i5-7300U CPU @ 2.60GHz"));
 
         //Check component #3
-        component = (ComponentIdentifier) allComponents.get(2);
+        component = allComponents.get(2);
-        Assertions.assertTrue(component.getComponentModel()
+        Assertions.assertEquals("BIOS", component.getComponentModel()
-                .getString()
+                .getString());
-                .equals("BIOS"));
+        Assertions.assertEquals(ComponentIdentifier.NOT_SPECIFIED_COMPONENT, component.getComponentSerial()
-        Assertions.assertTrue(component.getComponentSerial()
+                .getString());
-                .getString()
+        Assertions.assertEquals("DNKBLi5v.86A.0019.2017.0804.1146", component.getComponentRevision()
-                .equals(ComponentIdentifier.NOT_SPECIFIED_COMPONENT));
+                .getString());
-        Assertions.assertTrue(component.getComponentRevision()
-                .getString()
-                .equals("DNKBLi5v.86A.0019.2017.0804.1146"));
 
         //Check Platform Properties
         List<PlatformProperty> platformProperties = platformConfig.getPlatformProperties();
@@ -556,20 +545,20 @@ public class PlatformCredentialTest extends AbstractUserdefinedEntityTest {
         URIReference platformPropertyUri = platformConfig.getPlatformPropertiesUri();
 
         Assertions.assertNotNull(platformPropertyUri);
-        Assertions.assertTrue(platformPropertyUri.getUniformResourceIdentifier()
+        Assertions.assertEquals("https://www.intel.com/platformproperties.xml",
-                .getString()
+                platformPropertyUri.getUniformResourceIdentifier()
-                .equals("https://www.intel.com/platformproperties.xml"));
+                        .getString());
         Assertions.assertNull(platformPropertyUri.getHashAlgorithm());
         Assertions.assertNull(platformPropertyUri.getHashValue());
 
         //Test TBBSecurityAssertion
         TBBSecurityAssertion tbbSec = platformCert.getTBBSecurityAssertion();
         Assertions.assertNotNull(tbbSec);
-        Assertions.assertTrue(tbbSec.getCcInfo().getVersion().getString().equals("3.1"));
+        Assertions.assertEquals("3.1", tbbSec.getCcInfo().getVersion().getString());
-        Assertions.assertTrue(tbbSec.getCcInfo().getProfileOid().getId().equals("1.2.3.4.5.6"));
+        Assertions.assertEquals("1.2.3.4.5.6", tbbSec.getCcInfo().getProfileOid().getId());
-        Assertions.assertTrue(tbbSec.getFipsLevel().getVersion().getString().equals("140-2"));
+        Assertions.assertEquals("140-2", tbbSec.getFipsLevel().getVersion().getString());
-        Assertions.assertTrue(tbbSec.getIso9000Uri().getString()
+        Assertions.assertEquals("https://www.intel.com/isocertification.pdf",
-                .equals("https://www.intel.com/isocertification.pdf"));
+                tbbSec.getIso9000Uri().getString());
     }
 
     /**
@@ -597,24 +586,20 @@ public class PlatformCredentialTest extends AbstractUserdefinedEntityTest {
         ComponentIdentifier component;
 
         //Check component #1
-        component = (ComponentIdentifier) allComponents.get(0);
+        component = allComponents.get(0);
-        Assertions.assertTrue(component.getComponentModel()
+        Assertions.assertEquals("NUC7i5DNB", component.getComponentModel()
-                .getString()
+                .getString());
-                .equals("NUC7i5DNB"));
+        Assertions.assertEquals("J57626-401", component.getComponentRevision()
-        Assertions.assertTrue(component.getComponentRevision()
+                .getString());
-                .getString()
-                .equals("J57626-401"));
 
         //Check component #7
-        component = (ComponentIdentifier) allComponents.get(6);
+        component = allComponents.get(6);
         Assertions.assertTrue(component.getComponentAddress().size() > 0);
-        Assertions.assertTrue(component.getComponentAddress().get(0)
+        Assertions.assertEquals("8c:0f:6f:72:c6:c5", component.getComponentAddress().get(0)
                 .getAddressValue()
-                .getString()
+                .getString());
-                .equals("8c:0f:6f:72:c6:c5"));
+        Assertions.assertEquals("ethernet mac", component.getComponentAddress().get(0)
-        Assertions.assertTrue(component.getComponentAddress().get(0)
+                .getAddressTypeValue());
-                .getAddressTypeValue()
-                .equals("ethernet mac"));
 
         //Check Platform Properties
         List<PlatformProperty> platformProperties = platformConfig.getPlatformProperties();
@@ -628,20 +613,20 @@ public class PlatformCredentialTest extends AbstractUserdefinedEntityTest {
         URIReference platformPropertyUri = platformConfig.getPlatformPropertiesUri();
 
         Assertions.assertNotNull(platformPropertyUri);
-        Assertions.assertTrue(platformPropertyUri.getUniformResourceIdentifier()
+        Assertions.assertEquals("https://www.intel.com/platformproperties.xml",
-                .getString()
+                platformPropertyUri.getUniformResourceIdentifier()
-                .equals("https://www.intel.com/platformproperties.xml"));
+                        .getString());
         Assertions.assertNull(platformPropertyUri.getHashAlgorithm());
         Assertions.assertNull(platformPropertyUri.getHashValue());
 
         //Test TBBSecurityAssertion
         TBBSecurityAssertion tbbSec = platformCert.getTBBSecurityAssertion();
         Assertions.assertNotNull(tbbSec);
-        Assertions.assertTrue(tbbSec.getCcInfo().getVersion().getString().equals("3.1"));
+        Assertions.assertEquals("3.1", tbbSec.getCcInfo().getVersion().getString());
-        Assertions.assertTrue(tbbSec.getCcInfo().getProfileOid().getId().equals("1.2.3.4.5.6"));
+        Assertions.assertEquals("1.2.3.4.5.6", tbbSec.getCcInfo().getProfileOid().getId());
-        Assertions.assertTrue(tbbSec.getFipsLevel().getVersion().getString().equals("140-2"));
+        Assertions.assertEquals("140-2", tbbSec.getFipsLevel().getVersion().getString());
-        Assertions.assertTrue(tbbSec.getIso9000Uri().getString()
+        Assertions.assertEquals("https://www.intel.com/isocertification.pdf",
-                .equals("https://www.intel.com/isocertification.pdf"));
+                tbbSec.getIso9000Uri().getString());
 
     }
 
@@ -675,19 +660,19 @@ public class PlatformCredentialTest extends AbstractUserdefinedEntityTest {
         PlatformProperty property;
 
         //Check property #1
-        property = (PlatformProperty) platformProperties.get(0);
+        property = platformProperties.get(0);
-        Assertions.assertTrue(property.getPropertyName().getString().equals("AMT"));
+        Assertions.assertEquals("AMT", property.getPropertyName().getString());
-        Assertions.assertTrue(property.getPropertyValue().getString().equals("true"));
+        Assertions.assertEquals("true", property.getPropertyValue().getString());
 
         //Check property #2
-        property = (PlatformProperty) platformProperties.get(1);
+        property = platformProperties.get(1);
-        Assertions.assertTrue(property.getPropertyName().getString().equals("vPro Enabled"));
+        Assertions.assertEquals("vPro Enabled", property.getPropertyName().getString());
-        Assertions.assertTrue(property.getPropertyValue().getString().equals("true"));
+        Assertions.assertEquals("true", property.getPropertyValue().getString());
 
         //Check property #3
-        property = (PlatformProperty) platformProperties.get(2);
+        property = platformProperties.get(2);
-        Assertions.assertTrue(property.getPropertyName().getString().equals("DropShip Enabled"));
+        Assertions.assertEquals("DropShip Enabled", property.getPropertyName().getString());
-        Assertions.assertTrue(property.getPropertyValue().getString().equals("false"));
+        Assertions.assertEquals("false", property.getPropertyValue().getString());
     }
 
     /**
@@ -705,7 +690,7 @@ public class PlatformCredentialTest extends AbstractUserdefinedEntityTest {
         PlatformCredential platformCert = new PlatformCredential(certPath);
         PlatformConfiguration platformConfig = platformCert.getPlatformConfiguration();
 
-        Assertions.assertTrue(platformConfig instanceof PlatformConfigurationV2);
+        Assertions.assertInstanceOf(PlatformConfigurationV2.class, platformConfig);
         Assertions.assertEquals(platformConfig.getPlatformPropertiesUri()
                         .getUniformResourceIdentifier().toString(),
                 "https://www.intel.com/platformproperties.xml");

HIRS_AttestationCA/src/test/java/hirs/attestationca/persist/entity/userdefined/certificate/attributes/ComponentClassTest.java

@@ -1,12 +1,13 @@
 package hirs.attestationca.persist.entity.userdefined.certificate.attributes;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNull;
 import org.junit.jupiter.api.Test;
 
 import java.net.URISyntaxException;
 import java.nio.file.Paths;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
+
 /**
  * Tests for the ComponentClassTest class.
  */
@@ -16,6 +17,7 @@ public class ComponentClassTest {
 
     /**
      * Test of getComponent method, of class ComponentClass.
+     *
      * @throws URISyntaxException if there is a problem constructing the URI
      */
     @Test
@@ -32,6 +34,7 @@ public class ComponentClassTest {
 
     /**
      * Test of getComponent method, of class ComponentClass.
+     *
      * @throws URISyntaxException if there is a problem constructing the URI
      */
     @Test
@@ -47,6 +50,7 @@ public class ComponentClassTest {
 
     /**
      * Test of getComponent method, of class ComponentClass.
+     *
      * @throws URISyntaxException if there is a problem constructing the URI
      */
     @Test
@@ -59,8 +63,10 @@ public class ComponentClassTest {
         assertEquals(resultComponent, "Unknown");
         assertEquals(resultCategory, "None");
     }
+
     /**
      * Test of getComponent method, of class ComponentClass.
+     *
      * @throws URISyntaxException if there is a problem constructing the URI
      */
     @Test
@@ -76,6 +82,7 @@ public class ComponentClassTest {
 
     /**
      * Test of getComponent method, of class ComponentClass.
+     *
      * @throws URISyntaxException if there is a problem constructing the URI
      */
     @Test
@@ -91,6 +98,7 @@ public class ComponentClassTest {
 
     /**
      * Test of getComponent method, of class ComponentClass.
+     *
      * @throws URISyntaxException if there is a problem constructing the URI
      */
     @Test
@@ -106,6 +114,7 @@ public class ComponentClassTest {
 
     /**
      * Test of getComponent method, of class ComponentClass.
+     *
      * @throws URISyntaxException if there is a problem constructing the URI
      */
     @Test
@@ -121,6 +130,7 @@ public class ComponentClassTest {
 
     /**
      * Test of getComponent method, of class ComponentClass.
+     *
      * @throws URISyntaxException if there is a problem constructing the URI
      */
     @Test
@@ -136,6 +146,7 @@ public class ComponentClassTest {
 
     /**
      * Test of getComponent method, of class ComponentClass.
+     *
      * @throws URISyntaxException if there is a problem constructing the URI
      */
     @Test
@@ -151,6 +162,7 @@ public class ComponentClassTest {
 
     /**
      * Test of getComponent method, of class ComponentClass.
+     *
      * @throws URISyntaxException if there is a problem constructing the URI
      */
     @Test
@@ -166,6 +178,7 @@ public class ComponentClassTest {
 
     /**
      * Test of getComponent method, of class ComponentClass.
+     *
      * @throws URISyntaxException if there is a problem constructing the URI
      */
     @Test
@@ -181,6 +194,7 @@ public class ComponentClassTest {
 
     /**
      * Test of getComponent method, of class ComponentClass.
+     *
      * @throws URISyntaxException if there is a problem constructing the URI
      */
     @Test
@@ -196,6 +210,7 @@ public class ComponentClassTest {
 
     /**
      * Test of getComponent method, of class ComponentClass.
+     *
      * @throws URISyntaxException if there is a problem constructing the URI
      */
     @Test
@@ -211,6 +226,7 @@ public class ComponentClassTest {
 
     /**
      * Test of getComponent method, of class ComponentClass.
+     *
      * @throws URISyntaxException if there is a problem constructing the URI
      */
     @Test
@@ -226,6 +242,7 @@ public class ComponentClassTest {
 
     /**
      * Test of getComponent method, of class ComponentClass.
+     *
      * @throws URISyntaxException if there is a problem constructing the URI
      */
     @Test
@@ -241,6 +258,7 @@ public class ComponentClassTest {
 
     /**
      * Test of getComponent method, of class ComponentClass.
+     *
      * @throws URISyntaxException if there is a problem constructing the URI
      */
     @Test
@@ -256,6 +274,7 @@ public class ComponentClassTest {
 
     /**
      * Test of getComponent method, of class ComponentClass.
+     *
      * @throws URISyntaxException if there is a problem constructing the URI
      */
     @Test
@@ -271,6 +290,7 @@ public class ComponentClassTest {
 
     /**
      * Test of getComponent method, of class ComponentClass.
+     *
      * @throws URISyntaxException if there is a problem constructing the URI
      */
     @Test

HIRS_AttestationCA/src/test/java/hirs/attestationca/persist/entity/userdefined/certificate/attributes/TPMSecurityAssertionsTest.java

@@ -1,9 +1,10 @@
 package hirs.attestationca.persist.entity.userdefined.certificate.attributes;
 
+import org.junit.jupiter.api.Test;
+
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.fail;
-import org.junit.jupiter.api.Test;
 
 /**
  * Tests for the TPMSecurityAssertions class.
@@ -28,7 +29,6 @@ public class TPMSecurityAssertionsTest {
             assertNull(TPMSecurityAssertions.EkGenerationType.values()[4]);
             fail();
         } catch (ArrayIndexOutOfBoundsException e) {
-            return;
         }
     }
 
@@ -48,7 +48,6 @@ public class TPMSecurityAssertionsTest {
             assertNull(TPMSecurityAssertions.EkGenerationLocation.values()[3]);
             fail();
         } catch (ArrayIndexOutOfBoundsException e) {
-            return;
         }
     }
 }

HIRS_AttestationCA/src/test/java/hirs/attestationca/persist/entity/userdefined/info/PortalInfoTest.java

@@ -1,12 +1,13 @@
 package hirs.attestationca.persist.entity.userdefined.info;
 
 import hirs.utils.enums.PortalScheme;
+import org.junit.jupiter.api.Test;
+
 import java.net.InetAddress;
 
-import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.fail;
-import org.junit.jupiter.api.Test;
 
 /**
  * Provides tests for PortalInfo.
@@ -56,6 +57,7 @@ public class PortalInfoTest {
 
     /**
      * Test that the ip address can be set and retrieved via an InetAddress.
+     *
      * @throws Exception If there is a problem with InetAddress.
      */
     @Test
@@ -70,6 +72,7 @@ public class PortalInfoTest {
 
     /**
      * Test that the ip address can be set and retrieved via a String.
+     *
      * @throws Exception If there is a problem with InetAddress.
      */
     @Test

HIRS_AttestationCA/src/test/java/hirs/attestationca/persist/entity/userdefined/info/TPMInfoTest.java

@@ -1,15 +1,16 @@
 package hirs.attestationca.persist.entity.userdefined.info;
 
-import static hirs.utils.enums.DeviceInfoEnums.NOT_SPECIFIED;
-
 import hirs.attestationca.persist.entity.userdefined.AbstractUserdefinedEntityTest;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
+import org.junit.jupiter.api.Test;
+
+import static hirs.utils.enums.DeviceInfoEnums.NOT_SPECIFIED;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
-import org.junit.jupiter.api.Test;
 
 /**
  * TPMInfoTest is a unit test class for TPMInfo.
@@ -53,7 +54,7 @@ public class TPMInfoTest extends AbstractUserdefinedEntityTest {
         assertEquals(tpmInfo.getTpmVersionMinor(), (short) 0);
         assertEquals(tpmInfo.getTpmVersionRevMajor(), (short) 0);
         assertEquals(tpmInfo.getTpmVersionRevMinor(), (short) 0);
-        assertEquals(tpmInfo.getIdentityCertificate(), null);
+        assertNull(tpmInfo.getIdentityCertificate());
     }
 
     /**

HIRS_AttestationCA/src/test/java/hirs/attestationca/persist/entity/userdefined/record/TPMMeasurementRecordTest.java

@@ -5,14 +5,13 @@ import hirs.utils.digest.Digest;
 import hirs.utils.digest.DigestAlgorithm;
 import org.apache.commons.codec.DecoderException;
 import org.apache.commons.codec.binary.Hex;
-import org.junit.jupiter.api.Test;
-
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
+import org.junit.jupiter.api.Test;
 
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertNotEquals;
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
 /**

HIRS_AttestationCA/src/test/java/hirs/attestationca/persist/entity/userdefined/report/DeviceInfoReportTest.java

@@ -1,14 +1,14 @@
 package hirs.attestationca.persist.entity.userdefined.report;
 
 import hirs.attestationca.persist.entity.userdefined.AbstractUserdefinedEntityTest;
+import hirs.attestationca.persist.entity.userdefined.info.FirmwareInfo;
+import hirs.attestationca.persist.entity.userdefined.info.HardwareInfo;
+import hirs.attestationca.persist.entity.userdefined.info.NetworkInfo;
 import hirs.attestationca.persist.entity.userdefined.info.OSInfo;
 import hirs.attestationca.persist.entity.userdefined.info.TPMInfo;
-import hirs.attestationca.persist.entity.userdefined.info.NetworkInfo;
-import hirs.attestationca.persist.entity.userdefined.info.HardwareInfo;
-import hirs.attestationca.persist.entity.userdefined.info.FirmwareInfo;
-
 import hirs.utils.VersionHelper;
 import org.junit.jupiter.api.Test;
+
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
@@ -16,14 +16,13 @@ import static org.junit.jupiter.api.Assertions.assertThrows;
  * Unit test class for DeviceInfoReports.
  */
 public class DeviceInfoReportTest extends AbstractUserdefinedEntityTest {
+    private static final String EXPECTED_CLIENT_VERSION = VersionHelper.getVersion();
     private final NetworkInfo networkInfo = createTestNetworkInfo();
     private final OSInfo osInfo = createTestOSInfo();
     private final FirmwareInfo firmwareInfo = createTestFirmwareInfo();
     private final HardwareInfo hardwareInfo = createTestHardwareInfo();
     private final TPMInfo tpmInfo = createTPMInfo();
 
-    private static final String EXPECTED_CLIENT_VERSION = VersionHelper.getVersion();
-
     /**
      * Tests instantiation of a DeviceInfoReport.
      */

HIRS_AttestationCA/src/test/java/hirs/attestationca/persist/provision/helper/CredentialManagementHelperTest.java

@@ -20,13 +20,12 @@ import static org.mockito.Mockito.verify;
  */
 public class CredentialManagementHelperTest {
 
-    @Mock
-    private CertificateRepository certificateRepository;
-
     private static final String EK_HEADER_TRUNCATED
             = "/certificates/nuc-1/ek_cert_7_byte_header_removed.cer";
     private static final String EK_UNTOUCHED
             = "/certificates/nuc-1/ek_cert_untouched.cer";
+    @Mock
+    private CertificateRepository certificateRepository;
 
     /**
      * Setup mocks.
@@ -39,6 +38,7 @@ public class CredentialManagementHelperTest {
 
     /**
      * Tests exception generated if providing a null cert repository.
+     *
      * @throws IOException if an IO error occurs
      */
     @Test
@@ -56,7 +56,8 @@ public class CredentialManagementHelperTest {
     @Test
     public void processNullEndorsementCredential() {
         assertThrows(IllegalArgumentException.class, () ->
-            CredentialManagementHelper.storeEndorsementCredential(certificateRepository, null, "testName"));
+                CredentialManagementHelper.storeEndorsementCredential(certificateRepository, null,
+                        "testName"));
     }
 
     /**
@@ -87,11 +88,13 @@ public class CredentialManagementHelperTest {
     public void processInvalidEndorsementCredentialCase2() {
         byte[] ekBytes = new byte[] {1, 0, 1, 0, 0, 1, 0, 0, 1, 0, 0};
         assertThrows(IllegalArgumentException.class, () ->
-        CredentialManagementHelper.storeEndorsementCredential(certificateRepository, ekBytes, "testName"));
+                CredentialManagementHelper.storeEndorsementCredential(certificateRepository, ekBytes,
+                        "testName"));
     }
 
     /**
      * Tests processing a valid EK with the 7 byte header in tact.
+     *
      * @throws IOException if an IO error occurs
      */
     @Test
@@ -105,6 +108,7 @@ public class CredentialManagementHelperTest {
 
     /**
      * Tests processing a valid EK with the 7 byte header already stripped.
+     *
      * @throws IOException if an IO error occurs
      */
     @Test

HIRS_AttestationCA/src/test/java/hirs/attestationca/persist/provision/helper/IssuedCertificateAttributeHelperTest.java

@@ -1,7 +1,7 @@
 package hirs.attestationca.persist.provision.helper;
 
-import hirs.attestationca.persist.entity.userdefined.certificate.PlatformCredential;
 import hirs.attestationca.persist.entity.userdefined.certificate.EndorsementCredential;
+import hirs.attestationca.persist.entity.userdefined.certificate.PlatformCredential;
 import org.bouncycastle.asn1.ASN1Sequence;
 import org.bouncycastle.asn1.ASN1Set;
 import org.bouncycastle.asn1.ASN1TaggedObject;
@@ -51,6 +51,7 @@ public class IssuedCertificateAttributeHelperTest {
 
     /**
      * Test that provide a null host name and is rejected.
+     *
      * @throws IOException an IO error occurs
      */
     @Test
@@ -61,6 +62,7 @@ public class IssuedCertificateAttributeHelperTest {
 
     /**
      * Test that subject alt name can be built without an EC or PC.
+     *
      * @throws IOException an IO error occurs
      */
     @Test
@@ -83,6 +85,7 @@ public class IssuedCertificateAttributeHelperTest {
 
     /**
      * Test that subject alt name can be built with an EC but no PC.
+     *
      * @throws IOException        an IO error occurs
      * @throws URISyntaxException unrecognized URI for EC Path
      */
@@ -114,6 +117,7 @@ public class IssuedCertificateAttributeHelperTest {
 
     /**
      * Test that subject alt name can be built with an PC but no EC.
+     *
      * @throws IOException        an IO error occurs
      * @throws URISyntaxException unrecognized URI for PC Path
      */
@@ -147,6 +151,7 @@ public class IssuedCertificateAttributeHelperTest {
 
     /**
      * Test that subject alt name can be built with a PC and an EC.
+     *
      * @throws IOException        an IO error occurs
      * @throws URISyntaxException unrecognized URI for EC or PC Path
      */

HIRS_AttestationCA/src/test/java/hirs/attestationca/persist/validation/SupplyChainCredentialValidatorTest.java

@@ -1,26 +1,20 @@
 package hirs.attestationca.persist.validation;
 
-import hirs.attestationca.persist.entity.ArchivableEntity;
 import hirs.attestationca.persist.entity.userdefined.Certificate;
-import hirs.attestationca.persist.entity.userdefined.SupplyChainValidation;
 import hirs.attestationca.persist.entity.userdefined.certificate.CertificateAuthorityCredential;
 import hirs.attestationca.persist.entity.userdefined.certificate.EndorsementCredential;
 import hirs.attestationca.persist.entity.userdefined.certificate.PlatformCredential;
-import hirs.attestationca.persist.entity.userdefined.certificate.attributes.ComponentClass;
+import hirs.attestationca.persist.entity.userdefined.certificate.attributes.ComponentIdentifier;
-import hirs.attestationca.persist.entity.userdefined.certificate.attributes.V2.AttributeStatus;
 import hirs.attestationca.persist.entity.userdefined.info.ComponentInfo;
-import hirs.attestationca.persist.entity.userdefined.info.HardwareInfo;
-import hirs.attestationca.persist.entity.userdefined.info.OSInfo;
-import hirs.attestationca.persist.entity.userdefined.info.NetworkInfo;
 import hirs.attestationca.persist.entity.userdefined.info.FirmwareInfo;
+import hirs.attestationca.persist.entity.userdefined.info.HardwareInfo;
+import hirs.attestationca.persist.entity.userdefined.info.NetworkInfo;
+import hirs.attestationca.persist.entity.userdefined.info.OSInfo;
 import hirs.attestationca.persist.entity.userdefined.info.TPMInfo;
 import hirs.attestationca.persist.entity.userdefined.info.component.NICComponentInfo;
-import hirs.attestationca.persist.entity.userdefined.certificate.attributes.ComponentIdentifier;
-import hirs.attestationca.persist.entity.userdefined.certificate.attributes.V2.ComponentIdentifierV2;
 import hirs.attestationca.persist.entity.userdefined.report.DeviceInfoReport;
 import hirs.attestationca.persist.enums.AppraisalStatus;
 import hirs.utils.enums.DeviceInfoEnums;
-
 import org.apache.commons.io.IOUtils;
 import org.bouncycastle.asn1.ASN1Boolean;
 import org.bouncycastle.asn1.DERUTF8String;
@@ -39,18 +33,10 @@ import org.bouncycastle.openssl.PEMParser;
 import org.bouncycastle.operator.ContentSigner;
 import org.bouncycastle.operator.OperatorCreationException;
 import org.bouncycastle.operator.jcajce.JcaContentSignerBuilder;
-
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
-import static org.junit.jupiter.api.Assertions.assertTrue;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.fail;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
-
 import java.io.BufferedReader;
 import java.io.File;
 import java.io.FileOutputStream;
@@ -81,17 +67,22 @@ import java.security.cert.CertificateException;
 import java.security.cert.X509Certificate;
 import java.security.spec.InvalidKeySpecException;
 import java.security.spec.X509EncodedKeySpec;
+import java.util.ArrayList;
 import java.util.Collections;
+import java.util.Date;
 import java.util.HashSet;
+import java.util.List;
 import java.util.Objects;
 import java.util.Set;
-import java.util.List;
-import java.util.ArrayList;
-import java.util.Date;
-import java.util.Map;
-import java.util.HashMap;
 import java.util.UUID;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
 /**
  * Tests the SupplyChainCredentialValidator and CredentialValidator class.
  * Migration note: Tests specifically for test Intel Nuc Platform Credentials
@@ -100,24 +91,6 @@ import java.util.UUID;
  */
 public class SupplyChainCredentialValidatorTest {
 
-    private static final String JSON_FILE = "/config/component-class.json";
-    private static final String SAMPLE_PACCOR_OUTPUT_TXT = "/hirs/validation/sample_paccor_output.txt";
-    private static final String SAMPLE_PACCOR_OUTPUT_NOT_SPECIFIED_TXT
-            = "/hirs/validation/sample_paccor_output_not_specified_values.txt";
-    private static final String SAMPLE_TEST_PACCOR_CERT
-            = "/validation/platform_credentials_2/paccor_platform_cert.crt";
-
-    private static final String SAMPLE_PACCOR_OUTPUT_WITH_EXTRA_COMPONENT_TXT
-            = "/hirs/validation/sample_paccor_output_with_extra_component.txt";
-    private static HardwareInfo hardwareInfo;
-    private final SupplyChainCredentialValidator supplyChainCredentialValidator =
-            new SupplyChainCredentialValidator();
-
-    private final CredentialValidator credentialValidator =
-            new CredentialValidator();
-
-    private static KeyStore keyStore;
-    private static KeyStore emptyKeyStore;
     /**
      * File name used to initialize a test KeyStore.
      */
@@ -126,17 +99,21 @@ public class SupplyChainCredentialValidatorTest {
      * SecureRandom instance.
      */
     static final SecureRandom SECURE_RANDOM = new SecureRandom();
-
+    private static final String JSON_FILE = "/config/component-class.json";
+    private static final String SAMPLE_PACCOR_OUTPUT_TXT = "/hirs/validation/sample_paccor_output.txt";
+    private static final String SAMPLE_PACCOR_OUTPUT_NOT_SPECIFIED_TXT
+            = "/hirs/validation/sample_paccor_output_not_specified_values.txt";
+    private static final String SAMPLE_TEST_PACCOR_CERT
+            = "/validation/platform_credentials_2/paccor_platform_cert.crt";
+    private static final String SAMPLE_PACCOR_OUTPUT_WITH_EXTRA_COMPONENT_TXT
+            = "/hirs/validation/sample_paccor_output_with_extra_component.txt";
     private static final String TEST_SIGNING_KEY = "/validation/platform_credentials/ca.pub";
-
     private static final String TEST_PLATFORM_CRED =
             "/validation/platform_credentials/plat_cert1.pem";
     private static final String TEST_PLATFORM_CRED2 =
             "/validation/platform_credentials/pciids_plat_cert_2-0.pem";
-
     private static final String TEST_PLATFORM_CRED_BASE_CHASIS_COMBO =
             "/validation/platform_credentials/Intel_pc5.pem";
-
     private static final String TEST_BOARD_SERIAL_NUMBER = "GETY421001GV";
     private static final String TEST_CHASSIS_SERIAL_NUMBER = "G6YK42300C87";
     private static final String TEST_EK_CERT = "/certificates/nuc-2/tpmcert.pem";
@@ -145,20 +122,16 @@ public class SupplyChainCredentialValidatorTest {
     private static final String TEST_COMPONENT_MODEL = "platform2018";
     private static final String TEST_COMPONENT_REVISION = "1.0";
     private static final String BAD_SERIAL = "BAD_SERIAL";
-
     //-------Actual ST Micro Endorsement Credential Certificate Chain!--------------
     private static final String EK_CERT = "";
     private static final String INT_CA_CERT02 = "/certificates/fakestmtpmekint02.pem";
-
     //-------Generated Intel Credential Certificate Chain--------------
     private static final String INTEL_PLATFORM_CERT =
             "/validation/platform_credentials/plat_cert3.pem";
     private static final String INTEL_PLATFORM_CERT_2 =
             "/validation/platform_credentials/Intel_pc2.pem";
-
     private static final String INTEL_PLATFORM_CERT_3 =
             "/validation/platform_credentials/pciids_plat_cert_2-0.pem";
-
     private static final String INTEL_INT_CA =
             "/validation/platform_credentials/intel_chain/root/intermediate1.crt";
     private static final String FAKE_ROOT_CA =
@@ -166,7 +139,6 @@ public class SupplyChainCredentialValidatorTest {
     private static final String PLATFORM_MANUFACTURER = "Intel";
     private static final String PLATFORM_MODEL = "S2600KP";
     private static final String PLATFORM_VERSION = "H76962-350";
-
     //-------Original Intel Credential Certificate Chain--------------
     private static final String INTEL_PLATFORM_CERT_ORIG =
             "/certificates/fakeIntel_S2600KP_F00F00F00F00.pem";
@@ -174,37 +146,35 @@ public class SupplyChainCredentialValidatorTest {
             "/certificates/fakeIntelIntermediateCA.pem";
     private static final String FAKE_ROOT_CA_ORIG =
             "/certificates/fakeCA.pem";
-
     //-------Fake SGI Credential Certificate Chain--------------
     private static final String SGI_PLATFORM_CERT = "/certificates/fakeSGI_J2_F00F00F0.pem";
     private static final String SGI_INT_CA = "/certificates/fakeSGIIntermediateCA.pem";
     private static final String SGI_CRED_SERIAL_NUMBER = "F00F00F0";
-
     //-------Actual Intel NUC Platform --------------
     private static final String NUC_PLATFORM_CERT =
             "/certificates/Intel_nuc_pc.pem";
     private static final String NUC_PLATFORM_CERT_SERIAL_NUMBER = "GETY421001DY";
-
     private static final String NUC_PLATFORM_CERT2 =
             "/certificates/Intel_nuc_pc2.pem";
     private static final String NUC_PLATFORM_CERT_SERIAL_NUMBER2 = "GETY4210001M";
-
     private static final String INTEL_SIGNING_KEY = "/certificates/IntelSigningKey_20April2017.pem";
-
     private static final String NEW_NUC1 =
             "/validation/platform_credentials/Intel_pc3.cer";
+    private static HardwareInfo hardwareInfo;
+    private static KeyStore keyStore;
+    private static KeyStore emptyKeyStore;
+    private final SupplyChainCredentialValidator supplyChainCredentialValidator =
+            new SupplyChainCredentialValidator();
+    private final CredentialValidator credentialValidator =
+            new CredentialValidator();
 
     /**
      * Sets up a KeyStore for testing.
      *
-     * @throws KeyStoreException
+     * @throws KeyStoreException        if no Provider supports a KeyStoreSpi implementation for the specified type.
-     *             if no Provider supports a KeyStoreSpi implementation for the specified type.
+     * @throws NoSuchAlgorithmException if the algorithm used to check the integrity of the keystore cannot be found
-     * @throws NoSuchAlgorithmException
+     * @throws CertificateException     if any of the certificates in the keystore could not be loaded
-     *             if the algorithm used to check the integrity of the keystore cannot be found
+     * @throws IOException              if there is an I/O or format problem with the keystore data, if a password is
-     * @throws CertificateException
-     *             if any of the certificates in the keystore could not be loaded
-     * @throws IOException
-     *             if there is an I/O or format problem with the keystore data, if a password is
      *                                  required but not given, or if the given password was incorrect
      */
     @BeforeAll
@@ -234,9 +204,174 @@ public class SupplyChainCredentialValidatorTest {
         }
     }
 
+    private static DeviceInfoReport setupDeviceInfoReport() {
+        hardwareInfo = new HardwareInfo(
+                "ACME",
+                "anvil",
+                "3.0",
+                "1234",
+                "567",
+                "890");
+
+        DeviceInfoReport deviceInfoReport = mock(DeviceInfoReport.class);
+        when(deviceInfoReport.getHardwareInfo()).thenReturn(hardwareInfo);
+        return deviceInfoReport;
+    }
+
+    private static DeviceInfoReport setupDeviceInfoReportWithComponents() throws IOException {
+        return setupDeviceInfoReportWithComponents(SAMPLE_PACCOR_OUTPUT_TXT);
+    }
+
+    private static DeviceInfoReport setupDeviceInfoReportWithNotSpecifiedComponents()
+            throws IOException {
+        return setupDeviceInfoReportWithComponents(SAMPLE_PACCOR_OUTPUT_NOT_SPECIFIED_TXT);
+    }
+
+    private static DeviceInfoReport setupDeviceInfoReportWithComponents(
+            final String paccorOutputResource) throws IOException {
+        DeviceInfoReport deviceInfoReport = setupDeviceInfoReport();
+        URL url = SupplyChainCredentialValidator.class.getResource(paccorOutputResource);
+        String paccorOutputString = IOUtils.toString(url, StandardCharsets.UTF_8);
+        when(deviceInfoReport.getPaccorOutputString()).thenReturn(paccorOutputString);
+        return deviceInfoReport;
+    }
+
+    /**
+     * Creates a new RSA 1024-bit KeyPair using a Bouncy Castle Provider.
+     *
+     * @return new KeyPair
+     */
+    private static KeyPair createKeyPair() {
+        final int keySize = 1024;
+        KeyPairGenerator gen;
+        KeyPair keyPair = null;
+        try {
+            gen = KeyPairGenerator.getInstance("RSA", BouncyCastleProvider.PROVIDER_NAME);
+            gen.initialize(keySize, SECURE_RANDOM);
+            keyPair = gen.generateKeyPair();
+        } catch (NoSuchAlgorithmException | NoSuchProviderException e) {
+            fail("Error occurred while generating key pair", e);
+        }
+        return keyPair;
+    }
+
+    /**
+     * Create a new X.509 attribute certificate given the holder cert, the signing cert, and the
+     * signing key.
+     *
+     * @param targetCert   X509Certificate that will be the holder of the attribute cert
+     * @param signingCert  X509Certificate used to sign the new attribute cert
+     * @param caPrivateKey PrivateKey used to sign the new attribute cert
+     * @return new X509AttributeCertificate
+     */
+    private static X509AttributeCertificateHolder createAttributeCert(
+            final X509Certificate targetCert, final X509Certificate signingCert,
+            final PrivateKey caPrivateKey) {
+        X509AttributeCertificateHolder cert = null;
+        try {
+            final int timeRange = 50000;
+            AttributeCertificateHolder holder =
+                    new AttributeCertificateHolder(new X509CertificateHolder(
+                            targetCert.getEncoded()));
+            AttributeCertificateIssuer issuer =
+                    new AttributeCertificateIssuer(new X500Name(signingCert
+                            .getSubjectX500Principal().getName()));
+            BigInteger serialNumber = BigInteger.ONE;
+            Date notBefore = new Date(System.currentTimeMillis() - timeRange);
+            Date notAfter = new Date(System.currentTimeMillis() + timeRange);
+            X509v2AttributeCertificateBuilder builder =
+                    new X509v2AttributeCertificateBuilder(holder, issuer, serialNumber, notBefore,
+                            notAfter);
+
+            ContentSigner signer =
+                    new JcaContentSignerBuilder("SHA1WithRSA").setProvider("BC")
+                            .build(caPrivateKey);
+
+            cert = builder.build(signer);
+        } catch (CertificateEncodingException | IOException | OperatorCreationException e) {
+            fail("Exception occurred while creating a cert", e);
+        }
+
+        return cert;
+
+    }
+
+    /**
+     * Create a new X.509 public-key certificate signed by the given certificate.
+     *
+     * @param keyPair     KeyPair to create the cert for
+     * @param signingKey  PrivateKey of the signing cert
+     * @param signingCert signing cert
+     * @return new X509Certificate
+     */
+    private static X509Certificate createCertSignedByAnotherCert(final KeyPair keyPair,
+                                                                 final PrivateKey signingKey,
+                                                                 final X509Certificate signingCert) {
+        final int timeRange = 10000;
+        X509Certificate cert = null;
+        try {
+
+            X500Name issuerName = new X500Name(signingCert.getSubjectX500Principal().getName());
+            X500Name subjectName = new X500Name("CN=Test V3 Certificate");
+            BigInteger serialNumber = BigInteger.ONE;
+            Date notBefore = new Date(System.currentTimeMillis() - timeRange);
+            Date notAfter = new Date(System.currentTimeMillis() + timeRange);
+            X509v3CertificateBuilder builder =
+                    new JcaX509v3CertificateBuilder(issuerName, serialNumber, notBefore, notAfter,
+                            subjectName, keyPair.getPublic());
+            ContentSigner signer =
+                    new JcaContentSignerBuilder("SHA1WithRSA").setProvider("BC").build(signingKey);
+            return new JcaX509CertificateConverter().setProvider("BC").getCertificate(
+                    builder.build(signer));
+        } catch (Exception e) {
+            fail("Exception occurred while creating a cert", e);
+        }
+        return cert;
+    }
+
+    /**
+     * Creates a self-signed X.509 public-key certificate.
+     *
+     * @param pair KeyPair to create the cert for
+     * @return self-signed X509Certificate
+     */
+    private static X509Certificate createSelfSignedCertificate(final KeyPair pair) {
+        Security.addProvider(new BouncyCastleProvider());
+        final int timeRange = 10000;
+        X509Certificate cert = null;
+        try {
+
+            X500Name issuerName = new X500Name("CN=Test Self-Signed V3 Certificate");
+            X500Name subjectName = new X500Name("CN=Test Self-Signed V3 Certificate");
+            BigInteger serialNumber = BigInteger.ONE;
+            Date notBefore = new Date(System.currentTimeMillis() - timeRange);
+            Date notAfter = new Date(System.currentTimeMillis() + timeRange);
+            X509v3CertificateBuilder builder =
+                    new JcaX509v3CertificateBuilder(issuerName, serialNumber, notBefore, notAfter,
+                            subjectName, pair.getPublic());
+            ContentSigner signer =
+                    new JcaContentSignerBuilder("SHA1WithRSA").setProvider("BC").build(
+                            pair.getPrivate());
+            return new JcaX509CertificateConverter().setProvider("BC").getCertificate(
+                    builder.build(signer));
+        } catch (Exception e) {
+            fail("Exception occurred while creating a cert", e);
+        }
+        return cert;
+    }
+
+    private static InetAddress getTestIpAddress() {
+        try {
+            return InetAddress.getByAddress(new byte[] {127, 0, 0, 1});
+        } catch (UnknownHostException e) {
+            return null;
+        }
+    }
+
     /**
      * Checks if the ST Micro Endorsement Credential can be validated against the
      * ST/GlobalSIgn Certificate Chain.
+     *
      * @throws IOException          if error occurs while reading files
      * @throws URISyntaxException   if error occurs while reading files
      * @throws CertificateException if error occurs while processing X509 Certs
@@ -354,9 +489,9 @@ public class SupplyChainCredentialValidatorTest {
     /**
      * Checks if the Platform Credential contains the serial number from
      * the device in the platform serial number field.
-     * @throws Exception If there are errors.
      *
-     * */
+     * @throws Exception If there are errors.
+     */
 //    @Test
     public final void validatePlatformCredentialWithDeviceBaseboard()
             throws Exception {
@@ -414,10 +549,10 @@ public class SupplyChainCredentialValidatorTest {
                 result.getMessage());
     }
 
-
     /**
      * Checks if the NUC Platform Credential contains the serial number from
      * the device as a baseboard component in the serial number field.
+     *
      * @throws Exception If there are errors.
      */
 //    @Test
@@ -544,6 +679,7 @@ public class SupplyChainCredentialValidatorTest {
     /**
      * Checks if the Platform Credential validator appropriately fails
      * when there are no serial numbers returned from the device.
+     *
      * @throws Exception If there are errors.
      */
 //    @Test
@@ -578,6 +714,7 @@ public class SupplyChainCredentialValidatorTest {
     /**
      * Checks if the Platform Credential validator appropriately fails
      * when there are no serial numbers matching any of the platform info from the device.
+     *
      * @throws Exception If there are errors.
      */
 //    @Test
@@ -992,6 +1129,7 @@ public class SupplyChainCredentialValidatorTest {
     /**
      * Tests that issuer/subject distinguished names can be properly verified as equal even
      * if their elements are in different orders.
+     *
      * @throws URISyntaxException            failed to read certificate
      * @throws IOException                   failed to read certificate
      * @throws KeyStoreException             failed to read key store
@@ -1023,6 +1161,7 @@ public class SupplyChainCredentialValidatorTest {
     /**
      * Tests that issuer/subject distinguished names can be properly verified as being unequal
      * if their elements don't match.
+     *
      * @throws URISyntaxException            failed to read certificate
      * @throws IOException                   failed to read certificate
      * @throws KeyStoreException             failed to read key store
@@ -1052,6 +1191,7 @@ public class SupplyChainCredentialValidatorTest {
 
     /**
      * Tests that issuer/subject distinguished names can be properly verified as equal.
+     *
      * @throws URISyntaxException            failed to read certificate
      * @throws IOException                   failed to read certificate
      * @throws KeyStoreException             failed to read key store
@@ -1082,6 +1222,7 @@ public class SupplyChainCredentialValidatorTest {
     /**
      * Tests that issuer/subject distinguished names can be properly verified as being unequal
      * if their elements don't match.
+     *
      * @throws URISyntaxException            failed to read certificate
      * @throws IOException                   failed to read certificate
      * @throws KeyStoreException             failed to read key store
@@ -1109,38 +1250,6 @@ public class SupplyChainCredentialValidatorTest {
                 x509Cert, caX509));
     }
 
-    private static DeviceInfoReport setupDeviceInfoReport() {
-        hardwareInfo = new HardwareInfo(
-                "ACME",
-                "anvil",
-                "3.0",
-                "1234",
-                "567",
-                "890");
-
-        DeviceInfoReport deviceInfoReport = mock(DeviceInfoReport.class);
-        when(deviceInfoReport.getHardwareInfo()).thenReturn(hardwareInfo);
-        return deviceInfoReport;
-    }
-
-    private static DeviceInfoReport setupDeviceInfoReportWithComponents() throws IOException {
-        return setupDeviceInfoReportWithComponents(SAMPLE_PACCOR_OUTPUT_TXT);
-    }
-
-    private static DeviceInfoReport setupDeviceInfoReportWithNotSpecifiedComponents()
-            throws IOException {
-        return setupDeviceInfoReportWithComponents(SAMPLE_PACCOR_OUTPUT_NOT_SPECIFIED_TXT);
-    }
-
-    private static DeviceInfoReport setupDeviceInfoReportWithComponents(
-            final String paccorOutputResource) throws IOException {
-        DeviceInfoReport deviceInfoReport = setupDeviceInfoReport();
-        URL url = SupplyChainCredentialValidator.class.getResource(paccorOutputResource);
-        String paccorOutputString = IOUtils.toString(url, StandardCharsets.UTF_8);
-        when(deviceInfoReport.getPaccorOutputString()).thenReturn(paccorOutputString);
-        return deviceInfoReport;
-    }
-
     /**
      * Tests that isMatch works correctly in comparing component info to component identifier.
      */
@@ -1231,6 +1340,7 @@ public class SupplyChainCredentialValidatorTest {
     /**
      * Tests that TPM 2.0 Platform Credentials validate correctly against the device info report
      * when there are no components.
+     *
      * @throws IOException if unable to set up DeviceInfoReport from resource file
      */
 //    @Test
@@ -1251,6 +1361,7 @@ public class SupplyChainCredentialValidatorTest {
     /**
      * Tests that TPM 2.0 Platform Credentials validate correctly against the device info report
      * when there are components present.
+     *
      * @throws IOException if unable to set up DeviceInfoReport from resource file
      */
 //    @Test
@@ -1271,6 +1382,7 @@ public class SupplyChainCredentialValidatorTest {
      * Tests that TPM 2.0 Platform Credentials validate correctly against the device info report
      * when there are components present, and when the PlatformSerial field holds the system's
      * serial number instead of the baseboard serial number.
+     *
      * @throws IOException if unable to set up DeviceInfoReport from resource file
      */
 //    @Test
@@ -1293,6 +1405,7 @@ public class SupplyChainCredentialValidatorTest {
      * Tests that TPM 2.0 Platform Credentials validate correctly against the device info report
      * when there are components present, and when the PlatformSerial field holds the system's
      * serial number instead of the baseboard serial number.
+     *
      * @throws IOException        if unable to set up DeviceInfoReport from resource file
      * @throws URISyntaxException failed to read certificate
      */
@@ -1313,6 +1426,7 @@ public class SupplyChainCredentialValidatorTest {
 
     /**
      * Tests that the SupplyChainCredentialValidator fails when required fields are null.
+     *
      * @throws IOException if unable to set up DeviceInfoReport from resource file
      */
 //    @Test
@@ -1425,6 +1539,7 @@ public class SupplyChainCredentialValidatorTest {
     /**
      * Tests that the SupplyChainCredentialValidator fails when required fields contain only empty
      * strings.
+     *
      * @throws IOException if unable to set up DeviceInfoReport from resource file
      */
 //    @Test
@@ -1541,6 +1656,7 @@ public class SupplyChainCredentialValidatorTest {
     /**
      * Tests that {@link SupplyChainCredentialValidator} failes when a component exists in the
      * platform credential, but not in the device info report.
+     *
      * @throws IOException if unable to set up DeviceInfoReport from resource file
      */
 //    @Test
@@ -1585,6 +1701,7 @@ public class SupplyChainCredentialValidatorTest {
      * Tests that SupplyChainCredentialValidator passes when everything matches but there are
      * extra components in the device info report that are not represented in the platform
      * credential.
+     *
      * @throws IOException if unable to set up DeviceInfoReport from resource file
      */
 //    @Test
@@ -1617,6 +1734,7 @@ public class SupplyChainCredentialValidatorTest {
     /**
      * Tests that SupplyChainCredentialValidator fails when a component is found in the platform
      * credential without a manufacturer or model.
+     *
      * @throws IOException if unable to set up DeviceInfoReport from resource file
      */
 //    @Test
@@ -1673,6 +1791,7 @@ public class SupplyChainCredentialValidatorTest {
     /**
      * Tests that SupplyChainCredentialValidator passes when a component on the system has a
      * matching component in the platform certificate, except the serial value is missing.
+     *
      * @throws IOException if unable to set up DeviceInfoReport from resource file
      */
 //    @Test
@@ -1704,6 +1823,7 @@ public class SupplyChainCredentialValidatorTest {
     /**
      * Tests that SupplyChainCredentialValidator passes when a component on the system has a
      * matching component in the platform certificate, except the revision value is missing.
+     *
      * @throws IOException if unable to set up DeviceInfoReport from resource file
      */
 //    @Test
@@ -1736,6 +1856,7 @@ public class SupplyChainCredentialValidatorTest {
      * Tests that SupplyChainCredentialValidator passes when a component on the system has a
      * matching component in the platform certificate, except the serial and revision values
      * are missing.
+     *
      * @throws IOException if unable to set up DeviceInfoReport from resource file
      */
 //    @Test
@@ -1768,6 +1889,7 @@ public class SupplyChainCredentialValidatorTest {
     /**
      * Tests that SupplyChainCredentialValidator passes with a base and delta certificate where
      * the base serial number and delta holder serial number match.
+     *
      * @throws java.io.IOException         Reading file for the certificates
      * @throws java.net.URISyntaxException when loading certificates bytes
      */
@@ -1904,6 +2026,7 @@ public class SupplyChainCredentialValidatorTest {
     /**
      * Tests that SupplyChainCredentialValidator fails when a component needs to
      * be replaced but hasn't been by a delta certificate.
+     *
      * @throws java.io.IOException         Reading file for the certificates
      * @throws java.net.URISyntaxException when loading certificates bytes
      */
@@ -2014,136 +2137,6 @@ public class SupplyChainCredentialValidatorTest {
 //                result.getMessage());
     }
 
-    /**
-     * Creates a new RSA 1024-bit KeyPair using a Bouncy Castle Provider.
-     *
-     * @return new KeyPair
-     */
-    private static KeyPair createKeyPair() {
-        final int keySize = 1024;
-        KeyPairGenerator gen;
-        KeyPair keyPair = null;
-        try {
-            gen = KeyPairGenerator.getInstance("RSA", BouncyCastleProvider.PROVIDER_NAME);
-            gen.initialize(keySize, SECURE_RANDOM);
-            keyPair = gen.generateKeyPair();
-        } catch (NoSuchAlgorithmException | NoSuchProviderException e) {
-            fail("Error occurred while generating key pair", e);
-        }
-        return keyPair;
-    }
-
-    /**
-     * Create a new X.509 attribute certificate given the holder cert, the signing cert, and the
-     * signing key.
-     *
-     * @param targetCert
-     *            X509Certificate that will be the holder of the attribute cert
-     * @param signingCert
-     *            X509Certificate used to sign the new attribute cert
-     * @param caPrivateKey
-     *            PrivateKey used to sign the new attribute cert
-     * @return new X509AttributeCertificate
-     */
-    private static X509AttributeCertificateHolder createAttributeCert(
-            final X509Certificate targetCert, final X509Certificate signingCert,
-            final PrivateKey caPrivateKey) {
-        X509AttributeCertificateHolder cert = null;
-        try {
-            final int timeRange = 50000;
-            AttributeCertificateHolder holder =
-                    new AttributeCertificateHolder(new X509CertificateHolder(
-                            targetCert.getEncoded()));
-            AttributeCertificateIssuer issuer =
-                    new AttributeCertificateIssuer(new X500Name(signingCert
-                            .getSubjectX500Principal().getName()));
-            BigInteger serialNumber = BigInteger.ONE;
-            Date notBefore = new Date(System.currentTimeMillis() - timeRange);
-            Date notAfter = new Date(System.currentTimeMillis() + timeRange);
-            X509v2AttributeCertificateBuilder builder =
-                    new X509v2AttributeCertificateBuilder(holder, issuer, serialNumber, notBefore,
-                            notAfter);
-
-            ContentSigner signer =
-                    new JcaContentSignerBuilder("SHA1WithRSA").setProvider("BC")
-                            .build(caPrivateKey);
-
-            cert = builder.build(signer);
-        } catch (CertificateEncodingException | IOException | OperatorCreationException e) {
-            fail("Exception occurred while creating a cert", e);
-        }
-
-        return cert;
-
-    }
-
-    /**
-     * Create a new X.509 public-key certificate signed by the given certificate.
-     *
-     * @param keyPair
-     *            KeyPair to create the cert for
-     * @param signingKey
-     *            PrivateKey of the signing cert
-     * @param signingCert
-     *            signing cert
-     * @return new X509Certificate
-     */
-    private static X509Certificate createCertSignedByAnotherCert(final KeyPair keyPair,
-            final PrivateKey signingKey, final X509Certificate signingCert) {
-        final int timeRange = 10000;
-        X509Certificate cert = null;
-        try {
-
-            X500Name issuerName = new X500Name(signingCert.getSubjectX500Principal().getName());
-            X500Name subjectName = new X500Name("CN=Test V3 Certificate");
-            BigInteger serialNumber = BigInteger.ONE;
-            Date notBefore = new Date(System.currentTimeMillis() - timeRange);
-            Date notAfter = new Date(System.currentTimeMillis() + timeRange);
-            X509v3CertificateBuilder builder =
-                    new JcaX509v3CertificateBuilder(issuerName, serialNumber, notBefore, notAfter,
-                            subjectName, keyPair.getPublic());
-            ContentSigner signer =
-                    new JcaContentSignerBuilder("SHA1WithRSA").setProvider("BC").build(signingKey);
-            return new JcaX509CertificateConverter().setProvider("BC").getCertificate(
-                    builder.build(signer));
-        } catch (Exception e) {
-            fail("Exception occurred while creating a cert", e);
-        }
-        return cert;
-    }
-
-    /**
-     * Creates a self-signed X.509 public-key certificate.
-     *
-     * @param pair
-     *            KeyPair to create the cert for
-     * @return self-signed X509Certificate
-     */
-    private static X509Certificate createSelfSignedCertificate(final KeyPair pair) {
-        Security.addProvider(new BouncyCastleProvider());
-        final int timeRange = 10000;
-        X509Certificate cert = null;
-        try {
-
-            X500Name issuerName = new X500Name("CN=Test Self-Signed V3 Certificate");
-            X500Name subjectName = new X500Name("CN=Test Self-Signed V3 Certificate");
-            BigInteger serialNumber = BigInteger.ONE;
-            Date notBefore = new Date(System.currentTimeMillis() - timeRange);
-            Date notAfter = new Date(System.currentTimeMillis() + timeRange);
-            X509v3CertificateBuilder builder =
-                    new JcaX509v3CertificateBuilder(issuerName, serialNumber, notBefore, notAfter,
-                            subjectName, pair.getPublic());
-            ContentSigner signer =
-                    new JcaContentSignerBuilder("SHA1WithRSA").setProvider("BC").build(
-                            pair.getPrivate());
-            return new JcaX509CertificateConverter().setProvider("BC").getCertificate(
-                    builder.build(signer));
-        } catch (Exception e) {
-            fail("Exception occurred while creating a cert", e);
-        }
-        return cert;
-    }
-
     private DeviceInfoReport buildReport(final HardwareInfo givenHardwareInfo) {
         final InetAddress ipAddress = getTestIpAddress();
         final byte[] macAddress = new byte[] {11, 22, 33, 44, 55, 66};
@@ -2156,11 +2149,4 @@ public class SupplyChainCredentialValidatorTest {
         return new DeviceInfoReport(networkInfo, osInfo,
                 firmwareInfo, givenHardwareInfo, tpmInfo);
     }
-    private static InetAddress getTestIpAddress() {
-        try {
-            return InetAddress.getByAddress(new byte[] {127, 0, 0, 1});
-        } catch (UnknownHostException e) {
-            return null;
-        }
-    }
 }