From a32d3a5f02dc7b1cb6d061c257e4f51f16419285 Mon Sep 17 00:00:00 2001 From: Cyrus <24922493+cyrus-dev@users.noreply.github.com> Date: Tue, 1 Dec 2020 09:46:05 -0500 Subject: [PATCH] Remove comments --- .../service/SupplyChainValidationServiceImpl.java | 14 +++----------- .../validation/SupplyChainCredentialValidator.java | 8 -------- 2 files changed, 3 insertions(+), 19 deletions(-) diff --git a/HIRS_AttestationCA/src/main/java/hirs/attestationca/service/SupplyChainValidationServiceImpl.java b/HIRS_AttestationCA/src/main/java/hirs/attestationca/service/SupplyChainValidationServiceImpl.java index 95c26c8b..48662096 100644 --- a/HIRS_AttestationCA/src/main/java/hirs/attestationca/service/SupplyChainValidationServiceImpl.java +++ b/HIRS_AttestationCA/src/main/java/hirs/attestationca/service/SupplyChainValidationServiceImpl.java @@ -204,21 +204,13 @@ public class SupplyChainValidationServiceImpl implements SupplyChainValidationSe if (pc.isDeltaChain()) { // this check validates the delta changes and re-compares // the modified list to the original. - try { - attributeScv = validateDeltaPlatformCredentialAttributes( - pc, device.getDeviceInfo(), - baseCredential, deltaMapping); - } catch (Exception ex) { - for (StackTraceElement element : ex.getStackTrace()) { - LOGGER.error(element.toString()); - } - LOGGER.error(ex.getMessage()); - } + attributeScv = validateDeltaPlatformCredentialAttributes( + pc, device.getDeviceInfo(), + baseCredential, deltaMapping); } else { attributeScv = validatePlatformCredentialAttributes( pc, device.getDeviceInfo(), ec); } - if (platformScv != null) { // have to make sure the attribute validation isn't ignored and // doesn't override general validation status diff --git a/HIRS_Utils/src/main/java/hirs/validation/SupplyChainCredentialValidator.java b/HIRS_Utils/src/main/java/hirs/validation/SupplyChainCredentialValidator.java index 0bc16c29..4ecdbb8f 100644 --- a/HIRS_Utils/src/main/java/hirs/validation/SupplyChainCredentialValidator.java +++ b/HIRS_Utils/src/main/java/hirs/validation/SupplyChainCredentialValidator.java @@ -810,17 +810,9 @@ public final class SupplyChainCredentialValidator implements CredentialValidator ciV2 = (ComponentIdentifierV2) cId; if (ciV2.getComponentClass().getClassValueString() .contains(cInfo.getComponentClass())) { - // TDM RIGHT HERE, you are getting a # from componentclass - /** - * YOU CAN DO IT. Don't fall asleep -_- - */ if (isMatch(cId, cInfo)) { - LOGGER.error("TDM - Removed items"); subCompIdList.remove(cId); subCompInfoList.remove(cInfo); - } else { - // FUCK PMD - LOGGER.error("No match"); } } }