Last changes that resolve remaining spotbugs issues

This commit is contained in:
Cyrus 2024-01-19 07:45:36 -05:00
parent 575baa3409
commit 60729164c8
3 changed files with 13 additions and 4 deletions

View File

@ -2,7 +2,10 @@
<!-- Docs at http://findbugs.sourceforge.net/manual/filter.html -->
<FindBugsFilter>
<Match>
<Package name="~hirs\.utils.xjc.*" />
<Package name="~hirs\.utils.xjc.*" />
</Match>
<Match>
<Package name="~hirs\.utils.rim.*" />
</Match>
<Match>
<!-- https://github.com/spotbugs/spotbugs/pull/2748 -->

View File

@ -48,40 +48,46 @@ import java.util.List;
* 6. The version of the log is used to determine which format the Log
* is to use (sha1 or Crypto Agile)
*/
@Getter
public class EvEfiSpecIdEvent {
/**
* Minor Version.
*/
@Getter
private String versionMinor = "";
/**
* Major Version.
*/
@Getter
private String versionMajor = "";
/**
* Specification errata version.
*/
@Getter
private String errata = "";
/**
* Signature (text) data.
*/
@Getter
private String signature = "";
/**
* Platform class.
*/
@Getter
private String platformClass = "";
/**
* Algorithm count.
*/
@Getter
private int numberOfAlg = 0;
/**
* True if event log uses Crypto Agile format.
*/
@Getter
private boolean cryptoAgile = false;
/**
* Algorithm list.
*/
private List<String> algList = new ArrayList<String>();
private List<String> algList;
/**
* EvEfiSpecIdEvent Constructor.
@ -89,6 +95,7 @@ public class EvEfiSpecIdEvent {
* @param efiSpecId byte array holding the spec ID Event.
*/
public EvEfiSpecIdEvent(final byte[] efiSpecId) {
algList = new ArrayList<>();
byte[] signatureBytes = new byte[UefiConstants.SIZE_16];
System.arraycopy(efiSpecId, 0, signatureBytes, 0, UefiConstants.SIZE_16);
signature = HexUtils.byteArrayToHexString(signatureBytes);

View File

@ -32,7 +32,6 @@ public class UefiVariable {
/**
* List of Signature lists.
*/
@Getter
private List<UefiSignatureList> certSuperList;
/**
* Name of the UEFI variable.