mirror of
https://github.com/AFLplusplus/AFLplusplus.git
synced 2025-06-13 02:28:09 +00:00
clang-tidy readability-braces (#323)
This commit is contained in:
@ -101,7 +101,7 @@ void detect_file_args(char **argv, u8 *prog_in, u8 *use_stdin) {
|
||||
|
||||
if (aa_loc) {
|
||||
|
||||
if (!prog_in) FATAL("@@ syntax is not supported by this tool.");
|
||||
if (!prog_in) { FATAL("@@ syntax is not supported by this tool."); }
|
||||
|
||||
*use_stdin = 0;
|
||||
|
||||
@ -198,7 +198,7 @@ char **get_qemu_argv(u8 *own_loc, u8 **target_path_p, int argc, char **argv) {
|
||||
|
||||
cp = alloc_printf("%s/afl-qemu-trace", tmp);
|
||||
|
||||
if (access(cp, X_OK)) FATAL("Unable to find '%s'", tmp);
|
||||
if (access(cp, X_OK)) { FATAL("Unable to find '%s'", tmp); }
|
||||
|
||||
*target_path_p = new_argv[0] = cp;
|
||||
return new_argv;
|
||||
@ -230,7 +230,7 @@ char **get_qemu_argv(u8 *own_loc, u8 **target_path_p, int argc, char **argv) {
|
||||
|
||||
if (!access(BIN_PATH "/afl-qemu-trace", X_OK)) {
|
||||
|
||||
if (cp) ck_free(cp);
|
||||
if (cp) { ck_free(cp); }
|
||||
*target_path_p = new_argv[0] = ck_strdup(BIN_PATH "/afl-qemu-trace");
|
||||
|
||||
return new_argv;
|
||||
@ -277,13 +277,13 @@ char **get_wine_argv(u8 *own_loc, u8 **target_path_p, int argc, char **argv) {
|
||||
|
||||
cp = alloc_printf("%s/afl-qemu-trace", tmp);
|
||||
|
||||
if (access(cp, X_OK)) FATAL("Unable to find '%s'", tmp);
|
||||
if (access(cp, X_OK)) { FATAL("Unable to find '%s'", tmp); }
|
||||
|
||||
ck_free(cp);
|
||||
|
||||
cp = alloc_printf("%s/afl-wine-trace", tmp);
|
||||
|
||||
if (access(cp, X_OK)) FATAL("Unable to find '%s'", tmp);
|
||||
if (access(cp, X_OK)) { FATAL("Unable to find '%s'", tmp); }
|
||||
|
||||
*target_path_p = new_argv[0] = cp;
|
||||
return new_argv;
|
||||
@ -416,15 +416,22 @@ u8 *find_binary(u8 *fname) {
|
||||
ck_free(cur_elem);
|
||||
|
||||
if (!stat(target_path, &st) && S_ISREG(st.st_mode) &&
|
||||
(st.st_mode & 0111) && st.st_size >= 4)
|
||||
(st.st_mode & 0111) && st.st_size >= 4) {
|
||||
|
||||
break;
|
||||
|
||||
}
|
||||
|
||||
ck_free(target_path);
|
||||
target_path = NULL;
|
||||
|
||||
}
|
||||
|
||||
if (!target_path) FATAL("Program '%s' not found or not executable", fname);
|
||||
if (!target_path) {
|
||||
|
||||
FATAL("Program '%s' not found or not executable", fname);
|
||||
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
@ -434,7 +441,7 @@ u8 *find_binary(u8 *fname) {
|
||||
|
||||
void check_environment_vars(char **envp) {
|
||||
|
||||
if (be_quiet) return;
|
||||
if (be_quiet) { return; }
|
||||
|
||||
int index = 0, found = 0;
|
||||
char *env, *val;
|
||||
@ -448,24 +455,30 @@ void check_environment_vars(char **envp) {
|
||||
} else if (strncmp(env, "AFL_", 4) == 0) {
|
||||
|
||||
int i = 0, match = 0;
|
||||
while (match == 0 && afl_environment_variables[i] != NULL)
|
||||
while (match == 0 && afl_environment_variables[i] != NULL) {
|
||||
|
||||
if (strncmp(env, afl_environment_variables[i],
|
||||
strlen(afl_environment_variables[i])) == 0 &&
|
||||
env[strlen(afl_environment_variables[i])] == '=') {
|
||||
|
||||
match = 1;
|
||||
if ((val = getenv(afl_environment_variables[i])) && !*val)
|
||||
if ((val = getenv(afl_environment_variables[i])) && !*val) {
|
||||
|
||||
WARNF(
|
||||
"AFL environment variable %s defined but is empty, this can "
|
||||
"lead to unexpected consequences",
|
||||
afl_environment_variables[i]);
|
||||
|
||||
}
|
||||
|
||||
} else {
|
||||
|
||||
i++;
|
||||
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
if (match == 0) {
|
||||
|
||||
WARNF("Mistyped AFL environment variable: %s", env);
|
||||
@ -477,7 +490,7 @@ void check_environment_vars(char **envp) {
|
||||
|
||||
}
|
||||
|
||||
if (found) sleep(2);
|
||||
if (found) { sleep(2); }
|
||||
|
||||
}
|
||||
|
||||
@ -485,10 +498,16 @@ char *get_afl_env(char *env) {
|
||||
|
||||
char *val;
|
||||
|
||||
if ((val = getenv(env)) != NULL)
|
||||
if (!be_quiet)
|
||||
if ((val = getenv(env)) != NULL) {
|
||||
|
||||
if (!be_quiet) {
|
||||
|
||||
OKF("Loaded environment variable %s with value %s", env, val);
|
||||
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
return val;
|
||||
|
||||
}
|
||||
@ -499,7 +518,7 @@ void read_bitmap(u8 *fname, u8 *map, size_t len) {
|
||||
|
||||
s32 fd = open(fname, O_RDONLY);
|
||||
|
||||
if (fd < 0) PFATAL("Unable to open '%s'", fname);
|
||||
if (fd < 0) { PFATAL("Unable to open '%s'", fname); }
|
||||
|
||||
ck_read(fd, map, len, fname);
|
||||
|
||||
@ -906,9 +925,13 @@ u32 get_map_size() {
|
||||
if ((ptr = getenv("AFL_MAP_SIZE")) || (ptr = getenv("AFL_MAPSIZE"))) {
|
||||
|
||||
map_size = atoi(ptr);
|
||||
if (map_size < 8 || map_size > (1 << 29))
|
||||
if (map_size < 8 || map_size > (1 << 29)) {
|
||||
|
||||
FATAL("illegal AFL_MAP_SIZE %u, must be between 2^3 and 2^30", map_size);
|
||||
if (map_size % 8) map_size = (((map_size >> 3) + 1) << 3);
|
||||
|
||||
}
|
||||
|
||||
if (map_size % 8) { map_size = (((map_size >> 3) + 1) << 3); }
|
||||
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user