ExternalVendorCode/AFLplusplus
1
0
Fork 0
mirror of https://github.com/AFLplusplus/AFLplusplus.git synced 2025-06-13 18:48:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix undefined behavior by casting to uint64_t before left shift

Browse Source 
According to the C standard, left-shifting a value by an amount greater
than or equal to the width of its promoted type results in undefined
behavior. To prevent potential unexpected results, explicitly cast the
uint8_t variable type to uint64_t before performing the left shift
operation by 56 bits. This ensures the operation is well-defined and
adheres to the standard.

Fixes: 40df85d1 ("adjust cmplog header")
This commit is contained in:
Kuan-Wei Chiu
2024-06-12 12:48:13 +08:00
parent 75c3fa91dc
commit 0c9d8e5929
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/hashmap.c
View File

@ -59,7 +59,7 @@ static inline unsigned int hash(uint64_t key) {
bool hashmap_search_and_add(uint8_t type, uint64_t key) { bool hashmap_search_and_add(uint8_t type, uint64_t key) {
if (unlikely(type >= 8)) return false; if (unlikely(type >= 8)) return false;
uint64_t val = (key & 0xf8ffffffffffffff) + (type << 56); uint64_t val = (key & 0xf8ffffffffffffff) + ((uint64_t)type << 56);
unsigned int index = hash(val); unsigned int index = hash(val);
HashNode *node = _hashmap->table[index]; HashNode *node = _hashmap->table[index];
while (node) { while (node) {